[Rails-core] Re: Migrating to rails_xss

2009-10-19 Thread Rob Sanheim
On Thu, Oct 15, 2009 at 6:27 PM, dasil003 wrote: > > Okay, now that this is merged into edge, I'm keen on prepping my > 30,000 line app to make this transition a little smoother. I know > it's going to be hairy because of the hundreds of helpers and oddball > code paths we have. Simply upgradin

[Rails-core] Re: Make rake gems:build respect Rails.env

2009-01-26 Thread Rob Sanheim
On Sun, Jan 25, 2009 at 5:39 PM, Chad Woolley wrote: > > On Sun, Jan 25, 2009 at 9:08 AM, Josh Susser wrote: >> >> This is a good improvement, but I dislike that building gems loads the >> environment at all. If something in your environment file uses a >> class defined in a gem, you get a circ

[Rails-core] Re: Integrity for CI instead of CC.rb?

2009-01-20 Thread Rob Sanheim
On Thu, Jan 15, 2009 at 11:29 AM, Mike Gunderloy wrote: > > One note on this: we probably *don't* want to just run the tests with > multiruby. Instead, we want to have multiple versions of ruby > installed, and run the tests separately with each version. That makes > it much easier to spot whethe

[Rails-core] Re: Problem with generated tests

2008-06-24 Thread Rob Sanheim
On Tue, Jun 24, 2008 at 9:59 AM, Raul Murciano <[EMAIL PROTECTED]> wrote: > > It's being discussed here: http://github.com/rails/rails/commit/e8170805 > Great, only three places to check for core discussion now! Lighthouse, github, and here. ;) - Rob --~--~-~--~~~---

[Rails-core] Re: Problem with generated tests

2008-06-24 Thread Rob Sanheim
On Tue, Jun 24, 2008 at 2:35 AM, Lance Carlson <[EMAIL PROTECTED]> wrote: > > Hi everyone, > > This may not be an issue, but I'm just checking. When I generate a > scaffold in rails 2.1, all of the tests that get generated have a > require 'test_helper' at the top. When you try to run a test > ind

[Rails-core] Re: ActiveSupport::Dependencies does not exist on branch

2008-06-09 Thread Rob Sanheim
I posted on this a few days back and also created a ticket: http://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/331 - rob http://robsanheim.com On Mon, Jun 9, 2008 at 4:37 PM, acechase <[EMAIL PROTECTED]> wrote: > > p.s. running: "git revert cce30f71246dbc5433153156afa4f952553a

[Rails-core] Re: rails 2-1 stable branch broken?

2008-06-04 Thread Rob Sanheim
Hm, could someone whitelist the ticket -- it got marked as spam. - Rob On Wed, Jun 4, 2008 at 9:49 AM, Rob Sanheim <[EMAIL PROTECTED]> wrote: > Can someone take a look and confirm this? > > http://rails.lighthouseapp.com/projects/8994/tickets/331-2-1-stable-branch-broken#ticke

[Rails-core] rails 2-1 stable branch broken?

2008-06-04 Thread Rob Sanheim
Can someone take a look and confirm this? http://rails.lighthouseapp.com/projects/8994/tickets/331-2-1-stable-branch-broken#ticket-331-1 I'm also seeing Dependancy issues with HEAD right now related to the Dependancies move to under ActiveSupport, but I'm assuming things are just in flux right n

[Rails-core] Re: shuffling the application load order around

2008-02-01 Thread Rob Sanheim
I think this would also fix this issue: http://robsanheim.com/2008/01/08/rails-observers-make-rake-dbmigrate-crash-from-version-0/ - Rob On Feb 1, 2008 3:41 PM, Rick Olson <[EMAIL PROTECTED]> wrote: > > I want to shuffle things around so that routes and observers are > loaded last, after plugin

[Rails-core] Re: application.rb -> application_controller.rb

2008-01-16 Thread Rob Sanheim
On Jan 16, 2008 12:41 PM, Rick DeNatale <[EMAIL PROTECTED]> wrote: > > On 1/16/08, ara.t.howard <[EMAIL PROTECTED]> wrote: > > > > > > On Jan 16, 2008, at 8:33 AM, Pratik wrote: > > > > > > > > Btw, I like the idea of renaming it to Application instead of > > > ApplicationController, in case we *m

[Rails-core] Re: Rails core team - only development?

2007-12-13 Thread Rob Sanheim
Has anyone looked at what other OSS projects have done differently to enable successful doc projects created or contributed to by the community? I'm thinking in particular of the django book, and maybe also php.net. What do they do differently to address the people problems that we see in the Ra

[Rails-core] Re: rails documentation for older releases

2007-12-10 Thread Rob Sanheim
On Dec 10, 2007 12:38 AM, Andrew Kaspick <[EMAIL PROTECTED]> wrote: > > Hello, > > So rails 2.0 has been released and the docs @ api.rubyonrails.com are > 2.0'ed now as well. Are there any plans at all to provide > documentation for older rails releases? > > Working on projects that are still usi

[Rails-core] Re: Merb-style development exception pages for Mac OS X

2007-12-07 Thread Rob Sanheim
On Dec 6, 2007 9:01 PM, chuyeow <[EMAIL PROTECTED]> wrote: > > I like the merb-style exception pages where there're links to open the > files listed in the stack trace in TextMate and the source around each > line a lot so I stole the idea (and the code!) and made a patch for > Rails: http://dev.r

[Rails-core] Re: versioning strategy

2007-11-12 Thread Rob Sanheim
On 11/12/07, ara.t.howard <[EMAIL PROTECTED]> wrote: > > hi all- > > upgrading some apps from 1.2.3 -->> 1.2.5 and having all kinds of > issues. lot's of functions have disappeared between versions, for > instance #default_value in the pg connection adapter which breaks > drysql, render_action di

[Rails-core] Re: [PATCH] How about a pre-initialization hook in boot.rb?

2007-10-31 Thread Rob Sanheim
On 10/31/07, Jeremy Evans <[EMAIL PROTECTED]> wrote: > > On 10/31/07, Chad Woolley <[EMAIL PROTECTED]> wrote: > > > > On 10/25/07, Michael Koziarski <[EMAIL PROTECTED]> wrote: > > > What are the other issues that you've hit? If it's just about choosing > > > a different version of rails, then can'

[Rails-core] Re: Rails, Class Variables and Ruby 1.9

2007-10-23 Thread Rob Sanheim
Why not start testing edge rails against Ruby 1.9 in the continuous integration build (as well as on local dev machines, of course), so that breaking changes could be caught well before ruby 1.9 goes public. - Rob On 10/23/07, Jeff <[EMAIL PROTECTED]> wrote: > > On Oct 23, 6:40 pm, "Michael Kozi

[Rails-core] Re: [PATCH] How about a pre-initialization hook in boot.rb?

2007-10-22 Thread Rob Sanheim
On 10/21/07, Chad Woolley <[EMAIL PROTECTED]> wrote: > > Howdy, > > Please take a look at Enhancement #9943 (2) and see what you think. > Here's the pitch for this little 5-line patch: > > Even though boot.rb has the familiar "Don't change this file..." > message, sometimes I want to. > > This wou

[Rails-core] Re: error with OPTION in Rails:Edge

2007-10-02 Thread Rob Sanheim
I just hit this the same error a couple days ago against plain 1.2.3, and I can confirm that I had a bad require in my environments.rb. - Rob On 10/2/07, Kevin Clark <[EMAIL PROTECTED]> wrote: > > I've hit this a couple times, but I don't remember the _exact_ cause and fix. > > I _believe_ that

[Rails-core] Re: assert_select XML fix again

2007-09-10 Thread Rob Sanheim
+1. - Rob On 9/7/07, Gabe da Silveira <[EMAIL PROTECTED]> wrote: > A few months ago I created a patch to fix the assert_select xml problem: > > http://weblog.jamisbuck.org/2007/1/4/assert_xml_select > > My patch is at: > > http://dev.rubyonrails.org/ticket/8173 > > Last month I tried to get it a

[Rails-core] Re: Could a core member take a moment to commit these patches?

2007-07-12 Thread Rob Sanheim
On 7/12/07, Gabe da Silveira <[EMAIL PROTECTED]> wrote: > > On 7/11/07, Michael Koziarski <[EMAIL PROTECTED]> wrote: > > > > Applied. Thanks! > > Thank you! > > > > http://dev.rubyonrails.org/ticket/8173 > > > assert_select and xml is way outside my comfort zone so I'll pass on > > this one. Any

[Rails-core] Re: Localization of Rails core

2007-05-23 Thread Rob Sanheim
On 5/23/07, Joshua Sierles <[EMAIL PROTECTED]> wrote: > > > > > > > It seems the best bet is to leave the concern entirely outside rails > > itself, until the current disparate efforts can be folded into a > > single 'best practise'. Failing that, perhaps it's something where > > there isn't a

[Rails-core] Re: Calling Pagination Users

2007-05-07 Thread Rob Sanheim
On 5/6/07, Michael Koziarski <[EMAIL PROTECTED]> wrote: > > Hey guys, > > As rails 2.0 approaches, pagination will be removed from rails core > and delegated to a plugin.One of the reasons for this is that no > one on the core team uses pagination on a regular basis. Rather than > just create

[Rails-core] Re: Possible solution to multiple connections

2007-04-13 Thread Rob Sanheim
On 4/13/07, Dr Nic <[EMAIL PROTECTED]> wrote: > > Just to retort my own idea - I don't know all the permutations that > uber-production cluster setups use, nor do I know people that use > them. So the chance of me making an arse of this multiple connections > business is high. > > Nonetheless, it

[Rails-core] Re: Deprecate dynamic scaffolding

2007-03-02 Thread Rob Sanheim
On 3/2/07, Jeff <[EMAIL PROTECTED]> wrote: > > On Mar 2, 5:45 am, "Wayne E. Seguin" <[EMAIL PROTECTED]> wrote: > > On Mar 02, 2007, at 00:33 , Dave Thomas wrote: > > > > > It can be useful for the maintenance of things like lookup tables, > > > particularly during development. > > > > > Dave > > >

[Rails-core] Re: Clean Logger Patch

2007-02-23 Thread Rob Sanheim
Hi Can we have this applied? For production logging it would be great if you could cleanly apply formatting or override as desired...plus the way Logger is overridden is just not friendly. - Rob On 2/18/07, Anthony Eden <[EMAIL PROTECTED]> wrote: > > Just want to poke a little and remind core

[Rails-core] Re: Eliminating warnings from rails

2007-02-22 Thread Rob Sanheim
On 2/22/07, Michael Koziarski <[EMAIL PROTECTED]> wrote: > > Sure, any patches which apply cleanly and don't have any side effects > will be greatfully received. > > the best way to ensure they'll apply cleanly is not to provide one > massive patch for the entirety of rails. > Does anyone know of

[Rails-core] Re: wiki spam

2007-02-10 Thread Rob Sanheim
Great, thanks for letting me know. Sorry I couldn't help out on it, been way too crazy with my job lately. - Rob On 2/10/07, Justin Forder <[EMAIL PROTECTED]> wrote: > > Justin Forder wrote: > > Rob Sanheim wrote: > > >> So, just to clarify - if I edit rev

[Rails-core] Re: Suggestion on Closing Tickets

2007-01-24 Thread Rob Sanheim
On 1/24/07, Tom Ward <[EMAIL PROTECTED]> wrote: > > On 24/01/07, Anthony Eden <[EMAIL PROTECTED]> wrote: > > > > I know that the issue of closing tickets was brought up a couple of > > days ago and I'm hoping that others might be amniable to a suggestion > > regarding how tickets should be closed.

[Rails-core] Re: more love for resource_feeder, feedback appreciated

2007-01-24 Thread Rob Sanheim
t;[EMAIL PROTECTED]> wrote: > > 20 > > I just put in a patch for this. I should have searched first. Doh! > > But this has broken most of our projects here at Unspace. B! > > Please help! > > -hampton. > > On 12/13/06, Rob Sanheim <[EMAIL PROTECTED]> wr

[Rails-core] ActionPack tests fail in edge with latest Mocha

2007-01-24 Thread Rob Sanheim
Hi ActionPack tests fail on edge if you are running the latest Mocha (0.4). This is only when running the full suite via rake, not when running the specific test class (base_test.rb) in isolation. I have no idea why the discrepancy. Here's a patch to fix it - its very minor and just due to an

[Rails-core] Re: can't login to trac

2007-01-24 Thread Rob Sanheim
On 1/24/07, Jarkko Laine <[EMAIL PROTECTED]> wrote: > > On 24.1.2007, at 9.53, Rob Sanheim wrote: > > > > > Anyone else not able to login to trac? It just sits at > > "loading..." forever... > > It's rebuilding the hackfest stats around this

[Rails-core] can't login to trac

2007-01-23 Thread Rob Sanheim
Anyone else not able to login to trac? It just sits at "loading..." forever... - Rob --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-cor

[Rails-core] patch - really deprecat assert_tag

2007-01-18 Thread Rob Sanheim
I know its really close to 1.2, but this is a really small patch that really deprecates assert_tag and assert_no_tag. There are articles and docs that talk about this, but it was never implemented, so the current code could be confusing or misleading. Here's a patch that deprecates it, refers u

[Rails-core] Re: Schema dumper and migrations

2007-01-17 Thread Rob Sanheim
+1. We've hit this issue before... On 1/17/07, Benjamin Curtis <[EMAIL PROTECTED]> wrote: I don't know if this patch (http://dev.rubyonrails.org/ticket/7085) is worthy of inclusion in 1.2, but I thought I'd highlight here just in case it is. Basically, it fixes the schema dumper and create_ta

[Rails-core] Re: tiny doc patch

2007-01-12 Thread Rob Sanheim
bump... could anyone from core commit this before 1.2? Its minor but annoying when the example in the docs are broken On 1/9/07, Rob Sanheim <[EMAIL PROTECTED]> wrote: > Its real small, but fixes an annoying error that has tripped me up before: > > http://dev.rubyonrails.

[Rails-core] tiny doc patch

2007-01-09 Thread Rob Sanheim
Its real small, but fixes an annoying error that has tripped me up before: http://dev.rubyonrails.org/ticket/6962 - Rob --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this

[Rails-core] Re: wiki spam

2007-01-09 Thread Rob Sanheim
On 1/9/07, Justin Forder <[EMAIL PROTECTED]> wrote: > > Courtenay wrote: > > > >> > It turns out that the current i2 install was from Dan Peterson's own > >> SVN > >> > repository, back in July. We don't have commit access to that > >> > repository, and Dan hasn't answered any of my mail since 8th

[Rails-core] Re: wiki spam

2007-01-08 Thread Rob Sanheim
On 1/8/07, Justin Forder <[EMAIL PROTECTED]> wrote: Rob Sanheim wrote: > > On 1/8/07, Justin Forder <[EMAIL PROTECTED]> wrote: >> >> Michael Koziarski wrote: >> > >> >> Actually I thought they were porting the data to a different, more >&

[Rails-core] Re: wiki spam

2007-01-08 Thread Rob Sanheim
On 1/8/07, Justin Forder <[EMAIL PROTECTED]> wrote: Michael Koziarski wrote: > >> Actually I thought they were porting the data to a different, more >> robust app... > > I'm not sure what happened with the previous effort, but if someone > else would like to have a go at it, we can definitely p

[Rails-core] Re: wiki spam

2007-01-07 Thread Rob Sanheim
On 1/7/07, Courtenay <[EMAIL PROTECTED]> wrote: On 1/7/07, Rob Sanheim <[EMAIL PROTECTED]> wrote: > On 1/7/07, Andrew Kaspick <[EMAIL PROTECTED]> wrote: > > > > Hi, > > > > Does anybody have any solutions for some of the spam that's fill

[Rails-core] Re: wiki spam

2007-01-07 Thread Rob Sanheim
On 1/7/07, Andrew Kaspick <[EMAIL PROTECTED]> wrote: Hi, Does anybody have any solutions for some of the spam that's filling up the rails wiki? For example the development firms page is being hit with new spam constantly; just see how many revisions you have to go back before finding the actu

[Rails-core] Re: Multiple View Load Paths

2007-01-05 Thread Rob Sanheim
On 1/5/07, John W. Long <[EMAIL PROTECTED]> wrote: Rick Olson wrote: > Personally, I'm just not in favor of this. I definitely see the > usefulness in something like Radiant, Mephisto, anything using > Engines, etc. But, it seems like a waste of time for every other app. When you say a "wast

[Rails-core] Re: Multiple View Load Paths

2007-01-03 Thread Rob Sanheim
On 1/3/07, John Long <[EMAIL PROTECTED]> wrote: Following up on: http://wiseheartdesign.com/2006/12/6/rails-needs-something-better-than-engines/ I've created a patch that deprecates ActionController::Base.template_root in favor of ActionController::Base.view_paths (which will allow you to spe

[Rails-core] wiki down?

2007-01-02 Thread Rob Sanheim
getting a 503... - Rob --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email t

[Rails-core] Re: more love for resource_feeder, feedback appreciated

2006-12-13 Thread Rob Sanheim
On 12/11/06, Rob Sanheim <[EMAIL PROTECTED]> wrote: > Hi all > > I've provided another patch for resource_feeder, making the rss 2.0 > generation a bit more robust and flexible. It now includes some > pubDate for the feed and not just the items, for example, which is

[Rails-core] more love for resource_feeder, feedback appreciated

2006-12-11 Thread Rob Sanheim
Hi all I've provided another patch for resource_feeder, making the rss 2.0 generation a bit more robust and flexible. It now includes some pubDate for the feed and not just the items, for example, which is probably something that should be there by default. I've also added some docs for the rss

[Rails-core] Re: Object Oriented Model Helpers

2006-12-08 Thread Rob Sanheim
On 12/8/06, Courtenay <[EMAIL PROTECTED]> wrote: > FWIW, I didn't say to put extra methods in the model. Hell no. > > I was suggesting a layer between the model (or models) and the view > which packages up certain methods, much like Liquid's Drops. Thats essentially what the presenter pattern i

[Rails-core] Re: resource_feeder patches?

2006-12-06 Thread Rob Sanheim
On 12/5/06, Jeremy Kemper <[EMAIL PROTECTED]> wrote: > All of the above ;-) > > I added a Plugins component to Rails' trac. Please submit a patch. > Done: http://dev.rubyonrails.org/ticket/6770 thanks - rob --~--~-~--~~~---~--~~ You received this message because

[Rails-core] resource_feeder patches?

2006-12-05 Thread Rob Sanheim
Hi all I've been working with resource_feeder lately, and have been tweaking it a bit to include some things like support for content:encoded for rss 2.0. This was something that seemed like a "good thing", per the thread between Sam Ruby and others (here: http://www.mail-archive.com/rubyonrails

[Rails-core] is assert_tag really deprecated?

2006-11-30 Thread Rob Sanheim
I saw the postings and the changeset here (http://dev.rubyonrails.org/changeset/4929) saying assert_tag is deprecated in favor of the new hotness assert_select, but it was never actually added to deprecated_assertions.rb. And I can use it just fine in a test without any warnings. Was that just a

[Rails-core] Re: Rails support progress for JRuby

2006-11-28 Thread Rob Sanheim
On 11/28/06, Charles Oliver Nutter <[EMAIL PROTECTED]> wrote: [snip] > Note that the use of SQLite in many places in the test causes quite a > bit of trouble for JRuby since SQLite support on Java is minimal at > best. The ability to swap out SQLite for something equivalently simple > (DBI or JDBC

[Rails-core] should this be patched? render_to_string and MissingTemplate

2006-11-16 Thread Rob Sanheim
Ran across this today using render_to_string along with a normal render: def some_action begin @cache = render_to_string(:file => self.find_some_file) rescue ActionController::MissingTemplate => e logger.debug("file not found, eating exception and continuing...") end @posts = Po

[Rails-core] Rails manual is down

2006-11-06 Thread Rob Sanheim
http://manuals.rubyonrails.com/ returns a 503 - is this regular maintenance or did something crash and burn? - rob --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group,

[Rails-core] Re: any love for daylight savings time?

2006-11-01 Thread Rob Sanheim
On 11/1/06, Deirdre Saoirse Moen <[EMAIL PROTECTED]> wrote: > > On 11/1/06, Rob Sanheim <[EMAIL PROTECTED]> wrote: > > > > Now that we've just gone thru DST, any love for this ticket (with > > patch and tests) for the Time extensions and handling DST? &

[Rails-core] any love for daylight savings time?

2006-11-01 Thread Rob Sanheim
Now that we've just gone thru DST, any love for this ticket (with patch and tests) for the Time extensions and handling DST? http://dev.rubyonrails.org/ticket/5617 If I understand the comments in the ticket correctly, the previous fix applied to "next_week" is incomplete, and a couple other Acti

[Rails-core] Trac is full again?

2006-10-17 Thread Rob Sanheim
Tried to login, failed, then I tried to get my password emailed to me and got the all too familiar message: == Traceback (most recent call last): File "/opt/csw/lib/python2.3/site-packages/trac/web/main.py", line 335, in dispatch_request dispatcher.dispatch(req) File "/opt/csw

[Rails-core] Re: Include ARTS in Core

2006-10-12 Thread Rob Sanheim
Agreed - as long as RJS is part of core, there should be a easy way to test it w/i core. - rob -- http://www.robsanheim.com http://www.seekingalpha.com http://www.ajaxian.com --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google

[Rails-core] Re: Worrisome trac spam

2006-09-07 Thread Rob Sanheim
> > We do have filters in place which blocks a bunch of spam. The reality > is, everything you do to block spam increases the number of false > positives. We're going to have to require logins, there's no way > around it. How will the login system work - just let anyone sign up via trac? I don

[Rails-core] Re: :throw option for AR finders that don't throw RecordNotFound exceptions

2006-08-30 Thread Rob Sanheim
On 8/30/06, Damian Janowski <[EMAIL PROTECTED]> wrote: > > IMHO bang wouldn't follow Ruby's convention (ie that "!" makes something > destructive to the object). > > Something along "find_or_raise" would follow Rails' "find_or_create" > convention. > > But +1 to load vs find. Sounds cool. Actuall

[Rails-core] Re: Pluralize Bug

2006-08-24 Thread Rob Sanheim
On 8/24/06, Kevin Clark <[EMAIL PROTECTED]> wrote: > > The docs are wrong. pluralize has always returned a singular when > given a plural. > Are you talking about pluralize in text helper, or the extension to String? Because thats not the case when using it with a regular ole' string: This is w

[Rails-core] Re: Pluralize Bug

2006-08-23 Thread Rob Sanheim
On 8/24/06, Jakob Skjerning <[EMAIL PROTECTED]> wrote: > > > On Aug 23, 2006, at 23:32, Mark Van Holstyn wrote: > > > >> "territories".pluralize > > => "territory" > > >> "queries".pluralize > > => "query" > > I'm curious. What would you expect them to be pluralized as? > "territorieses" and "quer

[Rails-core] Re: [Rails] Re: Trac Triage with THE MAGGOT (Time To Clean Your Patches)

2006-08-21 Thread Rob Sanheim
On 8/20/06, Justin Forder <[EMAIL PROTECTED]> wrote: > > Zed Shaw wrote: > > > * If your patch still applies, but maybe isn't tested with the latest > > 1.1.6 then retest, regenerate, and resubmit. > > * Finally, 1.1.6 isn't listed as a version yet, so if your patch applies > > to 1.1.6 then just