Re: [Rails-core] Re: [ActiveSupport] feature proposal: Create #unfreeze_time to complement #freeze_time in ActiveSupport::Testing::TimeHelpers

2018-09-07 Thread 'Ryan' via Ruby on Rails: Core
. > > On Tuesday, 4 September 2018 15:12:54 UTC+1, Xavier Noria wrote: >> >> On Mon, Sep 3, 2018 at 11:16 PM, 'Ryan' via Ruby on Rails: Core < >> rubyonra...@googlegroups.com> wrote: >> >> Yes I'd love to contribute a patch for this. >>&

Re: [Rails-core] Re: [ActiveSupport] feature proposal: Create #unfreeze_time to complement #freeze_time in ActiveSupport::Testing::TimeHelpers

2018-09-04 Thread &#x27;Ryan&#x27; via Ruby on Rails: Core
Right, I see the process is to fork rails and and make a PR with the patch. Thanks for the tips, and for the offer of further support. On Tuesday, 4 September 2018 15:12:54 UTC+1, Xavier Noria wrote: > > On Mon, Sep 3, 2018 at 11:16 PM, 'Ryan' via Ruby on Rails: C

Re: [Rails-core] Re: [ActiveSupport] feature proposal: Create #unfreeze_time to complement #freeze_time in ActiveSupport::Testing::TimeHelpers

2018-09-03 Thread &#x27;Ryan&#x27; via Ruby on Rails: Core
Yes I'd love to contribute a patch for this. I posted it as an issue in the rails repo and they directed me here. https://github.com/rails/rails/issues/33771#issuecomment-417848091 Could you advise on your normal process for this? I've contributed a rails before, but that was for an issue someo

[Rails-core] Re: [ActiveSupport] feature proposal: Create #unfreeze_time to complement #freeze_time in ActiveSupport::Testing::TimeHelpers

2018-09-02 Thread &#x27;Ryan&#x27; via Ruby on Rails: Core
It could be set as an alias for #travel_back. >From a semantic perspective #unfreeze_time would read like an opposite to #freeze_time, just like #travel_back is an opposite of #travel_to It's a relatively small change that could improve the user experience of using #freeze_time -- You receive

[Rails-core] [ActiveSupport] feature proposal: Create #unfreeze_time to complement #freeze_time in ActiveSupport::Testing::TimeHelpers

2018-09-01 Thread &#x27;Ryan&#x27; via Ruby on Rails: Core
ActiveSupport::Testing::TimeHelpers has a method called #freeze_time. It could help users if there was a complementary method called #unfreeze_time This could mean that a developer could write a test that would stub time at Time.now using #freeze_time, then could call #unfreeze_time when they w