Re: [Rails-core] how adding a "version" when generating a new rails project

2014-03-03 Thread Leif Eriksen
We do this - we run two week iterations, and group fixes and features under a version number that tracks the iteration. Every commit is linked to an issue, and every issue is linked to a release version. The last thing we do in an iteration is a commit to bump the version number to match the ite

Re: [Rails-core] SimpleDelegator autoloading issue

2014-03-03 Thread Xavier Noria
On Mon, Mar 3, 2014 at 7:03 PM, Henrik Nyh wrote: On Mon, Mar 3, 2014 at 12:57 PM, Xavier Noria wrote: > >> Just a remark about this comment: >> >> "Load stdlib classes even though SimpleDelegator inherits from >> BasicObject." >> >> The purpose of that const_get is to load top-level consta

[Rails-core] Request for review - #14154

2014-03-03 Thread Matt Jones
I know it's late in the 4.1.0 release cycle, but I was hoping somebody could review this for that release: https://github.com/rails/rails/pull/14154 It fixes an issue where default_scopes in ON clauses don't pick up the table's aliased name. Without the patch, the resulting queries are generall

Re: [Rails-core] SimpleDelegator autoloading issue

2014-03-03 Thread Henrik Nyh
On Mon, Mar 3, 2014 at 12:57 PM, Xavier Noria wrote: > Just a remark about this comment: > > "Load stdlib classes even though SimpleDelegator inherits from > BasicObject." > > The purpose of that const_get is to load top-level constants (which > belong to Object), regardless of whether they

Re: [Rails-core] how adding a "version" when generating a new rails project

2014-03-03 Thread Carlos Antonio da Silva
Indeed I don't think there's need to track "versions" on a web application, since it's way more common for people to use tags or similar with git or some other scm, when they do. In any case, it's fairly easy to add that to your application if you want or need it: *module Todo* * class Applicati

Re: [Rails-core] how adding a "version" when generating a new rails project

2014-03-03 Thread Geoff Harcourt
Hi Rain, I don’t think that web applications are like software libraries in this respect. Engineering teams that are pushing software out the door are already tracking their versions with commits to their source control. SemVer is great because it helps convey things like breaking changes, bu

[Rails-core] how adding a "version" when generating a new rails project

2014-03-03 Thread Rain Chen
every lib/gem will have a version, but seems everyone forgot the project itself. I preferred a config.version option in the applicaiton.rb after running rails new module Todo class Application < Rails::Application ... config.version = '1.0.0' endend then in rails console, we can

Re: [Rails-core] SimpleDelegator autoloading issue

2014-03-03 Thread Xavier Noria
Just a remark about this comment: "Load stdlib classes even though SimpleDelegator inherits from BasicObject." The purpose of that const_get is to load top-level constants (which belong to Object), regardless of whether they come from stdlib. Classes that descend straight from BasicObject do

Re: [Rails-core] SimpleDelegator autoloading issue

2014-03-03 Thread Henrik N
On Monday, March 3, 2014 12:04:14 AM UTC+1, Henrik N wrote: > > On Sun, Mar 2, 2014 at 10:20 PM, Henrik Nyh wrote: > >> On Sun, Mar 2, 2014 at 8:11 PM, Xavier Noria wrote: >> >>> I believe the culprit here is Delegator. >>> Delegator owns const_missing, it is all or nothing (reproduced from >>>