[Rails-core] Re: Executing Multiple SQL Statements for MySQL Adapter

2009-02-18 Thread Jonathan Weiss
Cheers, John Trupiano wrote: > Hey guys, > > Is this the recommended procedure for executing multiple SQL > statements in a single call? http://www.seanr.ca/tech/?p=75 > > In other words, do we have a config option to trun on > CLIENT_MULTI_STATEMENTS for MySQL? I'm very happy that this is

[Rails-core] Re: Executing Multiple SQL Statements for MySQL Adapter

2009-02-18 Thread John Trupiano
Hrmmthis is not for max packet size, this is to allow the MySQL Adapter to execute multiple statements in a single call to execute(), e.g. CREATE TEMPORARY TABLE temp_pets ( `id` int(11) NOT NULL auto_increment, `child_id` int(11) NOT NULL default '0', `pets_name` int(11) NOT NULL defau

[Rails-core] Modifying AR::B#connection to accept a block and release connection

2009-02-18 Thread coderrr
Anyone have issues with the change we are proposing in this ticket? http://rails.lighthouseapp.com/projects/8994/tickets/1752-added-using_connection-method-like-with_connection-but-sets-it-as-default-connection-while-inside-the-block Basically we want to change AR::B#connection to accept a block.

[Rails-core] Re: Executing Multiple SQL Statements for MySQL Adapter

2009-02-18 Thread Michael Koziarski
I believe that you can override this with a client setting in my.cnf or the user-specific mysql settings. By not providing a value in rails we just fall back to the user / system wide settings. Max packet size isn't really something I think we need in the database.yml. On Thu, Feb 19, 2009 at 4:

[Rails-core] Code in polymorphic belongs_to obsolete?

2009-02-18 Thread Eloy Duran
Hi, I'm refactoring some code related to autosaving associations. While doing this, I came across some code which doesn't seem to do anything, or rather, no tests fail when this code is disabled. http://github.com/rails/rails/blob/b6e56efe07cb3c2e999216f995403aa9206226a2/activerecord/lib/active

[Rails-core] Executing Multiple SQL Statements for MySQL Adapter

2009-02-18 Thread John Trupiano
Hey guys, Is this the recommended procedure for executing multiple SQL statements in a single call? http://www.seanr.ca/tech/?p=75 In other words, do we have a config option to trun on CLIENT_MULTI_STATEMENTS for MySQL? Or are we still being advised to go directly into the rails source to achi

[Rails-core] Patch for HttpMock to allow options that reduce strictness of request matching

2009-02-18 Thread Michael Kintzer
Hi, I submitted a patch to lighthouse which allows users of ActiveResource::HttpMock to relax the strictness of the request matching algorithm in cases when exact matching of path or request headers is not required for the purposes of the test. See the patch at: http://rails.lighthouseapp.com/

[Rails-core] Testing to prevent regression

2009-02-18 Thread Manfred Stienstra
Hi guys, I've been seeing lots of commits lately without tests, for instance: http://github.com/rails/rails/commit/b6e56efe07cb3c2e999216f995403aa9206226a2 http://github.com/rails/rails/commit/238a6bb62dc153743a0abc6eb1e35392ac799d65 http://github.com/rails/rails/commit/1dab1d380377f1a2