Re: ports/65043: [patch] net/rsync: problems in client name lookup code

2004-04-01 Thread Alex Vasylenko
Wayne Davison wrote: Cool. I thought the length should be OK after that call, but I was trying to figure out how this part of your bug report figured into your patch: - fails to set ss_len member of struct sockaddr_storage, which when passed to getnameinfo causes the latter to f

Re: ports/65043: [patch] net/rsync: problems in client name lookup code

2004-04-01 Thread Wayne Davison
On Thu, Apr 01, 2004 at 06:38:04PM -0500, Alex Vasylenko wrote: > I think your second patch is superfluous, as getpeername returns a > correctly formatted sockaddr (with _len set, if it's there), so it > should be sufficient to simply drop the "ss.ss_len = ss_len;" line from > my original patch

Re: ports/65043: [patch] net/rsync: problems in client name lookup code

2004-04-01 Thread Alex Vasylenko
Wayne, I'm changing the subject and keeping your text in an attempt to get this recorded in gnats. Wayne Davison wrote: On Thu, Apr 01, 2004 at 11:31:00AM -0500, Alex Vasylenko wrote: - detection of IPv6 via counting dots is plain silly and doesn't work; Thanks, I've tweaked your patch for t