I don't recommend it for 2.5.5 because we desperately need a stable release
and this is a risky change. Tridge, do you have any recollection about
what problem you were trying to solve?
I expect the real fix will be significantly more complicated.
- Dave
On Wed, Mar 20, 2002 at 01:19:38PM -050
The modification Dave suggested continues to work. Can it be
added to the release code? (Dave cautioned that he didn't know
why the code had been made active.)
Todd
static RETSIGTYPE sigchld_handler(int val) {
//#ifdef WNOHANG
//while (waitpid(-1, NULL, WNOHANG) > 0) ;
//#endif
}
On
(rsync version 2.5.2 protocol version 26)
Thank you, I commented out the code and now it reports status 23
when I try to copy a remote file to a local read-only directory.
I hope it is more like losing an appendix than a kidney.
Todd
static RETSIGTYPE sigchld_handler(int val) {
//#ifdef WNOHA
I investigated this and found it came down to the revision 1.129 in the
rsync CVS at
http://cvs.samba.org/cgi-bin/cvsweb/rsync/main.c
Here's a patch to undo it:
--- main.c.OFri Feb 22 18:24:38 2002
+++ main.c Thu Feb 28 13:03:29 2002
@@ -797,7 +797,7 @@
}
static RETSIGTYPE sigch
Rsync reports the status code of the remote command. So in some
situations the status code is successful when the command fails.
Rsync of a remote file to a local read-only directory fails, but
exits with $status = 0. I'd like to get $status = 23. Is it
possible?
Local copy fails with status
