Re: creation date and OSX [performance]

2008-02-04 Thread Wayne Davison
On Mon, Feb 04, 2008 at 03:55:42PM +1100, Anthony Morton wrote: > Incidentally, it seems the latest flags.diff still has some inconsistencies > between '--flags' and '--fileflags': there are some five instances of the > former that need to be replaced with the latter (or should it be the other >

Re: creation date and OSX [performance]

2008-02-03 Thread Anthony Morton
My latest version of the crtimes.diff patch is now based on having the flags.diff patch applied first, so they'll work together now. You'll need to have the latest dev version of the source and the patches, though (see the downloads page for the various ways to access the source). Incide

Fwd: creation date and OSX [performance]

2008-02-03 Thread Robert DuToit
Thanks Wayne! This is looking good. My initial tests with a lot of files seem to show incremental-no-change copies are as fast as the old one (without the osx-create-times patch). So we havn't lost much performance with crtimes added. More tests though. I'm happy. Rob On Feb 3, 2008

Re: creation date and OSX [performance]

2008-02-03 Thread Wayne Davison
On Sat, Feb 02, 2008 at 09:38:20PM -0500, Robert DuToit wrote: > I tried the crtimes patch and it compiles and works but when I tried > to add the flags patch too I came up with this make error. My latest version of the crtimes.diff patch is now based on having the flags.diff patch applied first,

Re: creation date and OSX [performance]

2008-02-03 Thread Robert DuToit
On Feb 3, 2008, at 3:56 PM, Robert DuToit wrote: Hi Mike, If I replace the missing patch code for flags.diff in compat.c for instance: nt uid_ndx, gid_ndx, crtimes_ndx, acls_ndx, xattrs_ndx, unsort_ndx; adding ... fileflags_ndx so then nt uid_ndx, gid_ndx, fileflags_ndx , crtimes_ndx,

Re: creation date and OSX [performance]

2008-02-03 Thread Mike Bombich
On Feb 3, 2008, at 2:56 PM, Robert DuToit wrote: Hi Mike, If I replace the missing patch code for flags.diff in compat.c for instance: nt uid_ndx, gid_ndx, crtimes_ndx, acls_ndx, xattrs_ndx, unsort_ndx; adding ... fileflags_ndx so then nt uid_ndx, gid_ndx, fileflags_ndx , crtimes_ndx,

Re: creation date and OSX [performance]

2008-02-03 Thread Robert DuToit
Hi Mike, If I replace the missing patch code for flags.diff in compat.c for instance: nt uid_ndx, gid_ndx, crtimes_ndx, acls_ndx, xattrs_ndx, unsort_ndx; adding ... fileflags_ndx so then nt uid_ndx, gid_ndx, fileflags_ndx , crtimes_ndx, acls_ndx, xattrs_ndx, unsort_ndx; And I do thi

Re: creation date and OSX [performance]

2008-02-03 Thread Mike Bombich
I think the issue is that the flags patch and the crtimes patch are often trying to patch the same lines. For example, line 65-ish in compat.c: flags.diff: /* These index values are for the file-list's extra-attribute array. */ - int uid_ndx, gid_ndx, acls_ndx, xattrs_ndx, unsort_ndx; +

Re: creation date and OSX [performance]

2008-02-03 Thread Robert DuToit
Wayne, So sorry for all the questions - this isn't my language area (applescript + some oBJ-C..) Here is part of the the rej. file after the flags patch lines 44- 49, 50: *** *** 44,49 extern int protect_args; extern int preserve_uid; extern int preserve_gid; exter

Re: creation date and OSX [performance]

2008-02-02 Thread Wayne Davison
On Sat, Feb 02, 2008 at 09:38:20PM -0500, Robert DuToit wrote: > I tried the crtimes patch and it compiles and works but when I tried > to add the flags patch too I came up with this make error. You apparently missed the patch errors before that. You need to resolve all the failed hunks from the

Re: creation date and OSX [performance]

2008-02-02 Thread Robert DuToit
Hi Wayne, I tried the crtimes patch and it compiles and works but when I tried to add the flags patch too I came up with this make error. Though flags compiloes by itself or with the osx-create-time.diff patch. Rob robert-dutoits-powerbook-g4-15:rsync-3.0.0pre8 astrid$ make perl ./mkproto.p

Re: creation date and OSX [performance]

2008-02-02 Thread Wayne Davison
On Sat, Feb 02, 2008 at 12:18:07AM -0600, Mike Bombich wrote: > The performance hit is significant, and I'm wondering how safe it is to > simply assume that every file has a creation date? I've been thinking about rewriting that patch so that the creation time is sent as a time attribute, like th

Re: creation date and OSX [performance]

2008-02-02 Thread Giuliano Gavazzi
On 2 Feb 2008, at 09:24, Vitorio Machado wrote: 3) Also from getattrlist manpage: Not all volumes support all attributes. See the discussion of ATTR_VOL_ATTRIBUTES for a discussion of how to determine whether a par- ticular volume supports a particular attribute. I don't rea

Re: creation date and OSX [performance]

2008-02-02 Thread Vitorio Machado
Hi, I think it's OK to run getattrlist once assuming that there are creation date. My arguments: 1) First of all, most of Macs run only on HFS+, some exceptions will be those running under UFS (only saw one person talk about this for a server, but I think it's very rare) or that have volu

Re: creation date and OSX [performance]

2008-02-01 Thread Mike Bombich
Looking at this patch from a performance perspective, it appears that getattrlist is called twice for every file: 23:57:24.341 lstat 00-basic- permissions/owned-by- root

creation date and OSX

2007-12-01 Thread Robert DuToit
Hi, I've been using rsync (OSX Tiger now Leopard) to backup my home folder daily using -a -H -A -X link-dest=dir to make incremental backups. There was a problem though since many files especially images, movies etc would be recopied each time instead of creating hard links. I have been