Re: use-after-free in open_socket_out

2011-07-13 Thread Carlos Carvalho
*sigh* forgot to keep the error... Here's the correct patch, tested this time. Sorry for the noise. patch-2 Description: Binary data -- Please use reply-all for most replies to avoid omitting the mailing list. To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync Befo

Re: use-after-free in open_socket_out

2011-07-13 Thread Carlos Carvalho
Wayne Davison (way...@samba.org) wrote on 12 July 2011 16:51: >On Tue, Jul 12, 2011 at 3:12 PM, Carlos Carvalho >wrote: > >The new feature is indeed very useful but something else is needed: print >the IP of the server even when the connection is successful, and also > print >

Re: use-after-free in open_socket_out

2011-07-12 Thread Wayne Davison
On Tue, Jul 12, 2011 at 3:12 PM, Carlos Carvalho wrote: > The new feature is indeed very useful but something else is needed: print > the IP of the server even when the connection is successful, and also print > any IPs that were tried but didn't work. Looks nice to me. I tweaked it a bit and c

Re: use-after-free in open_socket_out

2011-07-12 Thread Carlos Carvalho
This is to ask for a slight enhancement in the new multi-protocol IP printing. I'm keeping the bug thread because in our machines it revealed another problem with the code that's already there. The new feature is indeed very useful but something else is needed: print the IP of the server even when

Re: use-after-free in open_socket_out

2011-07-11 Thread Wayne Davison
> > res0 is freed but keeps its value so there's access to freed memory > in res->ai* in the call of inet_ntop if s < 0. > Thanks. I've commited the fix. ..wayne.. -- Please use reply-all for most replies to avoid omitting the mailing list. To unsubscribe or change options: https://lists.samba.