Re: rsync-2.5.1pre1 with -F option

2001-12-10 Thread Jos Backus
Sorry for the spam. Here's an even better version of the patch. It - uses strlcat instead of strncat - replaces one use of sprintf with snprintf - removes the -F/-f options, uses only the long options - updates the documentation Any objections to this going in? Index: batch.c ==

Re: rsync-2.5.1pre1 with -F option

2001-12-06 Thread Jos Backus
Here's a better patch; rsync should now no longer dump core if called with insufficient arguments. write_batch_argvs_file() is still ugly though, not sure how to clean this up. Index: batch.c === RCS file: /cvsroot/rsync/batch.c,v re

Re: rsync-2.5.1pre1 with -F option

2001-12-05 Thread Jos Backus
> Program received signal SIGSEGV, Segmentation fault. > write_batch_argvs_file (orig_argc=-2, argc=0, argv=0x0) at batch.c:153 > 153if ( !strcmp(argv[i],"-F") ){ /* safer to change it here > than script*/ I'm not proud of this fix, but at least it makes -F/--write-batch work proper

Re: rsync-2.5.1pre1 with -F option

2001-12-03 Thread tim . conway
I always get that too. I just figured i'd screwed something up. solaris 7 Tim Conway [EMAIL PROTECTED] 303.682.4917 Philips Semiconductor - Longmont TC 1880 Industrial Circle, Suite D Longmont, CO 80501 Available via SameTime Connect within Philips, n9hmg on AIM perl -e 'print pack(,