Re: [PATCH] Reduce memory usage

2021-12-24 Thread Johannes Altmanninger via rsync
On Thu, Dec 23, 2021 at 07:55:00PM +0100, Roland via rsync wrote: > hello, > > it's fantastic to see that such optimizations still being found. > > out of curiosity - what is the status of this?  will it get merged ? Yes, it was merged after being resubmitted nn github, see commit ae1f0029 (Redu

Re: [PATCH] Reduce memory usage

2021-12-23 Thread Roland via rsync
hello, it's fantastic to see that such optimizations still being found. out of curiosity - what is the status of this?  will it get merged ? roland Am 28.09.21 um 12:05 schrieb Jindřich Makovička via rsync: In 2004, an allocation optimization has been added to the file list handling code, tha

Re: [PATCH] Reduce memory usage

2021-10-03 Thread Rupert Gallagher via rsync
Original Message On Oct 2, 2021, 15:04, Jindřich Makovička < makov...@gmail.com> wrote: Just note this patch has nothing to do with memory consumption vs performance. It just avoids allocating memory that was left unused anyway. I can read-- Please use reply-all for most replie

Re: Aw: Re: [PATCH] Reduce memory usage

2021-10-03 Thread Rupert Gallagher via rsync
Original Message On Oct 2, 2021, 12:36, < devz...@web.de> wrote: >>In the exchange I argued that proper use of ram as a buffer would have cut >>down backup time to minutes instead of days. >could you give an example where rsync is slowing things down so much due to >ram constra

Re: Re: [PATCH] Reduce memory usage

2021-10-02 Thread Jindřich Makovička via rsync
> why should rsync use ram for buffering data it copies, if the linux kernel > / vm subsystem already does this? > > roland > > *Gesendet:* Samstag, 02. Oktober 2021 um 12:07 Uhr > *Von:* "Rupert Gallagher via rsync" > *An:* makov...@gmail.com, rsync@lists.samba.org

Aw: Re: [PATCH] Reduce memory usage

2021-10-02 Thread devzero--- via rsync
il.com, rsync@lists.samba.org Betreff: Re: [PATCH] Reduce memory usage If you look at my previous exchange in the list, I raised the need for more ram usage via a tool option. In the exchange I argued that proper use of ram as a buffer would have cut down backup time to minutes instead of days. At the time, my

Re: [PATCH] Reduce memory usage

2021-10-02 Thread Rupert Gallagher via rsync
If you look at my previous exchange in the list, I raised the need for more ram usage via a tool option. In the exchange I argued that proper use of ram as a buffer would have cut down backup time to minutes instead of days. At the time, my proposal was dismissed by someone saying that rsync use

Re: [PATCH] Reduce memory usage

2021-09-28 Thread Johannes Altmanninger via rsync
Looks awesome, really nice catch! -- Please use reply-all for most replies to avoid omitting the mailing list. To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html

Re: [PATCH] Reduce memory usage

2021-09-28 Thread Jindřich Makovička via rsync
On Mon, 27 Sep 2021 22:03:01 +0200 Johannes Altmanninger wrote: > > On Sun, Sep 26, 2021 at 01:54:13PM +0200, Jindřich Makovička via > > rsync wrote: > > > > Applying the attached patch, which reduces the default allocation > > to 32 pointers, and preallocates 32K pointers only for the main > >

Re: [PATCH] Reduce memory usage

2021-09-27 Thread Johannes Altmanninger via rsync
> On Sun, Sep 26, 2021 at 01:54:13PM +0200, Jindřich Makovička via rsync wrote: > > Applying the attached patch, which reduces the default allocation to 32 > pointers, and preallocates 32K pointers only for the main file lists in > send_file_list and recv_file_list, reduces the peak memory usage i

Re: [PATCH] Reduce memory usage

2021-09-27 Thread Jindřich Makovička via rsync
On Mon, 27 Sep 2021 13:38:22 +0200 Jindřich Makovička wrote: > On Sun, 26 Sep 2021 13:54:13 +0200 > Jindřich Makovička wrote: > > Hi, > > > > ... > > > > Applying the attached patch, which reduces the default allocation to > > 32 pointers, and preallocates 32K pointers only for the main file >

Re: [PATCH] Reduce memory usage

2021-09-27 Thread Jindřich Makovička via rsync
On Sun, 26 Sep 2021 13:54:13 +0200 Jindřich Makovička wrote: > Hi, > > ... > > Applying the attached patch, which reduces the default allocation to > 32 pointers, and preallocates 32K pointers only for the main file > lists in send_file_list and recv_file_list, reduces the peak memory > usage in