Re: Extended attributes in MacOS X

2006-10-26 Thread Wayne Davison
On Thu, Oct 26, 2006 at 01:03:38PM +0200, Wesley W. Terpstra wrote: > I've built CVS, but had to make this change: flist.c:983: Thanks -- I had neglected to build xattr support w/o acls. > Also, these warnings remain: I'll check into those. > The problem I anticipate is that MacOSX has a lot mo

Re: Extended attributes in MacOS X

2006-10-26 Thread Wayne Davison
On Thu, Oct 26, 2006 at 05:58:45AM -0400, Victor Shoup wrote: > I'm wondering, though: does the xattr code avoid copying, or even > comparing hashes of, the xattr data itself? Especially on OSX there > can be a lot of this stuff, and it would be nice if changes in the > xattr's were detected qui

Re: Extended attributes in MacOS X

2006-10-26 Thread Wesley W. Terpstra
On Oct 26, 2006, at 4:01 AM, Wayne Davison wrote: Great! I've taken your code, tweaked it a little, and then did some bug-fixing of the xattr code in general (I found some buffer problems quickly using valgrind). The end result is now in CVS and in the most recent "nightly" tar file (see the do

Re: Extended attributes in MacOS X

2006-10-26 Thread Victor Shoup
I'm glad to see rsync may finally be getting proper support for extended attributes on OSX (since apple's own implementation of this is notoriously buggy). I'm wondering, though: does the xattr code avoid copying, or even comparing hashes of, the xattr data itself? Especially on OSX there ca

Re: Extended attributes in MacOS X

2006-10-25 Thread Wayne Davison
On Wed, Oct 25, 2006 at 09:10:46PM +0200, Wesley W. Terpstra wrote: > I've attached the patch. You need to apply acls.diff and xattr.diff > first, and run autoconf/autoheader after. Great! I've taken your code, tweaked it a little, and then did some bug-fixing of the xattr code in general (I fo

Re: Extended attributes in MacOS X

2006-10-25 Thread Wesley W. Terpstra
On Oct 25, 2006, at 9:10 PM, Wesley W. Terpstra wrote: As for prefixing all MacOS xattrs with "user.", we'd need to come up with some rules that would preserve the xattrs for all data paths: Mac -> Mac, Mac -> Posix -> Mac, and Posix -> Mac -> Posix. So, a Mac receiver would need to be able to

Re: Extended attributes in MacOS X

2006-10-25 Thread Wesley W. Terpstra
On Oct 25, 2006, at 7:58 PM, Wayne Davison wrote: On Wed, Oct 25, 2006 at 05:57:38PM +0200, Wesley W. Terpstra wrote: My question: is this useful? should I prefix all MacOS EAs with 'user.'? I'd love to see such a patch, as this is the direction that I'd like to see rsync take in handling

Re: Extended attributes in MacOS X

2006-10-25 Thread Wayne Davison
On Wed, Oct 25, 2006 at 05:57:38PM +0200, Wesley W. Terpstra wrote: > My question: is this useful? should I prefix all MacOS EAs with 'user.'? I'd love to see such a patch, as this is the direction that I'd like to see rsync take in handling MacOS extended attributes. As for prefixing all MacOS x

Extended attributes in MacOS X

2006-10-25 Thread Wesley W. Terpstra
I've written a patch to 2.6.8 which adds extended attribute support to rsync. This is not like the plethora of patches which try to separate osx meta-data into a special appledouble file (._filename). Instead, it builds on patches/xattr.patch and just adds support for the MacOS equivalent.