Re: PATCH: cosmetic fix to output with --existing -vv

2005-04-11 Thread Wayne Davison
On Sun, Apr 10, 2005 at 09:22:13PM +0200, Paul Slootman wrote: > It would make more sense if it said: > > not creating new directory "newdir" Yeah, that's much nicer. I've applied your fix to the CVS version. Also, I was just looking at the patches for the Debian unstable version of rsync 2.6.4

PATCH: cosmetic fix to output with --existing -vv

2005-04-10 Thread Paul Slootman
Currently, rsync --delete -avvn test1/ test2/ --existing will give output such as: not creating new file "newdir" not creating new file "newdir/newfile" not creating new file "newdir/subdir" It would make more sense if it said: not creating new directory "newdir" not creating new file "newdir/n

Cosmetic

2003-03-02 Thread Zenon Panoussis
When using --progress , the download progress of the current file appears before the name of the file being copied. If the next file is up to date, the user never gets to see which file was updated. It would be more logical (and aestheticaly better) to put the file name and the progress the other w

Cosmetic fix for log.c

2002-01-24 Thread Jos Backus
gcc -I. -I. -g -O2 -DHAVE_CONFIG_H -Wall -W -I./popt -c log.c -o log.o log.c: In function `log_transfer': log.c:570: warning: unused parameter `file' While we pass in this ``file'' parameter, why not use it and thus get rid of this warning? The comment is kind of unclear though, any idea what the

Re: Cosmetic code cleanup?

2001-12-07 Thread Jos Backus
On Sat, Dec 08, 2001 at 12:07:22AM +1100, Martin Pool wrote: > Yes, I agree. I'll just run GNU indent over it and commit directly -- > no need to send a big noisy patch unless you really want to. Good plan, I wasn't sure how many issues like these GNU indent is able to fix. I'll have a look agai

Re: Cosmetic code cleanup?

2001-12-07 Thread Martin Pool
On 6 Dec 2001, Jos Backus <[EMAIL PROTECTED]> wrote: > Here's a list of cosmetic changes I'd be willing to make to the code in order > to make it more consistent, which stylisticly it currently is not. > > - separate function definitions by 2 newlines > - put s

Cosmetic code cleanup?

2001-12-06 Thread Jos Backus
Here's a list of cosmetic changes I'd be willing to make to the code in order to make it more consistent, which stylisticly it currently is not. - separate function definitions by 2 newlines - put spaces after commas in arg lists - put spaces around assignments - remove trailing space