Re: (patch) memory leak in loadparm.c

2002-01-02 Thread Colin Walters
On Wed, 2002-01-02 at 17:29, Dave Dykstra wrote: > Isn't there some solution that doesn't have to explicitly list every > variable name? I think that's asking for future bugs; just because there's > an instruction in a comment doesn't mean people will remember to do what > it says when they add a

Re: (patch) memory leak in loadparm.c

2002-01-02 Thread Dave Dykstra
Isn't there some solution that doesn't have to explicitly list every variable name? I think that's asking for future bugs; just because there's an instruction in a comment doesn't mean people will remember to do what it says when they add a new variable. - Dave Dykstra On Fri, Dec 28, 2001 at

(patch) memory leak in loadparm.c

2001-12-28 Thread Colin Walters
Hi, I spent a little bit of time trying to debug a segfault in rsync 2.5.0, and after discovering it was in loadparm.c, I noticed that the bug had been worked around in the current CVS by removing a free() statement. That fix seems less than optimal; here's a patch which should fix the memory lea