Re: readdir() and read() errors ignored

2003-08-24 Thread Michael Brown
> > A similar error can occur when open() succeeds but subsequent calls to > > read() fail: under these circumstances rsync will transfer zeroes instead > > of the actual file data and will again report no errors to the user. > > The attached patch fixes both of these problems. > There is a patch

readdir() and read() errors ignored

2003-08-23 Thread Michael Brown
We've just been hit rather badly by a very nasty bug that can cause rsync to silently discard files or fill them with zeroes. It happens when e.g. opendir() succeeds but readdir() returns an error; rsync does not check for an error from readdir() and so simply ignores the error (along with any