Re: Inadequate error checking in rsync 2.5.5

2003-08-18 Thread David Norwood
> > Okay, with this patch I now get error messages, but it still creates null > > filled output files. I guess that is what you meant by "the behavior is the > > same". > That is correct. At the point in which we detect the > problem there isn't anything we can do to produce > good files. The m

Re: Inadequate error checking in rsync 2.5.5

2003-08-15 Thread David Norwood
> I've had a chance to think on it. Attached is a patch that > allows unmap_file() to report the first read error that > map_ptr found. The behaviour is the same. I doubt this will > apply against anything but CVS HEAD as of now. > > This should probably use FERROR instead of FINFO so that a > p

Inadequate error checking in rsync 2.5.5

2003-08-14 Thread David Norwood
I'm using rsync to mirror files from a Windows XP machine mounted via smbfs. Apparently I have something configured wrong as I get a "permisson denied" error accessing some of the files on the smbfs mount with cp, od, etc. However, rsync produces no error messages on these files. It happily c