A crash when syncing xattr with rsync-3.0.6

2009-11-30 Thread Amir Rapson
Hi, I have a crash running rsync-3.0.6 and using the -X flag. The crash was in uncache_tmp_xattrs() when free was called on every xattr_item. However, the rsync_xal_l.items is a buffer, not a list, and so only the whole buffer should be freed, and not every item. Can anyone with git access please

Re: Enhanced authentication and authorization in rsyncd

2009-08-30 Thread Amir Rapson
A slightly better patch file (removed some warnings). On Wed, Aug 26, 2009 at 5:52 PM, Amir Rapson wrote: > Hi, > > I added a few things to allow the rsync daemon more refined > authorization and authentication than the current implementation. > The attached patch file is ag

Enhanced authentication and authorization in rsyncd

2009-08-26 Thread Amir Rapson
Hi, I added a few things to allow the rsync daemon more refined authorization and authentication than the current implementation. The attached patch file is against the 3.0.6 version. Additions: 1. allow the uid and gid used to access a certain module to be determined by the authenticated user -

Re: rsync occassionally issues the message "rsync error: unexplained error (code 255) at main.c(1506) [generator=3.0.4]"

2009-06-11 Thread Amir Rapson
Hi, Please try this patch below, I think it’ll solve the bug… Amir diff -U 5 -Nuir rsync-3.0.4/cleanup.c rsync-3.0.4.new/cleanup.c --- rsync-3.0.4/cleanup.c 2008-06-04 19:01:02.0 +0300 +++ rsync-3.0.4.new/cleanup.c 2009-03-29 09:45:04.0 +0300 @@ -98,11 +98,11 @@

Re: does --whole-file always work?

2009-05-15 Thread Amir Rapson
-- From: "Dave Dykstra" Sent: Friday, May 15, 2009 10:43 PM To: "Amir Rapson" Cc: Subject: Re: does --whole-file always work? On Thu, May 14, 2009 at 09:59:16AM -0400, Matt McCutchen wrote: On Thu, 2009-05-14 at 15:59 +0300, Amir Rapson wrote: > Running rsync with

does --whole-file always work?

2009-05-14 Thread Amir Rapson
Hi, Running rsync with --whole-file yields poorer performance results than a simple "cp". Looking at the code - it looks like "copy_file" isn't really called when I add the --whole-file flag. The regular "receive_data" is doing the copy. Anyone encountered this? No other special flags (rsync --who