Re: xfer_sum_len type bug

2023-05-26 Thread Derek Martin via rsync
On Fri, May 26, 2023 at 08:34:20AM -0700, Wayne Davison wrote: > On Tue, May 16, 2023 at 2:03 PM Derek Martin wrote: > > > This appears to be because of a type mismatch between xfer_sum_len > > (declared as [signed] int) and the third arugment to memset, whose > > function prototype is (from the m

Re: [PATCH] Add --omit-{device,special}-times options

2023-05-26 Thread Marc Aurèle La France via rsync
On Fri, 26 May 2023, Wayne Davison wrote: On Tue, May 16, 2023, Marc Aurèle La France wrote: Similar to --omit-{dir,link}-times: --omit-device-times omit device files from --times --omit-special-times omit sockets and fifos from --times I'm not convinced these are needed at present. I

Re: [PATCH] Add --omit-{device,special}-times options

2023-05-26 Thread Wayne Davison via rsync
On Tue, May 16, 2023 at 7:28 PM Marc Aurèle La France wrote: > Similar to --omit-{dir,link}-times: > > --omit-device-times omit device files from --times > --omit-special-times omit sockets and fifos from --times > I'm not convinced these are needed at present. Also, fix corner case that allows

Re: [PATCH] Fix the counting of device files and symlinks

2023-05-26 Thread Wayne Davison via rsync
On Tue, May 16, 2023 at 7:28 PM Marc Aurèle La France via rsync < rsync@lists.samba.org> wrote: > Device files should be counted as devices, not symlinks. > Thanks for the catch! I fixed this the other day. ..wayne.. -- Please use reply-all for most replies to avoid omitting the mailing list. T

Re: xfer_sum_len type bug

2023-05-26 Thread Wayne Davison via rsync
On Tue, May 16, 2023 at 2:03 PM Derek Martin wrote: > This appears to be because of a type mismatch between xfer_sum_len > (declared as [signed] int) and the third arugment to memset, whose > function prototype is (from the man page): > >void *memset(void *s, int c, size_t n); > If that i