Re: [PATCH] Reduce memory usage

2021-09-28 Thread Johannes Altmanninger via rsync
Looks awesome, really nice catch! -- Please use reply-all for most replies to avoid omitting the mailing list. To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html

[PATCH] Reduce memory usage

2021-09-28 Thread Jindřich Makovička via rsync
In 2004, an allocation optimization has been added to the file list handling code, that preallocates 32k of file_struct pointers in a file_list. This optimization predates the incremental recursion feature, for which it is not appropriate anymore. When copying a tree containing a large number of sm

Re: [PATCH] Reduce memory usage

2021-09-28 Thread Jindřich Makovička via rsync
On Mon, 27 Sep 2021 22:03:01 +0200 Johannes Altmanninger wrote: > > On Sun, Sep 26, 2021 at 01:54:13PM +0200, Jindřich Makovička via > > rsync wrote: > > > > Applying the attached patch, which reduces the default allocation > > to 32 pointers, and preallocates 32K pointers only for the main > >