Feature request: don't fail if using -z from --with-included-zlib=yes to --with-included-zlib=no

2020-05-20 Thread Samuel Henrique via rsync
Hello, I'm one of the Debian maintainers of rsync and I'm currently investigating the switch from "--with-included-zlib=yes" to "no" for the next stable release (ETA 2021). So basically I'm investigating what are the impacts of using upstream's zlib instead of rsync's bundled one. For the investi

Re: [PATCHv2] SSE2/SSSE3 optimized version of get_checksum1() for x86-64

2020-05-20 Thread Jorrit Jongma via rsync
I haven't found a way to control GCC's target selector at runtime (though in theory it could be possible), so switching between specific optimizations (SSE2 vs SSSE3) may prove difficult or require additional duplication of code. Bypassing the optimizations completely in an all-or-nothing way shoul

Re: [PATCHv2] SSE2/SSSE3 optimized version of get_checksum1() for x86-64

2020-05-20 Thread Roland via rsync
would it perhaps make sense to have a "--disable-sse2/3" commandline switch in rsync, too - at least for some timeframe until this is considered "rock solid" ? i dislike having automatic cpu feature switching code in a tool which needs to be reliable for me, this new optimization may have issues