Re: Bug-report:rsync may hung if time jumps backwards

2014-11-27 Thread yhu2
thanks your reply, could you please send off official fix? On 11/28/2014 04:05 AM, Wayne Davison wrote: On Sun, Nov 16, 2014 at 10:44 PM, yhu2 > wrote: + usleep(t*1000); Is it a correct fix? any comments would be appreciated!!! The hang was not because t

[Bug 10936] Rsync path hijacking attack vulnerability

2014-11-27 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=10936 --- Comment #5 from Wayne Davison --- (In reply to roland from comment #4) Yes, those are the commits for this bug. -- You are receiving this mail because: You are the QA Contact for the bug. -- Please use reply-all for most replies to avoid omi

Re: Bug-report:rsync may hung if time jumps backwards

2014-11-27 Thread Wayne Davison
On Sun, Nov 16, 2014 at 10:44 PM, yhu2 wrote: > + usleep(t*1000); > Is it a correct fix? any comments would be appreciated!!! > The hang was not because time went backwards, but because it moved forward by over 2 years (which overflows a variable, making the value negative). I both fixed that i

[Bug 10936] Rsync path hijacking attack vulnerability

2014-11-27 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=10936 --- Comment #4 from roland --- that fix is this two commits, correct ? https://git.samba.org/?p=rsync.git;a=commit;h=371242e4e8150d4f9cc74cdf2d75d8250535175e https://git.samba.org/?p=rsync.git;a=commit; h=4cad402ea8a91031f86c53961d78bb7f4f174790

[Bug 10936] Rsync path hijacking attack vulnerability

2014-11-27 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=10936 Wayne Davison changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Bug 10951] Emtpy parameter triggers unwanted behavior, but no error message

2014-11-27 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=10951 --- Comment #3 from Wayne Davison --- Let me also add that if the cause was a bash shell variable that ended up being empty, then you should note that it is a bash-ism to require parameters to be double-quoted in order for them to behave sanely (e.

[Bug 10951] Emtpy parameter triggers unwanted behavior, but no error message

2014-11-27 Thread samba-bugs
https://bugzilla.samba.org/show_bug.cgi?id=10951 Wayne Davison changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---