Re: incoming chmod on daemon fails on subdirectories

2006-09-22 Thread Matt McCutchen
Attached is my patch. I rewrote dest_mode and fixed the bug in the process. I also added a test to chmod-option.test and updated acls.diff to correctly patch my new dest_mode. Matt ### Eclipse Workspace Patch 1.0 #P rsync Index: rsync.c ==

Re: incoming chmod on daemon fails on subdirectories

2006-09-22 Thread Matt McCutchen
The trouble is that tweak_mode (the function that applies chmod strings) determines the type of the file it is processing based on the type bits of the original mode it is passed, but dest_mode calls it with a mode in which the type bits are zero when calculating destination permissions for a file

Re: Improvements to --progress in man page

2006-09-22 Thread Matt McCutchen
On 9/22/06, Wayne Davison <[EMAIL PROTECTED]> wrote: Thanks! Those are some good changes. I tweaked the text a little bit more, and committed the result. Looks good. I notice you took out both references to the "overall transfer", presumably to avoid confusion with transfers of individual re

Re: Syncing moved files

2006-09-22 Thread Matt McCutchen
On 9/22/06, Wayne Davison <[EMAIL PROTECTED]> wrote: On Fri, Sep 22, 2006 at 07:17:02PM -0400, Matt McCutchen wrote: > I suppose you want the receiver to skip the transfer entirely and just > move the file if --checksum is on and the checksums match. That doesn't really save you time (over leavi

Re: Improvements to --progress in man page

2006-09-22 Thread Wayne Davison
On Fri, Sep 22, 2006 at 06:33:35PM -0400, Matt McCutchen wrote: > Attached is a patch that improves the discussion of --progress in the > rsync man page. It makes one badly needed update: the man page needs > to use "(xfer#5, to-check=169/396)" instead of "(5, 57.1% of 396)". > In addition, I trie

Re: Syncing moved files

2006-09-22 Thread Wayne Davison
On Fri, Sep 22, 2006 at 07:17:02PM -0400, Matt McCutchen wrote: > I suppose you want the receiver to skip the transfer entirely and just > move the file if --checksum is on and the checksums match. That doesn't really save you time (over leaving --checksum off) since you have to read the entire fi

Re: rsyncing from win1251 to UTF-8

2006-09-22 Thread Wayne Davison
On Fri, Sep 22, 2006 at 01:33:43PM +0600, Yakov Hrebtov wrote: > Do you plan to include this patch to official releases? When? It will be included eventually, once it has been fully finished. What's there works well, but there are a couple more places where the charset conversion needs to be inse

Re: Syncing moved files

2006-09-22 Thread Matt McCutchen
On 9/22/06, Martin Gadbois <[EMAIL PROTECTED]> wrote: But rsync does not know that I moved an identical picture from tmp/ to Vacations/, it transfers the whole file, and deletes the one that was in tmp/, even though a local move might have done it. Is there a way that rsync could, for all known

Improvements to --progress in man page

2006-09-22 Thread Matt McCutchen
Attached is a patch that improves the discussion of --progress in the rsync man page. It makes one badly needed update: the man page needs to use "(xfer#5, to-check=169/396)" instead of "(5, 57.1% of 396)". In addition, I tried to make the rest of the discussion more precise. Matt ### Eclipse Wo

Re: incoming chmod on daemon fails on subdirectories

2006-09-22 Thread Bill Uhl
Paul Slootman wrote: On Fri 22 Sep 2006, Bill Uhl wrote: Tried leaving out the repeated D and F per the manpage. Permissions without the leading D and F were applied to both directories and files. I am not sure how this would work. Would this make the chmod settings order speci

Re: incoming chmod on daemon fails on subdirectories

2006-09-22 Thread Paul Slootman
On Fri 22 Sep 2006, Bill Uhl wrote: > Tried leaving out the repeated D and F per the manpage. Permissions > without the leading D and F were applied to both directories and files. > I am not sure how this would work. Would this make the chmod settings > order specific? I had guessed order-spec

Re: incoming chmod on daemon fails on subdirectories

2006-09-22 Thread Bill Uhl
Tried leaving out the repeated D and F per the manpage. Permissions without the leading D and F were applied to both directories and files. I am not sure how this would work. Would this make the chmod settings order specific? Regarding the filesystem, it's ext3 on an LVM logical volume on a so

Syncing moved files

2006-09-22 Thread Martin Gadbois
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi all, I use rsync to keep an off-site backup of my photographs. I dump from my camera everything into a tmp/ directory, which I then clean and move gradually all pictures into the right directory (Vacations/, for example). But rsync does not know

Re: incoming chmod on daemon fails on subdirectories

2006-09-22 Thread Paul Slootman
On Fri 22 Sep 2006, Bill Uhl wrote: >incoming chmod = Dg=s,Dug=rwx,Do-rwx,Fug=rw,Fo-rwx Following the example in the manpage, I would have used: incoming chmod = Dg=s,ug=rwx,o-rwx,Fug=rw,Fo-rwx i.e. leaving out the repeated D and F letters. > 2006/09/21 04:34:58 [6860] default_per

incoming chmod on daemon fails on subdirectories

2006-09-22 Thread Bill Uhl
Running rsync 2.6.8 as daemon on Fedora core 4. Have the following in the rsyncd.conf file... [test] path = /home/test/greenlight # use chroot = true max connections = 3 lock file = /var/lock/rsyncd/test.lock uid = 503 gid = 503 auth users = test

Re: rsyncing from win1251 to UTF-8

2006-09-22 Thread Yakov Hrebtov
Yakov Hrebtov wrote: Wayne, could you please point me to the nightly snapshots? I have found snapshots myself, sorry. -- To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html

Re: rsyncing from win1251 to UTF-8

2006-09-22 Thread Yakov Hrebtov
Wayne Davison wrote: On Fri, Sep 22, 2006 at 11:09:17AM +0600, Yakov Hrebtov wrote: This patch does not completely applied to rsync-2.6.8 source. Some hunks are failed. The patch is intended for the CVS version, which is also available via the "nightly" tar files. Wayne, could you please poi