@ffesti commented on this pull request.
> @@ -159,9 +159,18 @@ static int addTE(rpmte p, Header h, fnpyKey key,
> rpmRelocation * relocs)
p->arch = headerGetAsString(h, RPMTAG_ARCH);
p->os = headerGetAsString(h, RPMTAG_OS);
-/* gpg-pubkey's dont have os or arch (sigh), for other
@ffesti commented on this pull request.
> @@ -227,6 +236,10 @@ static int addTE(rpmte p, Header h, fnpyKey key,
> rpmRelocation * relocs)
rc = 0;
exit:
+if (rc) {
+ rpmlog(RPMLOG_ERR, _("misformed package %s\n"),
+ p->NEVRA ? p->NEVRA : (p->name ? p->name : "-"));
@pmatilai commented on this pull request.
> @@ -159,9 +159,18 @@ static int addTE(rpmte p, Header h, fnpyKey key,
> rpmRelocation * relocs)
p->arch = headerGetAsString(h, RPMTAG_ARCH);
p->os = headerGetAsString(h, RPMTAG_OS);
-/* gpg-pubkey's dont have os or arch (sigh), for oth
@pmatilai Oh, now I think I'm getting the problem @ffesti was worried about –
when using just `-S git`, anyone with properly configured git would end up
being marked as the author of the non-git patches, whether they like it or not
– and there is nothing they can easily do to switch back to usin
@ffesti pushed 4 commits.
29e3a017c3e4c0e585f2fe02a938aa8afcf9c8d0 Don't allow installing packages
without ARCH or OS
3a3179718c497e88e250933af2e41ab1edcd0e18 Add test case for missing mandatory
tags
b746621878f22e8fd855391cc39abc8fcbe71a1b Don't allow installing gpg-pubkey
packages
abbf0e8c
Closed #3469 as completed via #3479.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/3469#event-15509259878
You are receiving this because you are subscribed to this thread.
Message ID:
___
R
Merged #3479 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3479#event-15509259607
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint mail
Unsure if this is possible with RPM,
but if there was a way to add hashes calculated from the headers as data in he
signed payload without the need to further modify said headers, then you could
make this backwards compatible in the sense that older version of RPM would
still check the classic s
(commit message clarified a bit)
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3482#issuecomment-2513948563
You are receiving this because you are subscribed to this thread.
Message ID: ___
Rp
Maybe, we could salvage HDRID for this purpose.
Rename the tag pointing to SHA1HEADER to OLDHDRID as per rpm tag renaming
tradition (we just haven't done that in ages) so older rpms always get the SHA1
they expect from that tag and nothing for v6 packages, newer rpm's will get
SHA256HEADER, and
Only libgcrypt and openssl support this at the moment, so we can't yet test
in the CI setup. Tests manually verified with both.
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/3482
-- Commit Summary --
* Add support for SHA
So, the attempt is here. I'm splitting the original setup macros into several
named steps, then combining them back as needed. I'm not 100% satisfied with
the names, but I figured they are good enough to throwing the implementation up
for discussion.
--
Reply to this email directly or view it
@ffesti pushed 4 commits.
138f7b192c1a45c03c3477a31ae095b697e72672 Don't allow installing packages
without ARCH or OS
ade31e96dea2f91f9d2a470197b56e44fe1126ad Add test case for missing mandatory
tags
8425def4db39050c661718bb9982eeeabbc1a964 Don't allow installing gpg-pubkey
packages
b6a57939
@ffesti commented on this pull request.
> @@ -159,9 +159,18 @@ static int addTE(rpmte p, Header h, fnpyKey key,
> rpmRelocation * relocs)
p->arch = headerGetAsString(h, RPMTAG_ARCH);
p->os = headerGetAsString(h, RPMTAG_OS);
-/* gpg-pubkey's dont have os or arch (sigh), for other
Merged #3478 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3478#event-15510342648
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint mail
Closed #3344 as completed via #3478.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/3344#event-15510343021
You are receiving this because you are subscribed to this thread.
Message ID:
___
R
Closed #3344 as completed via b92bd1b9fd11ae7654cc2797fffaeeeddaaa3c7e.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/3344#event-15510343046
You are receiving this because you are subscribed to this thread.
Message ID:
__
@khardix pushed 1 commit.
5f6f6b8554f5593f14e2d293c1318b0194779126 Split git setup to multiple macros
--
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3472/files/77d585ceb8cb5b8085fe0a80a54d07d51da36c45..5f6f6b8554f5593f14e2d293c1318b0194779126
You are receiving this be
Closed #3436 as completed via #3482.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/3436#event-15506443853
You are receiving this because you are subscribed to this thread.
Message ID:
___
R
Merged #3482 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3482#event-15506443515
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint mail
Concrete proposal:
- New-style signatures are _required_ in v6 packages.
- New-style signatures always cover both headers, including the entire main
header and all of the signature header except for the tag data entry containing
the new-style signatures.
- If a new-style signature is present, th
Hi @pmatilai, @ffesti any inputs on this?
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/discussions/3480#discussioncomment-11457103
You are receiving this because you are subscribed to this thread.
Message ID:
__
22 matches
Mail list logo
