Re: [Rpm-maint] [rpm-software-management/rpm] RFE: add shorthand options for rpmkeys operations (Issue #3435)

2024-11-15 Thread Florian Festi
`-l` and `-i` is pretty obvious. But I stumbled over `-e` for `--export` and it felt weird as `rpm -e` doesn't exactly export anything. Then I was wondering whether we shouldn't have `rpmkeys --erase` in parallel to `rpm --erase` instead of `rpmkeys --delete` which is yet another word for removi

[Rpm-maint] [rpm-software-management/rpm] systemd 257 defines a new modifier ! for u entries (Issue #3450)

2024-11-15 Thread Zbigniew Jędrzejewski-Szmek
https://github.com/systemd/systemd/commit/2ec7977e1b100c1717d95417e6d825fbf939f7b3 defines `u!`, and https://github.com/systemd/systemd/commit/a4c0528f14 adds it to all `u` lines used by systemd. I'll revert this change in systemd config to do the build, but inevitably other projects are going

Re: [Rpm-maint] [rpm-software-management/rpm] Eliminate the need for run() wrapper in the test-suite (PR #3447)

2024-11-15 Thread Panu Matilainen
@pmatilai pushed 1 commit. dd8d5521285714f11a5bbaea95518dd599338682 fixup! Eliminate all uses of the now redundant run() in test-suite -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/3447/files/b8bd4a89beb3c958afaa8b19c6d7c1a17950e9bf..dd8d5521285714f11a5bbaea95518dd5

Re: [Rpm-maint] [rpm-software-management/rpm] Eliminate the need for run() wrapper in the test-suite (PR #3447)

2024-11-15 Thread Panu Matilainen
@pmatilai pushed 0 commits. -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/3447/files/dd8d5521285714f11a5bbaea95518dd599338682..b7226907bb6023c40a7ea364f4c1f54d8af91a03 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [Rpm-maint] [rpm-software-management/rpm] Eliminate the need for run() wrapper in the test-suite (PR #3447)

2024-11-15 Thread Panu Matilainen
@pmatilai pushed 2 commits. f82da317ff1628a21fa1248a81c1633043446882 Fix resource leak if sqlite open fails b5c6c21f7f2171fc06a36af03a757a22eb68364a Drop apparently redundant rpmdb related defines from test run() wrapper -- View it on GitHub: https://github.com/rpm-software-management/rpm/pul

Re: [Rpm-maint] [rpm-software-management/rpm] Eliminate the need for run() wrapper in the test-suite (PR #3447)

2024-11-15 Thread Panu Matilainen
@pmatilai pushed 1 commit. 6707917bc41d101cd397cff4e326fbfbdbca5b7c Fix resource leak if sqlite open fails -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/3447/files/6495cae237e7112cea14de56b7a53cdeb3a8f856..6707917bc41d101cd397cff4e326fbfbdbca5b7c You are receiving th

Re: [Rpm-maint] [rpm-software-management/rpm] Add short CLI commands to rpmkeys (PR #3448)

2024-11-15 Thread Panu Matilainen
Mm, I wouldn't delete --delete so completely. Both gnupg and sequoia use the term "delete" wrt keys, and I think that's where it comes to rpmkeys too. I'd just add -e/--erase as a visible alias to that, with the idea that it's simply more familiar in the rpm context. -- Reply to this email dir

Re: [Rpm-maint] [rpm-software-management/rpm] Eliminate the need for run() wrapper in the test-suite (PR #3447)

2024-11-15 Thread Panu Matilainen
Okay... So that "rpmdb --export and --import" test fails due to the --dbpath definition being removed. What's peculiar is that said test explicitly sets dbpath by itself: `--dbpath ${RPMTEST}/data/misc/`. But, due to the way the wrapper functions work, the dbpath set by the test doesn't get used

Re: [Rpm-maint] [rpm-software-management/rpm] Eliminate the need for run() wrapper in the test-suite (PR #3447)

2024-11-15 Thread Panu Matilainen
@pmatilai pushed 1 commit. ab7ab9e0d8bd393437df422131681e931fa2106a fixup! Drop apparently redundant rpmdb related defines from test run() wrapper -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/3447/files/b5c6c21f7f2171fc06a36af03a757a22eb68364a..ab7ab9e0d8bd393437df

Re: [Rpm-maint] [rpm-software-management/rpm] Eliminate the need for run() wrapper in the test-suite (PR #3447)

2024-11-15 Thread Panu Matilainen
@pmatilai pushed 4 commits. b91c2619a97d06cff74ab66c4639d001e2a3b3a2 Drop apparently redundant rpmdb related defines from test run() wrapper a0340f98f006bf3b4cbd0f34fd3822dfa292f9e0 Eliminate the last --define from test-suite run() function 3bc7fc5089cbb246b041490b6415a89851186c86 Eliminate a

[Rpm-maint] [rpm-software-management/rpm] Eliminate the need for run() wrapper in the test-suite (PR #3447)

2024-11-15 Thread Panu Matilainen
Details in commit messages, but short summary: move the test-suite rpm configuration from --define's to a permanent file, and setup_env calls from the wrapper functions to RPMTEST_CHECK*(). As a result, run() becomes entirely redundant can be removed - that is, for a large class of tests, you ca

Re: [Rpm-maint] [rpm-software-management/rpm] RFE: add shorthand options for rpmkeys operations (Issue #3435)

2024-11-15 Thread Panu Matilainen
-x for export seems fine to me. As for --delete/--erase I agree, we should probably support -e/--erase as an alias for --delete. Too bad we only realize this now after --delete went official in 4.20, but such is life. -- Reply to this email directly or view it on GitHub: https://github.com/rpm

[Rpm-maint] [rpm-software-management/rpm] Add short CLI commands to rpmkeys (PR #3448)

2024-11-15 Thread Florian Festi
You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/3448 -- Commit Summary -- * Add short CLI commands to rpmkeys * Rename rpmkeys --delete to rpmkeys --erase -- File Changes -- M docs/man/rpmkeys.8.md (20) M tests/

Re: [Rpm-maint] [rpm-software-management/rpm] Eliminate the need for run() wrapper in the test-suite (PR #3447)

2024-11-15 Thread Panu Matilainen
@pmatilai pushed 1 commit. 6495cae237e7112cea14de56b7a53cdeb3a8f856 Drop apparently redundant rpmdb related defines from test run() wrapper -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/3447/files/b7226907bb6023c40a7ea364f4c1f54d8af91a03..6495cae237e7112cea14de56b7a

Re: [Rpm-maint] [rpm-software-management/rpm] Add internal C++ native path manipulation functions (PR #3442)

2024-11-15 Thread Florian Festi
Merged #3442 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3442#event-15309955482 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mail

Re: [Rpm-maint] [rpm-software-management/rpm] Document ways to declare sources and patches (PR #3405)

2024-11-15 Thread ニール・ゴンパ
@Conan-Kudo commented on this pull request. > @@ -170,17 +170,26 @@ Short (< 70 characters) summary of the package. Used to declare source(s) used to build the package. All sources will will be packaged into source rpms. -Arbitrary number of sources may be declared, for example: +Arbitrary n

Re: [Rpm-maint] [rpm-software-management/rpm] Eliminate the need for run() wrapper in the test-suite (PR #3447)

2024-11-15 Thread Panu Matilainen
Oh pooh, *ONE* test fails and I can't reproduce that locally. Going to be fun chasing this down... -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3447#issuecomment-2478778351 You are receiving this because you are subscribed to this thre

Re: [Rpm-maint] [rpm-software-management/rpm] Add short CLI commands to rpmkeys (PR #3448)

2024-11-15 Thread Florian Festi
@ffesti pushed 1 commit. 466847b8fa56f7a1f121642b02b5a50e45c088e6 Don't delete delete -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/3448/files/d80b8ffa4a17f390e2ef197c312fd019fe4258e3..466847b8fa56f7a1f121642b02b5a50e45c088e6 You are receiving this because you are su

Re: [Rpm-maint] [rpm-software-management/rpm] Add short CLI commands to rpmkeys (PR #3448)

2024-11-15 Thread Florian Festi
Ok, this rolls back the --delete removal and keeps is as an equal alternative. Last two patches should probably be squashed before merging. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3448#issuecomment-2479673284 You are receiving thi

[Rpm-maint] [rpm-software-management/rpm] rpmbuild -ta option no longer works (Issue #3449)

2024-11-15 Thread Aditi Gaur
`rpmbuild -ta ` complains that it fails to find the spec file. The spec file exists in the top of the unpacked directory. root [ / ]# rpmbuild -ta slurm-24.05.4.tar.bz2 error: Failed to read spec file from slurm-24.05.4.tar.bz2 The slurm tarball in this case does have the spec file at t