Re: [Rpm-maint] [rpm-software-management/rpm] RFE: add support for SHA-3 (Issue #3436)

2024-11-08 Thread Panu Matilainen
Nothing in rpm v6 depends on SHA-3 so this isn't timing critical for us, it's more of a "HDTV-ready" type of thing :smile: -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/3436#issuecomment-2464007538 You are receiving this because you

Re: [Rpm-maint] [rpm-software-management/rpm] Fixes + cleanups to rpmkeys manual (PR #3433)

2024-11-08 Thread Michal Domonkos
Merged #3433 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3433#event-15208158856 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mail

Re: [Rpm-maint] [rpm-software-management/rpm] Move installed gpg keys to the currently configured storage (Issue #3347)

2024-11-08 Thread Panu Matilainen
Yes, gpg-pubkeys do survive rpmdb --rebuild currently. But they don't get reimported so they stay in the short id mode. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/3347#issuecomment-2464573783 You are receiving this because you are

Re: [Rpm-maint] [rpm-software-management/rpm] Move installed gpg keys to the currently configured storage (Issue #3347)

2024-11-08 Thread Panu Matilainen
For the db, I guess you could basically create an empty rpmdb in an alternative path where you put them temporarily. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/3347#issuecomment-2464580389 You are receiving this because you are su

Re: [Rpm-maint] [rpm-software-management/rpm] Move installed gpg keys to the currently configured storage (Issue #3347)

2024-11-08 Thread Florian Festi
Hmm, the question is on how to do that in a save way. E.g. for the database backend there is no clean slate to start from. We ofc could remove all gpgpubkey packages and then add the loaded keys back. But that leaves things very vulnerable inbetween. The file based backends can at least save s

Re: [Rpm-maint] [rpm-software-management/rpm] Move installed gpg keys to the currently configured storage (Issue #3347)

2024-11-08 Thread Panu Matilainen
Oh, that. No idea. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/3347#issuecomment-2464708417 You are receiving this because you are subscribed to this thread. Message ID:

[Rpm-maint] [rpm-software-management/rpm] Implement openpgp.cert.d based keystore (PR #3437)

2024-11-08 Thread Florian Festi
Refactor code from the fs backend into shared helper functions This does implement the layout on the file system and the write lock of the openpgp.cert.d proposal according to https://www.ietf.org/archive/id/draft-nwjw-openpgp-cert-d-00.html but not the Trust root, Petname mapping or Trusted int

Re: [Rpm-maint] [rpm-software-management/rpm] Move installed gpg keys to the currently configured storage (Issue #3347)

2024-11-08 Thread Florian Festi
Should have worded this better: Do the fs backend keys survive a rpmdb --rebuild? -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/3347#issuecomment-2464689314 You are receiving this because you are subscribed to this thread. Message I

Re: [Rpm-maint] [rpm-software-management/rpm] Implement openpgp.cert.d based keystore (PR #3437)

2024-11-08 Thread Neal H. Walfield
@nwalfield commented on this pull request. > -if (replace) { - rasprintf(&tmppath, "%s.new", path); - unlink(tmppath); +rc = write_key_to_disk(key, dirstr, keyfmt, replace, flags); + +if (!rc && replace) { + /* find and delete the old pubkey entry */ I'm a bit co

Re: [Rpm-maint] [rpm-software-management/rpm] Fixes + cleanups to rpmkeys manual (PR #3433)

2024-11-08 Thread Michal Domonkos
@dmnks pushed 1 commit. 7627bd92182616ac0568c44dab4b1c00a559a56b fixup! Fixes + cleanups to rpmkeys manual -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/3433/files/6bec5fc3de53e8885a769c36b498e4b824e112df..7627bd92182616ac0568c44dab4b1c00a559a56b You are receiving t

Re: [Rpm-maint] [rpm-software-management/rpm] Fixes + cleanups to rpmkeys manual (PR #3433)

2024-11-08 Thread Michal Domonkos
@dmnks approved this pull request. LGTM, thanks Neal for looking, too! I've just fixed up a lonely opening square bracket before the `--delete` argument (which is actually mandatory). -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/343

Re: [Rpm-maint] [rpm-software-management/rpm] Fixes + cleanups to rpmkeys manual (PR #3433)

2024-11-08 Thread Michal Domonkos
@dmnks pushed 1 commit. 42a192cde8b8d7bcb784a09520c9094f5325f2ca fixup! Fixes + cleanups to rpmkeys manual -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/3433/files/7627bd92182616ac0568c44dab4b1c00a559a56b..42a192cde8b8d7bcb784a09520c9094f5325f2ca You are receiving t

Re: [Rpm-maint] [rpm-software-management/rpm] Fixes + cleanups to rpmkeys manual (PR #3433)

2024-11-08 Thread Michal Domonkos
@dmnks pushed 1 commit. 11794c9ab1b7379ecdc1c542fe6abbc68ad1a004 fixup! Sanitize rpmsign --addsign/--delsign output -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/3433/files/42a192cde8b8d7bcb784a09520c9094f5325f2ca..11794c9ab1b7379ecdc1c542fe6abbc68ad1a004 You are re

Re: [Rpm-maint] [rpm-software-management/rpm] Fixes + cleanups to rpmkeys manual (PR #3433)

2024-11-08 Thread Michal Domonkos
One more typo fixup :smile: -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3433#issuecomment-2464202384 You are receiving this because you are subscribed to this thread. Message ID:

Re: [Rpm-maint] [rpm-software-management/rpm] Fixes + cleanups to rpmkeys manual (PR #3433)

2024-11-08 Thread Michal Domonkos
I've autosquashed the fixup commit on top and will merge this once the CI finishes. This is the fixup patch I've applied, just for full transparency: ```diff diff --git a/docs/man/rpmkeys.8.md b/docs/man/rpmkeys.8.md index e7993e52c..093a91606 100644 --- a/docs/man/rpmkeys.8.md +++ b/docs/man/rp

Re: [Rpm-maint] [rpm-software-management/rpm] Implement openpgp.cert.d based keystore (PR #3437)

2024-11-08 Thread Florian Festi
@ffesti commented on this pull request. > -if (replace) { - rasprintf(&tmppath, "%s.new", path); - unlink(tmppath); +rc = write_key_to_disk(key, dirstr, keyfmt, replace, flags); + +if (!rc && replace) { + /* find and delete the old pubkey entry */ The patch obscu

Re: [Rpm-maint] [rpm-software-management/rpm] Implement openpgp.cert.d based keystore (PR #3437)

2024-11-08 Thread Panu Matilainen
@pmatilai commented on this pull request. > } -if (rpmMkdirs(rpmtxnRootDir(txn), "%{_keyringpath}")) { +free(dir); +return rc; +} + +/*/ + +static rpmRC acquire_write_lock(rpmtxn txn) The txn handle *

Re: [Rpm-maint] [rpm-software-management/rpm] Implement openpgp.cert.d based keystore (PR #3437)

2024-11-08 Thread Florian Festi
@ffesti commented on this pull request. > } -if (rpmMkdirs(rpmtxnRootDir(txn), "%{_keyringpath}")) { +free(dir); +return rc; +} + +/*/ + +static rpmRC acquire_write_lock(rpmtxn txn) I know. But the st

Re: [Rpm-maint] [rpm-software-management/rpm] Implement openpgp.cert.d based keystore (PR #3437)

2024-11-08 Thread Neal H. Walfield
@nwalfield commented on this pull request. > -if (replace) { - rasprintf(&tmppath, "%s.new", path); - unlink(tmppath); +rc = write_key_to_disk(key, dirstr, keyfmt, replace, flags); + +if (!rc && replace) { + /* find and delete the old pubkey entry */ Thanks for t