Re: [Rpm-maint] [rpm-software-management/rpm] Add rpmlogOnce() and rpmlogReset() (PR #3417)

The added test looks alright, there was also a forgotten `.logDomain` initialization in `rpmReadPackageFile()`, apparently :sweat_smile:, now also fixed. I won't merge yet to give Florian a chance to act upon Panu's suggestions above (if he wishes so). Otherwise, it's good to go. -- Reply to

Re: [Rpm-maint] [rpm-software-management/rpm] Implement merging of new key material when importing pubkeys (PR #3083)

Thank you all for working on this. Many Copr users encountered this issue, so the fix is greatly appreciated. As I understand the discussion, the feature should already be released and available? I am testing it in a F41 container: ```bash $ rpm -q rpm rpm-4.20.0-1.fc41.x86_64 $ rpm -q rpm-seq

Re: [Rpm-maint] [rpm-software-management/rpm] RFE: add support for multiple OpenPGP signatures per package (Issue #3385)

@JanZerebecki Verifying reproducibility for RPM packages has always required filtering out certain RPM tags. Once those tags are filtered out, it's very easy to identify whether they are reproducible or not. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-

Re: [Rpm-maint] [rpm-software-management/rpm] Add rpmlogOnce() and rpmlogReset() (PR #3417)

@pmatilai commented on this pull request. > @@ -22,6 +23,7 @@ struct rpmlogCtx_s { unsigned mask; int nrecsPri[RPMLOG_NPRIS]; std::vector recs; +std::map, int>> seen; Something that occurred to me last evening after work: this would be better off with unordered_map for both

[Rpm-maint] [rpm-software-management/rpm] Extend CI to test each commit separately in a PR (Issue #3421)

Bisecting is so much easier when each commit is a self-contained change that compiles fine. Bonus points for it passing the test-suite also. I haven't thought about it too much yet but it seems like `make ci` would be the best place to hook this up since it requires multiple git checkouts follo

Re: [Rpm-maint] [rpm-software-management/rpm] Add rpmlogOnce() and rpmlogReset() (PR #3417)

@pmatilai commented on this pull request. > @@ -412,3 +415,36 @@ void rpmlog (int code, const char *fmt, ...) exit: errno = saved_errno; } + +int rpmlogOnce (uint64_t domain, const char * key, int code, const char *fmt, ...) +{ +int saved_errno = errno; +rpmlogCtx ctx = rpmlogCtx

[Rpm-maint] [rpm-software-management/rpm] Fix a horrible performance regression caused by missing & (PR #3422)

One of the busiest functions in rpm was getting passed a new copy of a big unordered_map on each call during fingerprinting because "somebody" forgot a & in commit 08a6a5e848f007c2e8d83fc1df8712d1a43229f4. This isn't even noticeable in the test-suite or daily "update a few dozen packages" opera

Re: [Rpm-maint] [rpm-software-management/rpm] Fix a horrible performance regression caused by missing & (PR #3422)

Merged #3422 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3422#event-15064623501 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mail

Re: [Rpm-maint] [rpm-software-management/rpm] Fix a horrible performance regression caused by missing & (PR #3422)

And the prize for the most impactful one-liner of the month goes to... -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3422#issuecomment-2451691997 You are receiving this because you are subscribed to this thread. Message ID:

Re: [Rpm-maint] [rpm-software-management/rpm] Fix a horrible performance regression caused by missing & (PR #3422)

@dmnks approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3422#pullrequestreview-2409892563 You are receiving this because you are subscribed to this thread. Message ID: ___