Re: [Rpm-maint] [rpm-software-management/rpm] Code cleanups in tests/rpmpgppubkeyfingerprint.c (PR #3068)

2024-05-02 Thread Shreenidhi Shedi
Closed #3068. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3068#event-12681683498 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm

Re: [Rpm-maint] [rpm-software-management/rpm] Code cleanups in tests/rpmpgppubkeyfingerprint.c (PR #3068)

2024-05-02 Thread Shreenidhi Shedi
Accidentally closed it, I will open a new PR. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3068#issuecomment-2090506199 You are receiving this because you are subscribed to this thread. Message ID: _

[Rpm-maint] [rpm-software-management/rpm] Cleanups and improvements in tests/rpmpgppubkeyfingerprint.c (PR #3072)

2024-05-02 Thread Shreenidhi Shedi
You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/3072 -- Commit Summary -- * rpmpgppubkeyfingerprint.c: use const qualifier * rpmpgppubkeyfingerprint.c: use rasprintf * rpmpgppubkeyfingerprint.c: use goto for returning f

Re: [Rpm-maint] [rpm-software-management/rpm] Code cleanups in tests/rpmpgppubkeyfingerprint.c (PR #3068)

2024-05-02 Thread Shreenidhi Shedi
Created https://github.com/rpm-software-management/rpm/pull/3072 -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3068#issuecomment-2090760401 You are receiving this because you are subscribed to this thread. Message ID: __

Re: [Rpm-maint] [rpm-software-management/rpm] Cleanups and improvements in tests/rpmpgppubkeyfingerprint.c (PR #3072)

2024-05-02 Thread Shreenidhi Shedi
@pmatilai thanks for all the inputs. I have tried addressing all of them. Please let me know if I have missed anything. @ffesti thank you for reviewing my earlier PR. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3072#issuecomment-20907

Re: [Rpm-maint] [rpm-software-management/rpm] Cleanups and improvements in tests/rpmpgppubkeyfingerprint.c (PR #3072)

2024-05-02 Thread Shreenidhi Shedi
@sshedi pushed 8 commits. e2938095b9f376e58397acceb8d3c5185928c58c rpmpgppubkeyfingerprint.c: use rpmGetCwd 3577dc5c43c912d613fff3ac9df21a41ca0c746c rpmpgppubkeyfingerprint.c: use static buffer instead of malloc a034d6c8d31caf1bf6b47ca3aa5d1d48f67341e2 rpmpgppubkeyfingerprint.c: move variabl

Re: [Rpm-maint] [rpm-software-management/rpm] Cleanups and improvements in tests/rpmpgppubkeyfingerprint.c (PR #3072)

2024-05-02 Thread Neal H. Walfield
I've taken a look at this MR, and it's basically churn. Some of the changes are coding style, and some are opinionated, and some are weird, like having `#define LEN 102400 // 100 * 1024`. If I have a vote, this is a nack from me. -- Reply to this email directly or view it on GitHub: https://g

Re: [Rpm-maint] [rpm-software-management/rpm] Cleanups and improvements in tests/rpmpgppubkeyfingerprint.c (PR #3072)

2024-05-02 Thread Shreenidhi Shedi
@nwalfield Thanks for reviewing. > and some are weird, like having #define LEN 102400 // 100 * 1024 It would help me understand things better if you explain a bit on why it is weird. My intent behind the change is, why calculate something on every run which can be used directly? I'm completely

[Rpm-maint] [rpm-software-management/rpm] sysusers.d support applies %attr() ownership before creating sysusers (Issue #3073)

2024-05-02 Thread Martin Pitt
We are currently [trying to move our project to systemd-sysusers](https://github.com/cockpit-project/cockpit/pull/20365), away from manual `useradd` calls in the package's `%pre` script. The [rpm manual](https://rpm-software-management.github.io/rpm/manual/users_and_groups.html) claims > Rpm

Re: [Rpm-maint] [rpm-software-management/rpm] Automatically create users and groups from sysusers.d(5) files (PR #2432)

2024-05-02 Thread Martin Pitt
This helped a lot, but it's still applying the user creation and `%attr()` processing in the wrong order. I filed issue #3073 about it. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2432#issuecomment-2092096531 You are receiving this be

Re: [Rpm-maint] [rpm-software-management/rpm] sysusers.d support applies %attr() ownership before creating sysusers (Issue #3073)

2024-05-02 Thread Florian Festi
A far as I know this feature is not enabled in Fedora 40. See https://fedoraproject.org/wiki/Changes/RPM-4.19#Scope rpm-4.18.92-disable-sysusers.patch ``` iff -up rpm-4.18.92/macros.in.orig rpm-4.18.92/macros.in --- rpm-4.18.92/macros.in.orig 2023-08-02 17:56:49.858065935