Re: [Rpm-maint] [rpm-software-management/rpm] Document fs-verity integration and plugin usage (Issue #1849)

2023-01-10 Thread Eric Biggers
RPM's support for fsverity seems to be based around the idea that fsverity builtin signatures are being used. (RPM calls them simply "fsverity signatures", which is a bit misleading as it's not the only way to have signatures for fsverity files.) The builtin signatures have some problems and

Re: [Rpm-maint] [rpm-software-management/rpm] rpm-4.18.0 embeds build machine CPU count (Issue #2343)

2023-01-10 Thread Panu Matilainen
Right. This is very similar to the LTO case (7faf8eda1358f8a877b9b3d6e1197b814e80b50b), with probably a similar solution. The simple and sane solution is to have _smp_mflags expand to `-j${RPM_BUILD_NCPUS}` Which ... we already did for slightly different reasons, but apparently I completely f

Re: [Rpm-maint] [rpm-software-management/rpm] Define a macro if it is not defined (Discussion #2342)

2023-01-10 Thread Panu Matilainen
`%global` itself expands to empty, not the defined value. Eg. ``` [pmatilai🎩︎localhost ~]$ rpm --eval "%global major 22" [pmatilai🎩︎localhost ~]$ rpm --eval "%global major 22" --eval "%{major}" 22 ``` -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-manag

Re: [Rpm-maint] [rpm-software-management/rpm] Generate Python egg-info from automake builds (4.18.x) (PR #2341)

2023-01-10 Thread Panu Matilainen
My sentiments exactly... -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2341#issuecomment-1376944404 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Generate Python egg-info from automake builds (4.18.x) (PR #2341)

2023-01-10 Thread Panu Matilainen
Merged #2341 into rpm-4.18.x. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2341#event-8189707070 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint m

Re: [Rpm-maint] [rpm-software-management/rpm] Generate Python egg-info from automake builds (4.18.x) (PR #2341)

2023-01-10 Thread Panu Matilainen
Just noting that this will need a mention in the release notes when the time comes: the setup.py build is not compatible with Python >= 3.12 -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2341#issuecomment-1376991436 You are receiving th

Re: [Rpm-maint] [rpm-software-management/rpm] rpmsign: Adopting PKCS#11 opaque keys support in libfsverity for fsverity signatures (#1779)

2023-01-10 Thread Florian Festi
Closed #1779. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1779#event-8190518803 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-

Re: [Rpm-maint] [rpm-software-management/rpm] rpmsign: Adopting PKCS#11 opaque keys support in libfsverity for fsverity signatures (#1779)

2023-01-10 Thread Florian Festi
Our new year's resolution is to not let PR linger for years. So we are closing all the old ones. This does not mean this PR is rejected. Please feel free to reopen if there are any news. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/17

Re: [Rpm-maint] [rpm-software-management/rpm] Implement simple macro objects (PR #1826)

2023-01-10 Thread Florian Festi
Closed #1826. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1826#event-8190522882 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-

Re: [Rpm-maint] [rpm-software-management/rpm] Implement simple macro objects (PR #1826)

2023-01-10 Thread Florian Festi
Our new year's resolution is to not let PR linger for years. So we are closing all the old ones. This does not mean this PR is rejected. Please feel free to reopen if there are any news. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/18

Re: [Rpm-maint] [rpm-software-management/rpm] Implement %foreach builtin to iterate over arguments (PR #1828)

2023-01-10 Thread Florian Festi
Our new year's resolution is to not let PR linger for years. So we are closing all the old ones. This does not mean this PR is rejected. Please feel free to reopen if there are any news. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/18

Re: [Rpm-maint] [rpm-software-management/rpm] Implement %foreach builtin to iterate over arguments (PR #1828)

2023-01-10 Thread Florian Festi
Closed #1828. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1828#event-8190525193 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-

Re: [Rpm-maint] [rpm-software-management/rpm] Fix silent wait when missing input RPM package (PR #2326)

2023-01-10 Thread Florian Festi
Merged #2326 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2326#event-8190550640 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint maili

Re: [Rpm-maint] [rpm-software-management/rpm] fix issue 2335:space handling in %setup (PR #2338)

2023-01-10 Thread Florian Festi
This looks like it is leaking memory in `fn`. Why not just add the `'` in the `rpmExpand` call. This change also could use a test case -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2338#issuecomment-1377065964 You are receiving this be

Re: [Rpm-maint] [rpm-software-management/rpm] revise ISANAME for loongarch (PR #2336)

2023-01-10 Thread Florian Festi
Please rebase onto current master. The commit message needs an explanation on why the name change is needed and why the new name is more correct than the old one. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2336#issuecomment-13770746

Re: [Rpm-maint] [rpm-software-management/rpm] Fix silent wait when missing input RPM package (PR #2326)

2023-01-10 Thread yangchenguang
#2210 -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2326#issuecomment-1377079961 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-m

Re: [Rpm-maint] [rpm-software-management/rpm] Add --generate-subpackages to find_lang.sh (PR #2300)

2023-01-10 Thread Florian Festi
Merging the different variant into one package should be easy. But I am still looking for a way to get the human readable name for that. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2300#issuecomment-1377274088 You are receiving this b

Re: [Rpm-maint] [rpm-software-management/rpm] rpm-4.18.0 embeds build machine CPU count (Issue #2343)

2023-01-10 Thread Bernhard M. Wiedemann
I tried ```diff === --- rpm-4.18.0.orig/platform.in +++ rpm-4.18.0/platform.in @@ -57,7 +57,7 @@ if [ -n "$ncpus_max" ] && [ "$ncpus_max" -gt 0 ] && [ "$RPM_BUILD_NCPUS" -gt "$ncpus_max" ]; then RPM_BUILD_NCPUS="$ncpus_max";

Re: [Rpm-maint] [rpm-software-management/rpm] fix issue 2335:space handling in %setup (PR #2338)

2023-01-10 Thread wangpeng
@wangp-h pushed 1 commit. fc50800209a2f6feb92692236d517649fb75ad20 fix leaking memory -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/2338/files/d133dd5f64812841a2acc1c0b0629076e73d359e..fc50800209a2f6feb92692236d517649fb75ad20 You are receiving this because you are su

Re: [Rpm-maint] [rpm-software-management/rpm] fix issue 2335:space handling in %setup (PR #2338)

2023-01-10 Thread wangpeng
Closed #2338. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2338#event-8197250942 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-

Re: [Rpm-maint] [rpm-software-management/rpm] fix issue 2335:space handling in %setup (PR #2338)

2023-01-10 Thread wangpeng
> This looks like it is leaking memory in `fn`. Why not just add the `'` in the > `rpmExpand` call. > > This change also could use a test case Edit: Sorry, just seen that it is in a > separate PR. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-managemen

Re: [Rpm-maint] [rpm-software-management/rpm] fix issue 2335:space handling in %setup (PR #2338)

2023-01-10 Thread wangpeng
Reopened #2338. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2338#event-8197252022 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rp

Re: [Rpm-maint] [rpm-software-management/rpm] revise ISANAME for loongarch (PR #2336)

2023-01-10 Thread zhangwenlong
> Please rebase onto current master. > > The commit message needs an explanation on why the name change is needed and > why the new name is more correct than the old one. loongarch is the architecture name, loongarch64 is only used to distinguish between 64-bit and 32-bit infrastructure -- Re

[Rpm-maint] [rpm-software-management/rpm] Determine %_smp_mflags at build time (PR #2344)

2023-01-10 Thread Bernhard M. Wiedemann
This cherry-picks 3 commits from master to not embed the build machine CPU core count into .src.rpms Fixes #2343 You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/2344 -- Commit Summary -- * Calculate number of threads to us

Re: [Rpm-maint] [rpm-software-management/rpm] rpm-4.18.0 embeds build machine CPU count (Issue #2343)

2023-01-10 Thread Bernhard M. Wiedemann
I checked git log and found some related commits. #2344 now does the trick for me. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2343#issuecomment-1378203226 You are receiving this because you are subscribed to this thread. Message ID

Re: [Rpm-maint] [rpm-software-management/rpm] WIP: Determine %_smp_mflags at build time (PR #2344)

2023-01-10 Thread Bernhard M. Wiedemann
Something is still not right here. `/usr/lib/rpm/platform/x86_64-linux/macros` has ``` %_smp_mflags -j%{_smp_build_ncpus} ``` that still gets expanded into .src.rpm -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2344#issuecomment-137820