Merged #3243 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3243#event-13972177561
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint mail
It also was a bit hairy at places :smile: Thanks for eyeballing!
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3243#issuecomment-2303913185
You are receiving this because you are subscribed to this thread.
Message ID:
...and changed to only initialize file actions if actually there, it's not that
much more code and somehow seems more right anyhow.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3241#issuecomment-2303878035
You are receiving this becaus
@pmatilai pushed 1 commit.
0ac099ae489583f1a02a1f648346951abee36512 Add rpm.spawn() Lua API
--
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3241/files/e832a71b8043f5d8217cea6366d61ad89d6ba5a3..0ac099ae489583f1a02a1f648346951abee36512
You are receiving this because you
Rebased to sort out the conflict.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3241#issuecomment-2303865230
You are receiving this because you are subscribed to this thread.
Message ID: ___
R
@pmatilai pushed 1 commit.
e832a71b8043f5d8217cea6366d61ad89d6ba5a3 Add rpm.spawn() Lua API
--
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3241/files/52938a9d4825a659710d545482baf160480dcd99..e832a71b8043f5d8217cea6366d61ad89d6ba5a3
You are receiving this because you
@pmatilai commented on this pull request.
> +
+ spawn({command} [, {actions}])
+
+Spawn, aka execute, an external program. (rpm >= 4.20)
+
+`{command}` is a table consisting of the command and its arguments.
+An optional second table can be used to pass various actions related
+to the comman
@pmatilai commented on this pull request.
> +
+ spawn({command} [, {actions}])
+
+Spawn, aka execute, an external program. (rpm >= 4.20)
+
+`{command}` is a table consisting of the command and its arguments.
+An optional second table can be used to pass various actions related
+to the comman
I came across
https://github.com/microsoft/rpmoci/blob/47443c4312505222460dfcd185308db7153897bb/src/lockfile/build.rs#L173
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2219#issuecomment-2303007254
You are receiving this because you a
@dmnks commented on this pull request.
> +
+ spawn({command} [, {actions}])
+
+Spawn, aka execute, an external program. (rpm >= 4.20)
+
+`{command}` is a table consisting of the command and its arguments.
+An optional second table can be used to pass various actions related
+to the command e
It just occurred to me that another possibility could be defining
build-in-place as to override the main %prep section, but allow appended
sections to be executed as normal for other actions. This would probably help
share a spec between a "normal" and in-place build. For example:
```
%prep
%au
@DaanDeMeyer commented on this pull request.
LGTM
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3255#pullrequestreview-2251025306
You are receiving this because you are subscribed to this thread.
Message ID: _
What a funny issue :smile:
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3254#issuecomment-2302142596
You are receiving this because you are subscribed to this thread.
Message ID: ___
Rpm-mai
Closed #3242 as completed via 826cbb8869e7d640fe3c2582a3a8dacf393e1ee0.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/3242#event-13961066571
You are receiving this because you are subscribed to this thread.
Message ID:
__
Closed #3242 as completed via #3254.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/3242#event-13961066546
You are receiving this because you are subscribed to this thread.
Message ID:
___
R
Merged #3254 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3254#event-13961066223
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint mail
> I can make that work I think.
That'd be good news, because with implied --noprep semantics (#3255), I can
finally see some light at the end of this tunnel :smile:
It's of course possible I'm missing something here, not being an active user of
--build-in-place myself. So if you have questions
Defining in-place builds to skip %prep suddenly makes this feature start
looking supportable, because it's no longer ambiguous every which way:
%setup is supposed to have all manner of side-effects that in-place builds
would skip, including cd'ing to %buildsubdir. It's not possible for
calling
> So this issue is really at the heart of the problem with --build-in-place.
>
> Working on #3216 (see PR #3252) kinda convinced me that --build-in-place
> should probably _imply_ skipping %prep, because that actually offers a way to
> make sense out of this all. For an in-place build, it's not
Fixed upstream via #3254. Please note, however, that we're not planning on
backporting this to the 4.18.x branch.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/3242#issuecomment-2302059205
You are receiving this because you are subscr
Fixes: #3242
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/3254
-- Commit Summary --
* Fix -V option usage in our tests
* Add a test for -qa with positional args
-- File Changes --
M tests/rpmdb.at (22)
M tests
Merged #3253 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3253#event-13960059151
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint mail
So this issue is really at the heart of the problem with --build-in-place.
Working on #3216 (see PR #3252) kinda convinced me that --build-in-place
should probably *imply* skipping %prep, because that actually offers a way to
make sense out of this all. For an in-place build, it's not enough to
Argh, commit 2931cbd7b1281395d18ff88e40e024659b4cfbf5 forgot to remove the
redirect. This new combo also evoked new tricks: now the entire stderr output
goes missing sometimes.
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/3
In rpm >= 4.20 we always have to have the build directory. Commit
c74ab58f081937eefd0f79af8d0310495d321864 linked its creation to --noprep but
that was under the assumption of normal builds where %prep has already been
executed, and we're re-entering the already created directory structure for
> Oh, I somehow didn't mention the most important part: The reason you're
> hitting this is most likely because you've configured rpm to use the `ndb`
> backend (instead of the default `sqlite`). With the former set, this is
> easily reproducible.
Thank you for your reply. Yes, I am using the n
Merged #3251 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3251#event-13958657942
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint mail
Turns out it's not just the two fork-related tests mentioned in commit
2931cbd7b1281395d18ff88e40e024659b4cfbf5 that are unreliable, it's the
bash-specific >() subshell redirect that causes those unexpected extra
newlines moving around in the test-suite, and here are two more tests that
occasio
Oh, I somehow didn't mention the most important part: The reason you're hitting
this is most likely because you've configured rpm to use the `ndb` backend
(instead of the default `sqlite`). With the former set, this is easily
reproducible.
--
Reply to this email directly or view it on GitHub:
OK, after looking into this more w/ @pmatilai, this turns out to be a test bug
(obligatory
[meme](https://programmerhumor.io/wp-content/uploads/2023/07/programmerhumor-io-testing-memes-debugging-memes-c242cb2722b41c1.jpg),
thanks @pmatilai for sharing).
The culprit is that the tests use the `-a
Thanks for the reports + reproducers!
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/3249#issuecomment-2301471506
You are receiving this because you are subscribed to this thread.
Message ID: ___
Closed #3244 as completed via 7f3488604f469f9cc99cce9cc9d36114cf8543f0.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/3244#event-13956088784
You are receiving this because you are subscribed to this thread.
Message ID:
__
Closed #3244 as completed via #3245.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/3244#event-13956088734
You are receiving this because you are subscribed to this thread.
Message ID:
___
R
Merged #3245 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3245#event-13956088497
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint mail
34 matches
Mail list logo
