Re: [Rpm-maint] [rpm-software-management/rpm] fix some resource leaks when running rpmbuild or rpm2cpio (PR #2293)

2022-11-25 Thread xujing
@JetXujing pushed 1 commit. 9b55215c72a5e6209d530d9bf237c0c5e015febc fix *sbp leak when running rpmbuild with --quiet -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/2293/files/3986afaef7859503da09f942cfcb89d775fb8307..9b55215c72a5e6209d530d9bf237c0c5e015febc You are

Re: [Rpm-maint] [rpm-software-management/rpm] fix some resource leaks when running rpmbuild or rpm2cpio (PR #2293)

2022-11-25 Thread xujing
@JetXujing pushed 1 commit. 5a8297fbc57cf74537e0821e58560434ea1e43ad fix *sbp leak when running rpmbuild with --quiet -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/2293/files/d7a90cad20c6a651c36f4201079124067b04d6b9..5a8297fbc57cf74537e0821e58560434ea1e43ad You are

Re: [Rpm-maint] [rpm-software-management/rpm] Add CI job for the rpm-sequoia backend (Issue #2065)

2022-11-25 Thread Fabio Valentini
Yeah, I submitted builds for rpm-sequoia to stable branches as well to make testing / CI easier. :) Hope it helps. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2065#issuecomment-1327728276 You are receiving this because you are subsc

[Rpm-maint] [rpm-software-management/rpm] Glob special files only once, internally (PR #2297)

2022-11-25 Thread Michal Domonkos
Fixes: #1294 You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/2297 -- Commit Summary -- * Glob special files only once, internally * Refactor processSpecialDir() -- File Changes -- M build/files.c (68) M tests/dat

[Rpm-maint] [rpm-software-management/rpm] to check pandoc (PR #2296)

2022-11-25 Thread kklionz
Hi, ``PANDOC`` is required to build manual and It shall be checked. This PR is to check ``PANDOC`` in ```CMakeList.txt```. Could U help to review it? Thanks You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/2296 -- C

Re: [Rpm-maint] [rpm-software-management/rpm] rpm install failed:error: unpacking of archive failed on file /usr/sbin/aaa;636c6826: cpio: open failed - No such file or directory (Issue #2273)

2022-11-25 Thread Panu Matilainen
Interesting case, thanks for reporting and the reproducer! -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2273#issuecomment-1327472411 You are receiving this because you are subscribed to this thread. Message ID: __

Re: [Rpm-maint] [rpm-software-management/rpm] Add CI job for the rpm-sequoia backend (Issue #2065)

2022-11-25 Thread Panu Matilainen
Seems decathorpe made rpm-sequoia available even on F36, but as F37 was recently released I just updated our CI to that in #2295. rpm-sequoia 1.2.0 was submitted to F37 stable updates a moment ago and I've verified that the test-suite passes with that, so we should be able to swap to this next w

Re: [Rpm-maint] [rpm-software-management/rpm] Bump CI to Fedora 37 (PR #2295)

2022-11-25 Thread Panu Matilainen
Merged #2295 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2295#event-7892537353 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint maili

[Rpm-maint] [rpm-software-management/rpm] Bump CI to Fedora 37 (PR #2295)

2022-11-25 Thread Panu Matilainen
After being stuck on an EOL Fedora for so long, it's nice to be on the leading edge for a change. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/2295 -- Commit Summary -- * Bump CI to Fedora 37 -- File Changes -- M c

Re: [Rpm-maint] [rpm-software-management/rpm] fix some resource leaks when running rpmbuild or rpm2cpio (PR #2293)

2022-11-25 Thread xujing
> > "emsg" is leaked in some cases when running rpmbuild, because "emsg" > > may be alloced and be set when checkDep returns RPMRC_OK. > > If emsg is allocated when checkDep() returns without an error, then perhaps > _that_ should be fixed instead I think. What's the case where that happens, I >

[Rpm-maint] [rpm-software-management/rpm] openssl backend uses deprecated openssl APIs (Issue #2294)

2022-11-25 Thread Panu Matilainen
At least the following: ``` /home/pmatilai/repos/rpm/rpmio/digest_openssl.c: In function ‘constructRSASigningKey’: /home/pmatilai/repos/rpm/rpmio/digest_openssl.c:197:5: error: ‘RSA_new’ is deprecated: Since OpenSSL 3.0 [-Werror=deprecated-declarations] 197 | RSA *rsa = RSA_new(); |

Re: [Rpm-maint] [rpm-software-management/rpm] fix some resource leaks when running rpmbuild or rpm2cpio (PR #2293)

2022-11-25 Thread Panu Matilainen
> "emsg" is leaked in some cases when running rpmbuild, because "emsg" may be alloced and be set when checkDep returns RPMRC_OK. If emsg is allocated when checkDep() returns without an error, then *that* should be fixed instead I think. What's the case where that happens, I didn't see anything i

Re: [Rpm-maint] [rpm-software-management/rpm] Add rpm-sort utility for sorting RPM versions (PR #2249)

2022-11-25 Thread Florian Festi
Could not quite bring myself to just say no. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2249#issuecomment-1327216695 You are receiving this because you are subscribed to this thread. Message ID: __

Re: [Rpm-maint] [rpm-software-management/rpm] Add rpm-sort utility for sorting RPM versions (PR #2249)

2022-11-25 Thread Florian Festi
Merged #2249 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2249#event-7891355010 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint maili

Re: [Rpm-maint] [rpm-software-management/rpm] Make test-suite a boolean option with explicit dependencies (PR #2292)

2022-11-25 Thread Florian Festi
Merged #2292 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2292#event-7891320781 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint maili

Re: [Rpm-maint] [rpm-software-management/rpm] check target is not generated when fakechroot is not installed (Issue #2288)

2022-11-25 Thread Florian Festi
Closed #2288 as completed via #2292. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2288#event-7891320894 You are receiving this because you are subscribed to this thread. Message ID: ___ Rp

[Rpm-maint] [rpm-software-management/rpm] fix some resource leaks when running rpmbuild or rpm2cpio (PR #2293)

2022-11-25 Thread xujing
fix some resource leaks in some cases when running rpmbuild or rpm2cpio. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/2293 -- Commit Summary -- * fix BANames leak in handlePreambleTag * fix emsg leak in parseRCPOT * f

Re: [Rpm-maint] [rpm-software-management/rpm] Also make the ci target a boolean option with explicit dependencies (55d9f24)

2022-11-25 Thread Panu Matilainen
Oops. Too many edits syndrome, thanks for spotting. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/commit/55d9f24e6b02d72f2358a5d7cb7ca16127ae7fb7#r91037975 You are receiving this because you are subscribed to this thread. Message ID: __

Re: [Rpm-maint] [rpm-software-management/rpm] Also make the ci target a boolean option with explicit dependencies (55d9f24)

2022-11-25 Thread Neal H. Walfield
is set up*.* *Y*ou -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/commit/55d9f24e6b02d72f2358a5d7cb7ca16127ae7fb7#r91037856 You are receiving this because you are subscribed to this thread. Message ID: __

Re: [Rpm-maint] [rpm-software-management/rpm] Also make the ci target a boolean option with explicit dependencies (55d9f24)

2022-11-25 Thread Neal H. Walfield
executing -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/commit/55d9f24e6b02d72f2358a5d7cb7ca16127ae7fb7#r91037824 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [Rpm-maint] [rpm-software-management/rpm] Make test-suite a boolean option with explicit dependencies (PR #2292)

2022-11-25 Thread Panu Matilainen
@pmatilai pushed 1 commit. 55d9f24e6b02d72f2358a5d7cb7ca16127ae7fb7 Also make the ci target a boolean option with explicit dependencies -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/2292/files/821bd6c271d99b37391398ce8577da5c29f9ec9c..55d9f24e6b02d72f2358a5d7cb7ca16

[Rpm-maint] [rpm-software-management/rpm] Make test-suite a boolean option with explicit dependencies (PR #2292)

2022-11-25 Thread Panu Matilainen
Silently skipping the "check" target generation if one or more of its dependencies are missing is unobvious and inconsistent with how other optional dependencies are handled. Add an option to disable the tests-suite and make it's dependencies explicit. Fixes: #2288 You can view, comment on, or

Re: [Rpm-maint] [rpm-software-management/rpm] Decouple fakechroot existence testing from check target generation (PR #2291)

2022-11-25 Thread Panu Matilainen
Closed #2291. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2291#event-7890900132 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-

Re: [Rpm-maint] [rpm-software-management/rpm] Decouple fakechroot existence testing from check target generation (PR #2291)

2022-11-25 Thread Panu Matilainen
Hmm, on a second thought, a better way to handle this is to just make the test-suite a cmake option, just like our other optional bits with extra dependencies. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2291#issuecomment-1327153787

[Rpm-maint] [rpm-software-management/rpm] Decouple fakechroot existence testing from check target generation (PR #2291)

2022-11-25 Thread Panu Matilainen
fakechroot is not required for generating the tests, only for executing them. Thus it makes more sense to test for it at "make check" time. Don't bother with find_program() here, the testsuite isn't using that anyway, it simply assumes a command called "fakechroot" exists in the users path and