Re: [Rpm-maint] [rpm-software-management/rpm] Fix some resource leaks during installation (PR #2289)

2022-11-24 Thread Panu Matilainen
Merged manually to tweak the commit messages a little bit, primarily to capitalize sentences. Thanks a lot for the patches! While we do check for memory leaks every now and then, clearly nobody has done so for src.rpm installations in a long, long time if ever. -- Reply to this email directly

Re: [Rpm-maint] [rpm-software-management/rpm] Fix some resource leaks during installation (PR #2289)

2022-11-24 Thread Panu Matilainen
Closed #2289. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2289#event-7890662487 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-

Re: [Rpm-maint] [rpm-software-management/rpm] Emit a warning when creating OpenPGP v3 signatures (Issue #2286)

2022-11-24 Thread Florian Festi
Closed #2286 as completed via #2287. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2286#event-7890654619 You are receiving this because you are subscribed to this thread. Message ID: ___ Rp

Re: [Rpm-maint] [rpm-software-management/rpm] Issue a warning when signing created an OpenPGP v3 signature (PR #2287)

2022-11-24 Thread Florian Festi
Merged #2287 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2287#event-7890654539 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint maili

Re: [Rpm-maint] [rpm-software-management/rpm] Fix some resource leaks during installation (PR #2289)

2022-11-24 Thread xujing
@JetXujing commented on this pull request. > @@ -241,6 +241,8 @@ Header headerFree(Header h) } h->index = _free(h->index); } +if (h->blob) Thank you for your comments. I've made changes. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-soft

Re: [Rpm-maint] [rpm-software-management/rpm] Fix some resource leaks during installation (PR #2289)

2022-11-24 Thread xujing
> You can't reference some local files in the commit message ([fix file leak > when install src rpm which is > URL](https://github.com/rpm-software-management/rpm/pull/2289/commits/3938cefacedbfd1ae40ff356c9d8d43e173da902)). > You need to include the content if it is appropriate. Or describe the

Re: [Rpm-maint] [rpm-software-management/rpm] Fix some resource leaks during installation (PR #2289)

2022-11-24 Thread xujing
@JetXujing pushed 2 commits. 310bad24176e0213af7e5333de491abb1c3a5e81 fix file leak when src rpm in URL format is used for installation b70d28c65e88afe96f4ce6085aa476e4d173f826 fix h->blob leak when install src rpm -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/2289

Re: [Rpm-maint] [rpm-software-management/rpm] Fix some resource leaks during installation (PR #2289)

2022-11-24 Thread Panu Matilainen
@pmatilai commented on this pull request. > @@ -241,6 +241,8 @@ Header headerFree(Header h) } h->index = _free(h->index); } +if (h->blob) Don't bother checking for non-NULL, free() does it anyway. -- Reply to this email directly or view it on GitHub: https://github.co

Re: [Rpm-maint] [rpm-software-management/rpm] Fix some resource leaks during installation (PR #2289)

2022-11-24 Thread Florian Festi
You can't reference some local files in the commit message ([fix file leak when install src rpm which is URL](https://github.com/rpm-software-management/rpm/pull/2289/commits/3938cefacedbfd1ae40ff356c9d8d43e173da902)). You need to include the content if it is appropriate. Or describe the issue.

Re: [Rpm-maint] [rpm-software-management/rpm] fix some leaks in rpmInstall (PR #2289)

2022-11-24 Thread xujing
@JetXujing pushed 2 commits. 3938cefacedbfd1ae40ff356c9d8d43e173da902 fix file leak when install src rpm which is URL 374adb562e29c1ad736e39e07dd859decb0cd5e9 fix h->blob leak when install src rpm -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/2289/files/1e973b50274

Re: [Rpm-maint] [rpm-software-management/rpm] Missing test cases for v3 openpg signatures (Issue #2276)

2022-11-24 Thread Panu Matilainen
Closed #2276 as completed via #2290. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2276#event-7884763690 You are receiving this because you are subscribed to this thread. Message ID: ___ Rp

Re: [Rpm-maint] [rpm-software-management/rpm] Add some basic tests for OpenPGP v3 signatures (PR #2290)

2022-11-24 Thread Panu Matilainen
Merged #2290 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2290#event-7884763514 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint maili

Re: [Rpm-maint] [rpm-software-management/rpm] Add some basic tests for OpenPGP v3 signatures (PR #2290)

2022-11-24 Thread Neal H. Walfield
@nwalfield approved this pull request. Looks good! ``` [neal@fedora-36 _build]$ git describe rpm-4.17.0-alpha-688-g9f3d9aa8c [neal@fedora-36 _build]$ make check ... 263: rpmkeys -K verifylevel ok 266: rpmkeys -Kv 1ok 265: rpmkeys -K verifylevel

Re: [Rpm-maint] [rpm-software-management/rpm] Add some basic tests for OpenPGP v3 signatures (PR #2290)

2022-11-24 Thread Neal H. Walfield
@nwalfield commented on this pull request. > @@ -740,9 +770,44 @@ runroot rpmkeys -Kv /tmp/${pkg} ], []) AT_CLEANUP + +# -- +# Test pre-built corrupted package verification (corrupted header) Great addition! -- Reply to this email directly or view it on GitHub:

[Rpm-maint] [rpm-software-management/rpm] Add some basic tests for OpenPGP v3 signatures (PR #2290)

2022-11-24 Thread Panu Matilainen
Wider exposure of the Sequoia backend taught us that OpenPGP v3 signatures are surprisingly common still in the rpm-ecosystem, and in fact more common than v4 signatures. It's a bit surprising, considering that gnupg has defaulted to creating v4 signatures since 1.4.8 from late 2007 gnupg2 refus

Re: [Rpm-maint] [rpm-software-management/rpm] Fix silent wait when missing pipeline input (PR #2235)

2022-11-24 Thread yangchenguang
Closed #2235. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2235#event-7884363590 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-

Re: [Rpm-maint] [rpm-software-management/rpm] Fix silent wait when missing pipeline input (PR #2235)

2022-11-24 Thread yangchenguang
Reopened #2235. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2235#event-7884361166 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rp