Re: [Rpm-maint] [rpm-software-management/rpm] The patch file is lost in src.rpm in some cases. (Issue #2282)

2022-11-21 Thread Panu Matilainen
This is a feature. The way the spec parser works, rpm will never see the Patch line at all, just like `#if 0` prevents a compiler from looking at what's inside. Proper packaging requires that patch and source declarations are unconditional, if conditionals are needed those need to be used when

Re: [Rpm-maint] [rpm-software-management/rpm] The patch file is lost in src.rpm in some cases. (Issue #2282)

2022-11-21 Thread Panu Matilainen
Closed #2282 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2282#event-7864741175 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint ma

[Rpm-maint] [rpm-software-management/rpm] The patch file is lost in src.rpm in some cases. (Issue #2282)

2022-11-21 Thread xujing
The spec file may contain the following information: ![image](https://user-images.githubusercontent.com/43668249/203216404-eb0ea2ea-b068-48ff-9196-c70427a71cb6.png) if "xxx" is not defined, the aaa.patch will not be packed into src.rpm. When I download the src.rpm and build in an environment wher

Re: [Rpm-maint] [rpm-software-management/rpm] Fix don't use 'rpm2archive foo.rpm | tar -x' (PR #2244)

2022-11-21 Thread yangchenguang
> This doesn't actually address #2208. It only enables the omission of `-`, and > that only works if you also supply another argument (`-n` in the above > examples), otherwise rpm2archive fails. Also, a man page update would be in > order if we change such behavior. > > What we need is to _alwa

Re: [Rpm-maint] [rpm-software-management/rpm] Fix rpm2archive to behave like rpm2cpio (by default) (Issue #2208)

2022-11-21 Thread Michal Domonkos
I'm all for making this tool consistent with rpm2cpio (or even replacing the latter as suggested), but how do we handle the current use case of getting a file written to the current directory? Do we care at all? -- Reply to this email directly or view it on GitHub: https://github.com/rpm-softwa

Re: [Rpm-maint] [rpm-software-management/rpm] Fix don't use 'rpm2archive foo.rpm | tar -x' (PR #2244)

2022-11-21 Thread Michal Domonkos
This doesn't actually address #2208. It only enables the omission of `-`, and that only works if you also supply another argument (`-n` in the above examples), otherwise rpm2archive fails. Also, a man page update would be in order if we change such behavior. What we need is to *always* print to

Re: [Rpm-maint] [rpm-software-management/rpm] Fix don't use 'rpm2archive foo.rpm | tar -x' (PR #2244)

2022-11-21 Thread Michal Domonkos
Closed #2244. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2244#event-7858093859 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-

Re: [Rpm-maint] [rpm-software-management/rpm] rpmsign: Adopting PKCS#11 opaque keys support in libfsverity for fsverity signatures (#1779)

2022-11-21 Thread Panu Matilainen
Okay this has fallen through the cracks for so long it's damn embarrassing to begin a review at this point. Sorry about that. Prefix the newly introduced cli-switches and macro names with verity_ or something, to make it clear these are only related to that whereas PKCS#11 could be relevant for

Re: [Rpm-maint] [rpm-software-management/rpm] Implement simple macro objects (PR #1826)

2022-11-21 Thread Panu Matilainen
This PR appears to just have had its first anniversary :laughing: Did you ever work up the Lua-native version further, or did you just run out of time/inspiration? The original case was also pretty much forgotten by me at least, so for reference this originates from ticket #1825 -- Reply to t