Re: [Rpm-maint] [rpm-software-management/rpm] Fix regression: -bp should check BuildRequires (PR #2271)

2022-11-16 Thread Panu Matilainen
Merged #2271 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2271#event-7830497915 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint maili

Re: [Rpm-maint] [rpm-software-management/rpm] Fix regression: -bp should check BuildRequires (PR #2271)

2022-11-16 Thread Panu Matilainen
Good, one more regression that cannot happen again. Thanks, both of you. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2271#issuecomment-1318123326 You are receiving this because you are subscribed to this thread. Message ID: __

Re: [Rpm-maint] [rpm-software-management/rpm] Fix regression: -bp should check BuildRequires (PR #2271)

2022-11-16 Thread Florian Festi
Added test case and mered the first two patches. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2271#issuecomment-1317320343 You are receiving this because you are subscribed to this thread. Message ID: __

Re: [Rpm-maint] [rpm-software-management/rpm] The time zone set by the %changelog does not take effect. (Issue #2253)

2022-11-16 Thread xujing
Thank you for your reply, based on the https://github.com/rpm-software-management/rpm/pull/739 discussion, it doesn't seem necessary to revise it. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2253#issuecomment-1316867537 You are rec

Re: [Rpm-maint] [rpm-software-management/rpm] RFE: Support creating new sub-packages after %install execution (#1222)

2022-11-16 Thread Panu Matilainen
Closed #1222 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1222#event-7822627177 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint ma

Re: [Rpm-maint] [rpm-software-management/rpm] RFE: Support creating new sub-packages after %install execution (#1222)

2022-11-16 Thread Panu Matilainen
This was implemented in #1485 -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1222#issuecomment-1316800172 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm

Re: [Rpm-maint] [rpm-software-management/rpm] Add some tests (PR #2254)

2022-11-16 Thread Panu Matilainen
Closed #2254. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2254#event-7822593007 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-

Re: [Rpm-maint] [rpm-software-management/rpm] Add some tests (PR #2254)

2022-11-16 Thread Panu Matilainen
I further tweaked this and merged manually: - noticed missing --nouser --nogroup on the verify test, which doesn't get spotted on the CI - merged the obsolete test into the group of other obsoletes Thanks for the tests! -- Reply to this email directly or view it on GitHub: https://github.com/rp

Re: [Rpm-maint] [rpm-software-management/rpm] Fix regression: -bp should check BuildRequires (PR #2271)

2022-11-16 Thread Michal Domonkos
> Yeah, sounds like a separate issue to me, if at all. We might as well declare > that the prep stage is the first one that cares about BuildRequires so if you > skip it, then they won't be checked. Maybe it would deserve a mention in the > man page? ... of course, it still *is* technically a r

Re: [Rpm-maint] [rpm-software-management/rpm] Fix regression: -bp should check BuildRequires (PR #2271)

2022-11-16 Thread Michal Domonkos
> There is an argument to be made that the BuildDependency check should also be > made when --short-circuit is given (which it is currently not (except for > prep after this patch or `-bf` before) but may be this is a separate issue. Yeah, sounds like a separate issue to me, if at all. We might

Re: [Rpm-maint] [rpm-software-management/rpm] Fix regression: -bp should check BuildRequires (PR #2271)

2022-11-16 Thread Panu Matilainen
The code looks simple enough, but this could use a test-case to prevent future regressions. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2271#issuecomment-1316758145 You are receiving this because you are subscribed to this thread. Me