Re: [Rpm-maint] [rpm-software-management/rpm] Fix regression: -bp should check BuildRequires (PR #2271)

2022-11-15 Thread Florian Festi
@ffesti pushed 1 commit. 95b14d38a131a42ef637f387b9d2fc0cf5ffe674 Fix previous patch -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/2271/files/837f8cc116043a4386cd17ad4faa207272d7296a..95b14d38a131a42ef637f387b9d2fc0cf5ffe674 You are receiving this because you are sub

Re: [Rpm-maint] [rpm-software-management/rpm] Fix regression: -bp should check BuildRequires (PR #2271)

2022-11-15 Thread Florian Festi
OK; after looking at the failing test case it's a bit more obvious that we need to treat the dependency check and the %generatebuilddependency script differently. While the forme needs to move to the case 'p'(rep) block the later needs to stay where it is at it is not needed for %prep at all. Le

Re: [Rpm-maint] [rpm-software-management/rpm] Fix regression: -bp should check BuildRequires (PR #2271)

2022-11-15 Thread Florian Festi
There are two different things to consider: When are BuildRequires checks done during the build process and whether to do it depending on what stage/subcommand are executed. Looking at https://github.com/rpm-software-management/rpm/blob/master/build/build.c#L379 and https://github.com/rpm-soft

Re: [Rpm-maint] [rpm-software-management/rpm] New User and Group handling (Discussion #2277)

2022-11-15 Thread Ludwig Nussel
In openSUSE the `user()` and `group()` provides are generated automatically if a packages has systemd sysuser files: https://build.opensuse.org/package/view_file/openSUSE:Factory/sysuser-tools/sysusers.prov https://build.opensuse.org/package/view_file/openSUSE:Factory/sysuser-tools/sysusers.att

Re: [Rpm-maint] [rpm-software-management/rpm] Add some tests (PR #2254)

2022-11-15 Thread xujing
@JetXujing commented on this pull request. > @@ -1371,3 +1371,21 @@ runroot rpm -q --whatprovides / ], []) AT_CLEANUP + +AT_SETUP([rpm -U with Obsoletes]) +AT_KEYWORDS([install]) +AT_CHECK([ +RPMDB_INIT + +runroot rpmbuild -bb --quiet /data/SPECS/test-obsoletes.spec +runroot rpm -i --nodeps -

Re: [Rpm-maint] [rpm-software-management/rpm] Add some tests (PR #2254)

2022-11-15 Thread xujing
@JetXujing pushed 1 commit. caa146ce57e85fd85161e184dff8fb232e742123 tests: add test for Obsoletes -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/2254/files/1275994c92b1cfb4831d285fc12dd2ef2aa514d3..caa146ce57e85fd85161e184dff8fb232e742123 You are receiving this becau