Re: [Rpm-maint] [rpm-software-management/rpm] RFE: Backport %bcond macro down to 4.16 and 4.17 maintanance releases (Issue #2042)

2022-09-22 Thread Miro HronĨok
> Enterprise distros of course do what they see fit. https://bugzilla.redhat.com/2129060 -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2042#issuecomment-1254936077 You are receiving this because you are subscribed to this thread. Mes

Re: [Rpm-maint] [rpm-software-management/rpm] The files are not changed during the installation or uninstallation phase (Issue #2202)

2022-09-22 Thread Panu Matilainen
That's what %ghost means: rpm will not touch it one way or the other. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2202#issuecomment-1254919849 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [Rpm-maint] [rpm-software-management/rpm] The files are not changed during the installation or uninstallation phase (Issue #2202)

2022-09-22 Thread Panu Matilainen
Closed #2202 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2202#event-7438892154 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint ma

Re: [Rpm-maint] [rpm-software-management/rpm] RFE: Backport %bcond macro down to 4.16 and 4.17 maintanance releases (Issue #2042)

2022-09-22 Thread Panu Matilainen
So this got included in 4.17.1, but as for 4.16, that fell out of upstream support with the release of 4.18, I don't see us doing more maintenance releases for that. Enterprise distros of course do what they see fit. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-s

Re: [Rpm-maint] [rpm-software-management/rpm] RFE: Backport %bcond macro down to 4.16 and 4.17 maintanance releases (Issue #2042)

2022-09-22 Thread Panu Matilainen
Closed #2042 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2042#event-7438879301 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint ma

[Rpm-maint] [rpm-software-management/rpm] The files are not changed during the installation or uninstallation phase (Issue #2202)

2022-09-22 Thread xujing
Some files are configured with %ghost and %config(noreplace) in spec. As a result, the files will not be replaced after the first installation, even if the package upgraded to a new version, which is expected. In this case, however, the new version of the file is not backed up as .rpmsave or .rp

Re: [Rpm-maint] [rpm-software-management/rpm] Add support for %preuntrans and %postuntrans scriptlets (PR #2177)

2022-09-22 Thread Michal Domonkos
> And now that we added the separate RPMSENSE flags for this, I wonder if we > shouldn't just add the corresponding RPMTRANS_FLAG_NO* disabler bits (along > with the popt glue) as well, afterall. Thoughts? On one hand, keeping the amount of disablers and CLI switches to the necessary minimum is

Re: [Rpm-maint] [rpm-software-management/rpm] Packaging a fifo with rpm 4.18rc1 seems to hang (Issue #2195)

2022-09-22 Thread Panu Matilainen
Ack, thanks for reporting! -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2195#issuecomment-1254865723 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-ma

Re: [Rpm-maint] [rpm-software-management/rpm] Add a handler for libselinux log messages (RhBug:2123719, RhBug:2050774) (PR #2201)

2022-09-22 Thread Florian Festi
But it looks so nice and sane... -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2201#issuecomment-1254855652 You are receiving this because you are subscribed to this thread. Message ID: ___ Rp

Re: [Rpm-maint] [rpm-software-management/rpm] Add support for %preuntrans and %postuntrans scriptlets (PR #2177)

2022-09-22 Thread Panu Matilainen
And now that we added the separate RPMSENSE flags for this, I wonder if we shouldn't just add the corresponding RPMTRANS_FLAG_NO* disabler bits (along with the popt glue) as well, afterall. Thoughts? -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-managemen

Re: [Rpm-maint] [rpm-software-management/rpm] Add support for %preuntrans and %postuntrans scriptlets (PR #2177)

2022-09-22 Thread Panu Matilainen
The RPMSENSE_ stuff added as a fixup to make it easier to see what exactly changed, obviously needs squashing before merge. Assuming we don't do what @ffesti suggested: take the hint and roll the stone back in front of the entrance. -- Reply to this email directly or view it on GitHub: https:/

Re: [Rpm-maint] [rpm-software-management/rpm] Add support for %preuntrans and %postuntrans scriptlets (PR #2177)

2022-09-22 Thread Panu Matilainen
@pmatilai pushed 1 commit. 684ce4d237f344c812ecadeb16cf5e5ea20fba46 fixup! Add support for %preuntrans and %postuntrans scriptlets -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/2177/files/dba138cae631316bff460538cc632cf09e2d102e..684ce4d237f344c812ecadeb16cf5e5ea20f

Re: [Rpm-maint] [rpm-software-management/rpm] Add a handler for libselinux log messages (RhBug:2123719, RhBug:2050774) (PR #2201)

2022-09-22 Thread Panu Matilainen
Don't merge for now, libselinux folks want to reconsider the matter on their side. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2201#issuecomment-1254821299 You are receiving this because you are subscribed to this thread. Message ID:

Re: [Rpm-maint] [rpm-software-management/rpm] Add support for %preuntrans and %postuntrans scriptlets (PR #2177)

2022-09-22 Thread Panu Matilainen
Hmm, except install-time scriptlet dependencies are considered "transient" but erase scriptlet dependencies are not. And to preserve that for these scriptlets, it seems we need the separate RPMSENSE_* flags for these afterall :thinking: -- Reply to this email directly or view it on GitHub: ht

Re: [Rpm-maint] [rpm-software-management/rpm] Add support for %preuntrans and %postuntrans scriptlets (PR #2177)

2022-09-22 Thread Panu Matilainen
> pkgGoalString is missing entries for PKG_PREUNTRANS and PKG_POSTUNTRANS Oh, indeed. Added now. It's quite amazing just how many places need to be touched for this crap :laughing: > Missing RPMSENSE_ flags means there is currently no way to declare > Requires(preuntrans) and Requires(postuntr

Re: [Rpm-maint] [rpm-software-management/rpm] Add support for %preuntrans and %postuntrans scriptlets (PR #2177)

2022-09-22 Thread Panu Matilainen
@pmatilai pushed 1 commit. dba138cae631316bff460538cc632cf09e2d102e Add support for %preuntrans and %postuntrans scriptlets -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/2177/files/addcde79d4493663abc63b9f7c62832faf8d7ddf..dba138cae631316bff460538cc632cf09e2d102e Yo

Re: [Rpm-maint] [rpm-software-management/rpm] Add support for %preuntrans and %postuntrans scriptlets (PR #2177)

2022-09-22 Thread Michal Domonkos
@dmnks approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2177#pullrequestreview-1116689448 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [Rpm-maint] [rpm-software-management/rpm] Add support for %preuntrans and %postuntrans scriptlets (PR #2177)

2022-09-22 Thread Michal Domonkos
> And now with some earlier fixes + additions added back for the fourth time or > something. This PR really hates me rofl Re-reviewed, looks good now, at last :partying_face: Not merging yet, as per Florian's comment above. -- Reply to this email directly or view it on GitHub: https://github.c

[Rpm-maint] [rpm-software-management/rpm] Add a handler for libselinux log messages (RhBug:2123719, RhBug:2050774) (PR #2201)

2022-09-22 Thread Panu Matilainen
libselinux logs to stderr by default, which up to now has been just fine with us. However somewhere around libselinux 3.2 it begun issuing log messages for events discovered in selinux_status_updated(). We only call that to see whether the status *was* updated behind our back and are not interes

Re: [Rpm-maint] [rpm-software-management/rpm] Add support for %preuntrans and %postuntrans scriptlets (PR #2177)

2022-09-22 Thread Florian Festi
OK, finally looking at the proper diff between my and your version: `pkgGoalString` is missing entries for `PKG_PREUNTRANS` and `PKG_POSTUNTRANS` The other differences are due to different naming, you not adding `RPMSENSE_` flags and my patch being incomplete. Missing `RPMSENSE_` flags means th