Re: Removing properties in Ripple

2011-02-09 Thread Duff OMelia
> A little git history helps. It seems you added that spec back in November, I > think > around the time we were discussing how to properly deal with the "_type" > property in #instantiate. That's hilarious! Ouch! I'm lame. Hopefully next time I'll remember to ask myself for the motivation beh

Re: Removing properties in Ripple

2011-02-09 Thread Sean Cribbs
Duff, A little git history helps. It seems you added that spec back in November, I think around the time we were discussing how to properly deal with the "_type" property in #instantiate. Without remembering too much of the original context, the question seems to be: should it silently ignore a

Re: Removing properties in Ripple

2011-02-09 Thread Duff OMelia
> I don't know the original intent but it would be nice to have > some sort of deprecated_property declaration that allows using the > data attributes and can possibly have options for migration, like > keep, delete, log or a proc that could transition it to a new > attribute. I'd also be fine doi

Re: Removing properties in Ripple

2011-02-08 Thread Adam Hunter
I am really glad you brought this up because this has bitten me many times. I don't know the original intent but it would be nice to have some sort of deprecated_property declaration that allows using the data attributes and can possibly have options for migration, like keep, delete, log or a proc

Removing properties in Ripple

2011-02-08 Thread Duff OMelia
Hi all, There's a test in ripple: describe Ripple::Document::Finders do it "should raise an exception when finding an existing document that has properties we don't know about" do @plain.raw_data = '{"non_existent_property":"whatever"}' lambda { Box.find("square") }.should raise_e