Re: Question about the source code: riak_get_fsm

2010-04-13 Thread Justin Sheehy
Hi, Marc. I understand your confusion as that code is a bit subtle. The reason this isn't a bug is that upon receiving the very first notfound in your situation, the "FailThreshold" case in the clause for notfound messages would return true -- since it would already know that it could never get

Question about the source code: riak_get_fsm

2010-04-13 Thread Marc Worrell
Hi, I was reading the source code of riak_get_fsm to see how failure is handled. I stumbled on a construction that I don't understand. In waiting_vnode_r/2 I see that: 1. on receiving an ok: there is a check if there are R ok replies 2. on receiving notfound: there is a check of there are R (ok +