Re: [Rhythmbox-devel] Patch for DAAP Plugin

2011-05-03 Thread W. Michael Petullo
>> Sorry, I'm not much of a c developer, I was just trying to be helpful >> and give you folks more info than just a complaint. Does the bug, >> ignoring my bad patch, seem legitimate? > File a bug please, yes. Am I correct to assume that you are connecting with the menu item "Music->Connect to

Re: [Rhythmbox-devel] Patch for DAAP Plugin

2011-05-03 Thread Stephen Huenneke
Bug filed (https://bugzilla.gnome.org/show_bug.cgi?id=649288). Thanks again for the help, and keep up the great work! On Tue, May 3, 2011 at 10:46 AM, Stephen Huenneke wrote: > No problem, thanks! > > On Tue, May 3, 2011 at 10:40 AM, Alexandre Rosenfeld > wrote: >> Hi Stephen, >> The patch seem

Re: [Rhythmbox-devel] Patch for DAAP Plugin

2011-05-03 Thread Stephen Huenneke
No problem, thanks! On Tue, May 3, 2011 at 10:40 AM, Alexandre Rosenfeld wrote: > Hi Stephen, > The patch seems good, not sure if it breaks something else tough (IPv6 for > instance, but the current code is already broken for that). > Can you file a bug report > in https://bugzilla.gnome.org/brow

Re: [Rhythmbox-devel] Patch for DAAP Plugin

2011-05-03 Thread Alexandre Rosenfeld
Hi Stephen, The patch seems good, not sure if it breaks something else tough (IPv6 for instance, but the current code is already broken for that). Can you file a bug report in https://bugzilla.gnome.org/browse.cgi?product=libdmapsharing with your patch? Regards, Alexandre * *

Re: [Rhythmbox-devel] Patch for DAAP Plugin

2011-05-03 Thread Stephen Huenneke
Just because I'm curious now, would this patch fix the problems you pointed out in my previous submission: diff --git a/plugins/daap/rb-daap-plugin.c b/plugins/daap/rb-daap-plugin.c index 20cc539..28a88b0 100644 --- a/plugins/daap/rb-daap-plugin.c +++ b/plugins/daap/rb-daap-plugin.c @@ -643,11 +64

Re: [Rhythmbox-devel] Patch for DAAP Plugin

2011-05-03 Thread Stephen Huenneke
Sorry, I'm not much of a c developer, I was just trying to be helpful and give you folks more info than just a complaint. Does the bug, ignoring my bad patch, seem legitimate? On May 3, 2011 7:11 AM, "Bastien Nocera" wrote: > On Mon, 2011-05-02 at 16:58 -0400, Stephen Huenneke wrote: >> >> diff --

Re: [Rhythmbox-devel] Patch for DAAP Plugin

2011-05-03 Thread Bastien Nocera
On Tue, 2011-05-03 at 07:15 -0400, Stephen Huenneke wrote: > Sorry, I'm not much of a c developer, I was just trying to be helpful > and give you folks more info than just a complaint. Does the bug, > ignoring my bad patch, seem legitimate? File a bug please, yes. > On May 3, 2011 7:11 AM, "Basti

Re: [Rhythmbox-devel] Patch for DAAP Plugin

2011-05-03 Thread Bastien Nocera
On Mon, 2011-05-02 at 16:58 -0400, Stephen Huenneke wrote: > > diff --git a/plugins/daap/rb-daap-plugin.c > b/plugins/daap/rb-daap-plugin.c > index 20cc539..fc72ac0 100644 > --- a/plugins/daap/rb-daap-plugin.c > +++ b/plugins/daap/rb-daap-plugin.c > @@ -646,6 +646,7 @@ new_daap_share_location_adde

Re: [Rhythmbox-devel] Feedback: a couple suggested features

2011-05-03 Thread Joey Dodson
Ok, well I changed all of the permissions on these files to read and write and I still can't change them. The files came from a cd that had wav files on it. So anyways, I guess I have to figure out a separate way to change tags on wav files? In that case, I guess RB is good on that feature. I could

[Rhythmbox-devel] Patch for DAAP Plugin

2011-05-03 Thread Stephen Huenneke
Hi I just upgraded my Fedora installation to FC14 and noticed that DAAP sharing seemed to be broken for me. My particular use case is a forwarded port over SSH to a non-standard DAAP port. When the DAAP plugin tires to connect to a non-standard port it seems to be giving the following error: (16