Re: [PR] [SPARK-51372] Introduce a builder pattern in TableCatalog [spark]

gengliangwang commented on code in PR #50137: URL: https://github.com/apache/spark/pull/50137#discussion_r1978118459 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableCatalog.java: ## @@ -311,4 +311,49 @@ default boolean purgeTable(Identifier ident) throw

Re: [PR] [SPARK-51372] Introduce a builder pattern in TableCatalog [spark]

cloud-fan commented on code in PR #50137: URL: https://github.com/apache/spark/pull/50137#discussion_r1978552750 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableBuilderImpl.java: ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] [SPARK-51372] Introduce a builder pattern in TableCatalog [spark]

cloud-fan commented on code in PR #50137: URL: https://github.com/apache/spark/pull/50137#discussion_r1978551802 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableBuilderImpl.java: ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] [SPARK-51372] Introduce a builder pattern in TableCatalog [spark]

cloud-fan commented on code in PR #50137: URL: https://github.com/apache/spark/pull/50137#discussion_r1978551802 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableBuilderImpl.java: ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] [SPARK-51372] Introduce a builder pattern in TableCatalog [spark]

cloud-fan commented on code in PR #50137: URL: https://github.com/apache/spark/pull/50137#discussion_r1978550542 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableCatalog.java: ## @@ -311,4 +311,49 @@ default boolean purgeTable(Identifier ident) throws U

Re: [PR] [SPARK-51372] Introduce a builder pattern in TableCatalog [spark]

szehon-ho commented on code in PR #50137: URL: https://github.com/apache/spark/pull/50137#discussion_r1978292403 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableCatalog.java: ## @@ -311,4 +311,49 @@ default boolean purgeTable(Identifier ident) throws U

Re: [PR] [SPARK-51372] Introduce a builder pattern in TableCatalog [spark]

szehon-ho commented on code in PR #50137: URL: https://github.com/apache/spark/pull/50137#discussion_r1978151420 ## sql/catalyst/src/test/scala/org/apache/spark/sql/connector/catalog/InMemoryTableCatalog.scala: ## @@ -294,6 +295,51 @@ class InMemoryTableCatalog extends BasicInM

Re: [PR] [SPARK-51372] Introduce a builder pattern in TableCatalog [spark]

szehon-ho commented on code in PR #50137: URL: https://github.com/apache/spark/pull/50137#discussion_r1978090554 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/CreateTableExec.scala: ## @@ -43,7 +43,10 @@ case class CreateTableExec( override protecte

Re: [PR] [SPARK-51372] Introduce a builder pattern in TableCatalog [spark]

gengliangwang commented on code in PR #50137: URL: https://github.com/apache/spark/pull/50137#discussion_r1978118012 ## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableCatalog.java: ## @@ -311,4 +311,49 @@ default boolean purgeTable(Identifier ident) throw