Re: [PR] Ilicmarkodb/fix string hash [spark]

2024-07-26 Thread via GitHub
stefankandic commented on code in PR #47502: URL: https://github.com/apache/spark/pull/47502#discussion_r1693220878 ## sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/HashExpressionsSuite.scala: ## @@ -620,6 +620,33 @@ class HashExpressionsSuite extends Spa

Re: [PR] Ilicmarkodb/fix string hash [spark]

2024-07-26 Thread via GitHub
stefankandic commented on code in PR #47502: URL: https://github.com/apache/spark/pull/47502#discussion_r1693213018 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/hash.scala: ## @@ -565,7 +565,15 @@ abstract class InterpretedHashFunction { case a

[PR] Ilicmarkodb/fix string hash [spark]

2024-07-26 Thread via GitHub
ilicmarkodb opened a new pull request, #47502: URL: https://github.com/apache/spark/pull/47502 ### What changes were proposed in this pull request? Changed hash function to be collation aware. ### Why are the changes needed? We were getting the wrong hash for collated str