Re: [PR] [SPARK-51482][SQL] Support cast from string to time [spark]

2025-03-12 Thread via GitHub
MaxGekk commented on PR #50236: URL: https://github.com/apache/spark/pull/50236#issuecomment-2718536341 Merging to master. Thank you, @LuciferYang @beliefer for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] [SPARK-51482][SQL] Support cast from string to time [spark]

2025-03-12 Thread via GitHub
MaxGekk closed pull request #50236: [SPARK-51482][SQL] Support cast from string to time URL: https://github.com/apache/spark/pull/50236 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] [SPARK-51482][SQL] Support cast from string to time [spark]

2025-03-12 Thread via GitHub
MaxGekk commented on code in PR #50236: URL: https://github.com/apache/spark/pull/50236#discussion_r1991652407 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala: ## @@ -1337,6 +1350,35 @@ case class Cast( } } + private[this] def castT

Re: [PR] [SPARK-51482][SQL] Support cast from string to time [spark]

2025-03-12 Thread via GitHub
LuciferYang commented on code in PR #50236: URL: https://github.com/apache/spark/pull/50236#discussion_r1991323757 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala: ## @@ -1337,6 +1350,35 @@ case class Cast( } } + private[this] def c

Re: [PR] [SPARK-51482][SQL] Support cast from string to time [spark]

2025-03-12 Thread via GitHub
MaxGekk commented on PR #50236: URL: https://github.com/apache/spark/pull/50236#issuecomment-2717411710 @yaooqinn @LuciferYang @dongjoon-hyun @HyukjinKwon Could you take a look at the PR when you have time, please. -- This is an automated message from the Apache Git Service. To respond to