Re: [PR] [SPARK-51467][UI] Make tables of the environment page filterable [spark]

2025-03-12 Thread via GitHub
yaooqinn commented on PR #50233: URL: https://github.com/apache/spark/pull/50233#issuecomment-2716542978 > The overloaded action issues might be considered later in an independent JIRA (if needed later). Thank you @dongjoon-hyun. For potential UX improvements, I'd leave it for

Re: [PR] [SPARK-51467][UI] Make tables of the environment page filterable [spark]

2025-03-11 Thread via GitHub
yaooqinn closed pull request #50233: [SPARK-51467][UI] Make tables of the environment page filterable URL: https://github.com/apache/spark/pull/50233 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [SPARK-51467][UI] Make tables of the environment page filterable [spark]

2025-03-11 Thread via GitHub
dongjoon-hyun commented on PR #50233: URL: https://github.com/apache/spark/pull/50233#issuecomment-2716363691 Oh, indeed. BTW, I realized that the method `click` has a side-effect. Whenever I clicked the header, the table sorting order is flipped like the following. https://github.

Re: [PR] [SPARK-51467][UI] Make tables of the environment page filterable [spark]

2025-03-11 Thread via GitHub
yaooqinn commented on PR #50233: URL: https://github.com/apache/spark/pull/50233#issuecomment-2716337142 It seems that you didn't click any of the `` fields, the click event will trigger both sort & filter. But I don't see a up-or-down `arrow` in your screen shot. -- This is an automated

Re: [PR] [SPARK-51467][UI] Make tables of the environment page filterable [spark]

2025-03-11 Thread via GitHub
dongjoon-hyun commented on PR #50233: URL: https://github.com/apache/spark/pull/50233#issuecomment-2716314059 Maybe, am I hitting a timing issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] [SPARK-51467][UI] Make tables of the environment page filterable [spark]

2025-03-11 Thread via GitHub
dongjoon-hyun commented on PR #50233: URL: https://github.com/apache/spark/pull/50233#issuecomment-2716312558 It's loaded like the following but `Runtime Information` didn't have the filter, @yaooqinn . https://github.com/user-attachments/assets/de7814e7-f265-434d-9362-400796d14dd6";

Re: [PR] [SPARK-51467][UI] Make tables of the environment page filterable [spark]

2025-03-11 Thread via GitHub
yaooqinn commented on PR #50233: URL: https://github.com/apache/spark/pull/50233#issuecomment-2716288827 https://github.com/user-attachments/assets/388bde03-b18a-4525-af94-c1d1701fa52e -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] [SPARK-51467][UI] Make tables of the environment page filterable [spark]

2025-03-11 Thread via GitHub
yaooqinn commented on PR #50233: URL: https://github.com/apache/spark/pull/50233#issuecomment-2716281938 To show the filter input text box, we need to click the table head, and be sure to see this file loaded @dongjoon-hyun ![image](https://github.com/user-attachments/assets/294876bc-3

Re: [PR] [SPARK-51467][UI] Make tables of the environment page filterable [spark]

2025-03-11 Thread via GitHub
dongjoon-hyun commented on PR #50233: URL: https://github.com/apache/spark/pull/50233#issuecomment-2716250511 Strangely, I was unable to verify this new changes. I tried in both Safari and Chrome with two normal and private(Incognito) modes. Is there something for me to do see this new chan

Re: [PR] [SPARK-51467][UI] Make tables of the environment page filterable [spark]

2025-03-11 Thread via GitHub
dongjoon-hyun commented on PR #50233: URL: https://github.com/apache/spark/pull/50233#issuecomment-2716229205 Let me build and verify manually too~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[PR] [SPARK-51467][UI] Make tables of the environment page filterable [spark]

2025-03-11 Thread via GitHub
yaooqinn opened a new pull request, #50233: URL: https://github.com/apache/spark/pull/50233 ### What changes were proposed in this pull request? This PR adds multi-column filtering ability to the tables of the environment page. ### Why are the changes needed?