Re: [PR] [SPARK-51183][SQL] Link to Parquet spec in Variant docs [spark]

2025-02-16 Thread via GitHub
cloud-fan closed pull request #49910: [SPARK-51183][SQL] Link to Parquet spec in Variant docs URL: https://github.com/apache/spark/pull/49910 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] [SPARK-51183][SQL] Link to Parquet spec in Variant docs [spark]

2025-02-16 Thread via GitHub
cloud-fan commented on PR #49910: URL: https://github.com/apache/spark/pull/49910#issuecomment-2661946589 thanks, merging to master/4.0! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] [SPARK-51183][SQL] Link to Parquet spec in Variant docs [spark]

2025-02-14 Thread via GitHub
dongjoon-hyun commented on PR #49910: URL: https://github.com/apache/spark/pull/49910#issuecomment-2659979822 I'm leaving this PR to the release manager's final decision, @cloud-fan . While waiting him, could you make the CI green although this is a doc-only PR, @cashmand ? -- This

Re: [PR] [SPARK-51183][SQL] Link to Parquet spec in Variant docs [spark]

2025-02-14 Thread via GitHub
cashmand commented on PR #49910: URL: https://github.com/apache/spark/pull/49910#issuecomment-2659975804 Is anything else required on this PR? If not, @dongjoon-hyun or @cloud-fan, can one of you please merge it? -- This is an automated message from the Apache Git Service. To respond to t

Re: [PR] [SPARK-51183][SQL] Link to Parquet spec in Variant docs [spark]

2025-02-13 Thread via GitHub
cashmand commented on PR #49910: URL: https://github.com/apache/spark/pull/49910#issuecomment-2656729838 Hi @dongjoon-hyun, I updated the text to clarify the current status of the project. Let me know what you think. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] [SPARK-51183][SQL] Link to Parquet spec in Variant docs [spark]

2025-02-12 Thread via GitHub
dongjoon-hyun commented on PR #49910: URL: https://github.com/apache/spark/pull/49910#issuecomment-2655512345 Ya, if we are clear that this is WIP status, there is no problem. Eventually, I hope this is revised to point to the tagged version in the future. -- This is an automated message

Re: [PR] [SPARK-51183][SQL] Link to Parquet spec in Variant docs [spark]

2025-02-12 Thread via GitHub
cloud-fan commented on PR #49910: URL: https://github.com/apache/spark/pull/49910#issuecomment-2655509547 Yea it's just a dev doc as end-users shouldn't care about it. @dongjoon-hyun What's your concern about linking to the Parquet spec? As @pan3793 said we can explain the current status i

Re: [PR] [SPARK-51183][SQL] Link to Parquet spec in Variant docs [spark]

2025-02-12 Thread via GitHub
pan3793 commented on PR #49910: URL: https://github.com/apache/spark/pull/49910#issuecomment-2655346077 > point to the (not finalized) Variant spec in Parquet (what this PR is doing) @gene-db I agree with this option. To avoid confusion, the link should point to a git-hash instead of

Re: [PR] [SPARK-51183][SQL] Link to Parquet spec in Variant docs [spark]

2025-02-12 Thread via GitHub
dongjoon-hyun commented on PR #49910: URL: https://github.com/apache/spark/pull/49910#issuecomment-2655015074 Could you send an email to the Apache Spark dev mailing list because this is the status of our previous decision, @cashmand and @gene-db ? Although we are in the out-of-sync s

Re: [PR] [SPARK-51183][SQL] Link to Parquet spec in Variant docs [spark]

2025-02-12 Thread via GitHub
gene-db commented on PR #49910: URL: https://github.com/apache/spark/pull/49910#issuecomment-2654756302 What are the possible paths forward? We are currently in the transition period, so the spec is not fully finalized in parquet. Therefore, the options are: - point to the (not finalized

Re: [PR] [SPARK-51183][SQL] Link to Parquet spec in Variant docs [spark]

2025-02-12 Thread via GitHub
dongjoon-hyun commented on PR #49910: URL: https://github.com/apache/spark/pull/49910#issuecomment-2654655635 To @gene-db , please don't get me wrong. I'm aware of all the discussion completely. :) -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] [SPARK-51183][SQL] Link to Parquet spec in Variant docs [spark]

2025-02-12 Thread via GitHub
gene-db commented on PR #49910: URL: https://github.com/apache/spark/pull/49910#issuecomment-2654602248 The Spark community had agreed to move the spec over to the parquet project, so we are currently in that process. It takes time for the spec to be formally finalized in Parquet, but it is

Re: [PR] [SPARK-51183][SQL] Link to Parquet spec in Variant docs [spark]

2025-02-12 Thread via GitHub
cashmand commented on code in PR #49910: URL: https://github.com/apache/spark/pull/49910#discussion_r1953232672 ## common/variant/README.md: ## @@ -1,379 +1 @@ -# Overview - -A Variant represents a type that contain one of: -- Primitive: A type and corresponding value (e.g. INT,

Re: [PR] [SPARK-51183][SQL] Link to Parquet spec in Variant docs [spark]

2025-02-12 Thread via GitHub
cashmand commented on PR #49910: URL: https://github.com/apache/spark/pull/49910#issuecomment-2654575098 > I'm not sure this is a better idea or not because we have no tag-based link. In addition, the pointed document shows warnings like the following. This is a downgrade in terms of the do

Re: [PR] [SPARK-51183][SQL] Link to Parquet spec in Variant docs [spark]

2025-02-12 Thread via GitHub
dongjoon-hyun commented on PR #49910: URL: https://github.com/apache/spark/pull/49910#issuecomment-2654561078 I'm not sure this is a better idea because we have no tag-based link. In addition, the pointed document shows warnings. https://github.com/user-attachments/assets/31927d48-0c

Re: [PR] [SPARK-51183][SQL] Link to Parquet spec in Variant docs [spark]

2025-02-12 Thread via GitHub
dongjoon-hyun commented on code in PR #49910: URL: https://github.com/apache/spark/pull/49910#discussion_r1953217184 ## common/variant/README.md: ## @@ -1,379 +1 @@ -# Overview - -A Variant represents a type that contain one of: -- Primitive: A type and corresponding value (e.g.

Re: [PR] [SPARK-51183][SQL] Link to Parquet spec in Variant docs [spark]

2025-02-12 Thread via GitHub
dongjoon-hyun commented on PR #49910: URL: https://github.com/apache/spark/pull/49910#issuecomment-2654542782 cc @cloud-fan , @pan3793, @gene-db -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t