zeal-thinker commented on code in PR #48554:
URL: https://github.com/apache/spark/pull/48554#discussion_r1820088697
##
sql/core/src/test/scala/org/apache/spark/sql/sources/InsertSuite.scala:
##
@@ -2731,6 +2731,27 @@ class InsertSuite extends DataSourceTest with
SharedSparkSess
huaxingao commented on code in PR #47126:
URL: https://github.com/apache/spark/pull/47126#discussion_r1820162439
##
sql/core/src/test/scala/org/apache/spark/sql/connector/KeyGroupedPartitioningSuite.scala:
##
@@ -1809,6 +1809,56 @@ class KeyGroupedPartitioningSuite extends
Dist
xunxunmimi5577 commented on code in PR #48554:
URL: https://github.com/apache/spark/pull/48554#discussion_r1820141576
##
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala:
##
@@ -1074,11 +1070,18 @@ object DDLUtils extends Logging {
query: LogicalPl
dongjoon-hyun commented on PR #48654:
URL: https://github.com/apache/spark/pull/48654#issuecomment-2443146258
Thank you for the sync-up with them, @HeartSaVioR .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
viirya commented on PR #47126:
URL: https://github.com/apache/spark/pull/47126#issuecomment-2443241928
cc @huaxingao
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
dongjoon-hyun commented on PR #42411:
URL: https://github.com/apache/spark/pull/42411#issuecomment-2443213834
Hi, @zhengruifeng , @yaooqinn , @HyukjinKwon .
Let me backport this minor commit to `branch-3.5`. :)
--
This is an automated message from the Apache Git Service.
To respond to t
anishshri-db commented on code in PR #48686:
URL: https://github.com/apache/spark/pull/48686#discussion_r1820081521
##
sql/core/src/test/scala/org/apache/spark/sql/streaming/TransformWithStateInitialStateSuite.scala:
##
@@ -83,6 +98,59 @@ abstract class StatefulProcessorWithInit
itholic opened a new pull request, #48689:
URL: https://github.com/apache/spark/pull/48689
### What changes were proposed in this pull request?
This PR proposes to assign proper error condition & sqlstate for
`_LEGACY_ERROR_TEMP_0043`: `INVALID_RESET_COMMAND_FORMAT`
itholic commented on code in PR #48651:
URL: https://github.com/apache/spark/pull/48651#discussion_r1820066066
##
python/pyspark/sql/tests/test_connect_compatibility.py:
##
@@ -60,16 +60,23 @@
from pyspark.sql.connect.streaming.readwriter import DataStreamReader as
Connect
Angryrou commented on PR #48649:
URL: https://github.com/apache/spark/pull/48649#issuecomment-2443234073
Thank you @dtenedor for the consideration suggestions! I have updated the
code accordingly and added more test cases.
--
This is an automated message from the Apache Git Service.
T
itholic commented on code in PR #48655:
URL: https://github.com/apache/spark/pull/48655#discussion_r1820087080
##
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala:
##
@@ -868,8 +868,8 @@ private[sql] object QueryExecutionErrors extends
QueryErr
zeal-thinker commented on code in PR #48554:
URL: https://github.com/apache/spark/pull/48554#discussion_r1820083908
##
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala:
##
@@ -1008,13 +1008,9 @@ object DDLUtils extends Logging {
if (!catalog.isTempVi
itholic commented on code in PR #48655:
URL: https://github.com/apache/spark/pull/48655#discussion_r1820089089
##
common/utils/src/main/resources/error/error-conditions.json:
##
@@ -5398,6 +5398,12 @@
},
"sqlState" : "42902"
},
+ "UNSUPPORTED_PARTITION_TRANSFORM" :
anishshri-db commented on code in PR #48686:
URL: https://github.com/apache/spark/pull/48686#discussion_r1820083680
##
sql/core/src/test/scala/org/apache/spark/sql/streaming/TransformWithStateInitialStateSuite.scala:
##
@@ -497,4 +573,126 @@ class TransformWithStateInitialStateS
itholic commented on code in PR #48631:
URL: https://github.com/apache/spark/pull/48631#discussion_r1820081434
##
common/utils/src/main/resources/error/error-conditions.json:
##
@@ -4628,6 +4628,12 @@
],
"sqlState" : "42K09"
},
+ "TUPLE_SIZE_EXCEEDS_LIMIT" : {
+
zeal-thinker commented on code in PR #48554:
URL: https://github.com/apache/spark/pull/48554#discussion_r1820084448
##
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala:
##
@@ -1074,11 +1070,18 @@ object DDLUtils extends Logging {
query: LogicalPlan
anishshri-db commented on PR #48686:
URL: https://github.com/apache/spark/pull/48686#issuecomment-2443207720
@jingz-db - can u check if the lint failure is related ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
dongjoon-hyun closed pull request #48683: [SPARK-49297][CORE][TESTS] Fix race
condition in BlockManagerDecommissionIntegrationSuite
URL: https://github.com/apache/spark/pull/48683
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
dongjoon-hyun commented on PR #48683:
URL: https://github.com/apache/spark/pull/48683#issuecomment-2443153867
After a minor import statement merging, I verified this manually.
```scala
- import java.nio.file.Files
- import java.nio.file.Paths
+ import java.nio.file.{Files, Paths}
Angryrou commented on code in PR #48649:
URL: https://github.com/apache/spark/pull/48649#discussion_r1820017432
##
sql/core/src/test/resources/sql-tests/inputs/pipe-operators.sql:
##
@@ -665,15 +665,28 @@ table t
table t
|> order by x sort by x;
--- The WINDOW clause is not
panbingkun opened a new pull request, #48688:
URL: https://github.com/apache/spark/pull/48688
### What changes were proposed in this pull request?
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
Yes,
### How was
LuciferYang commented on PR #48654:
URL: https://github.com/apache/spark/pull/48654#issuecomment-2443051272
> Please allow me to wait for a day to sync with folks working on this (TWS
in PySpark). I've asked them to comment and they will come in US tz. If there
is no comment in tomorrow US
Angryrou commented on code in PR #48649:
URL: https://github.com/apache/spark/pull/48649#discussion_r1820017432
##
sql/core/src/test/resources/sql-tests/inputs/pipe-operators.sql:
##
@@ -665,15 +665,28 @@ table t
table t
|> order by x sort by x;
--- The WINDOW clause is not
Angryrou commented on code in PR #48649:
URL: https://github.com/apache/spark/pull/48649#discussion_r1820017432
##
sql/core/src/test/resources/sql-tests/inputs/pipe-operators.sql:
##
@@ -665,15 +665,28 @@ table t
table t
|> order by x sort by x;
--- The WINDOW clause is not
Angryrou commented on code in PR #48649:
URL: https://github.com/apache/spark/pull/48649#discussion_r1820017432
##
sql/core/src/test/resources/sql-tests/inputs/pipe-operators.sql:
##
@@ -665,15 +665,28 @@ table t
table t
|> order by x sort by x;
--- The WINDOW clause is not
yaooqinn commented on PR #48625:
URL: https://github.com/apache/spark/pull/48625#issuecomment-2443044261
Does this approach still work when the resultset given by limit 1 is empty?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
hvanhovell opened a new pull request, #48687:
URL: https://github.com/apache/spark/pull/48687
### What changes were proposed in this pull request?
This PR makes the following changes:
- It adds shims for a couple of a number of classes exposed in the (classic)
SQL interface: `BaseRela
HeartSaVioR commented on code in PR #48373:
URL: https://github.com/apache/spark/pull/48373#discussion_r1820001517
##
python/pyspark/sql/pandas/group_ops.py:
##
@@ -503,7 +503,11 @@ def transformWithStateUDF(
statefulProcessorApiClient.set_implicit_key(key)
yaooqinn commented on code in PR #48625:
URL: https://github.com/apache/spark/pull/48625#discussion_r1819994352
##
connector/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/v2/PostgresIntegrationSuite.scala:
##
@@ -302,4 +317,22 @@ class PostgresIntegrationSuit
itholic commented on code in PR #48631:
URL: https://github.com/apache/spark/pull/48631#discussion_r1819986087
##
common/utils/src/main/resources/error/error-conditions.json:
##
@@ -4628,6 +4628,12 @@
],
"sqlState" : "42K09"
},
+ "TUPLE_SIZE_EXCEEDS_LIMIT" : {
+
HeartSaVioR commented on PR #48654:
URL: https://github.com/apache/spark/pull/48654#issuecomment-2443028368
Please allow me to wait for a day to sync with folks working on this (TWS in
PySpark). I've asked them to comment and they will come in US tz. If there is
no comment in tomorrow US tz
itholic commented on code in PR #48614:
URL: https://github.com/apache/spark/pull/48614#discussion_r1819978681
##
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala:
##
@@ -611,7 +611,7 @@ class HiveDDLSuite
)
}
- test("add/drop partitions
HeartSaVioR commented on PR #48654:
URL: https://github.com/apache/spark/pull/48654#issuecomment-2443021130
Ah OK, so the generated file is placed in target, not source directory.
Sounds good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
jingz-db commented on PR #47878:
URL: https://github.com/apache/spark/pull/47878#issuecomment-2442995781
Hey @HyukjinKwon, do we have any place that could manually escape the python
style check for certain files? Currently the linter check is only failing on
auto-generated file created by `
LuciferYang commented on PR #48654:
URL: https://github.com/apache/spark/pull/48654#issuecomment-2442942415
> Would we want to also add StateMessage.java to gitignore so that we don't
try to add the file again?
double checked:
- Maven
```
build/mvn clean install -
bogao007 commented on code in PR #48373:
URL: https://github.com/apache/spark/pull/48373#discussion_r1819945337
##
python/pyspark/sql/pandas/group_ops.py:
##
@@ -503,7 +503,11 @@ def transformWithStateUDF(
statefulProcessorApiClient.set_implicit_key(key)
bogao007 commented on code in PR #48373:
URL: https://github.com/apache/spark/pull/48373#discussion_r1819943103
##
python/pyspark/sql/pandas/group_ops.py:
##
@@ -503,7 +503,11 @@ def transformWithStateUDF(
statefulProcessorApiClient.set_implicit_key(key)
JoshRosen commented on code in PR #48661:
URL: https://github.com/apache/spark/pull/48661#discussion_r1819930126
##
sql/core/src/main/scala/org/apache/spark/sql/execution/InsertSortForLimitAndOffset.scala:
##
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (A
github-actions[bot] closed pull request #47320: [SPARK-48879][SQL] Expand the
charset list with Chinese Standard Charsets
URL: https://github.com/apache/spark/pull/47320
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
dtenedor commented on code in PR #48649:
URL: https://github.com/apache/spark/pull/48649#discussion_r1819915404
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala:
##
@@ -1037,6 +1037,11 @@ class AstBuilder extends DataTypeAstBuilder
th
panbingkun commented on PR #48155:
URL: https://github.com/apache/spark/pull/48155#issuecomment-2442920460
Thanks all @LuciferYang @dongjoon-hyun ❤️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
panbingkun commented on PR #48671:
URL: https://github.com/apache/spark/pull/48671#issuecomment-2442916619
> Let's wait for a few days until the announcement comes out.
Don't hurry, let's wait for it 😄
--
This is an automated message from the Apache Git Service.
To respond to the me
anishshri-db commented on code in PR #48686:
URL: https://github.com/apache/spark/pull/48686#discussion_r1819916471
##
sql/core/src/test/scala/org/apache/spark/sql/streaming/TransformWithStateInitialStateSuite.scala:
##
@@ -497,4 +537,85 @@ class TransformWithStateInitialStateSu
anishshri-db commented on code in PR #48686:
URL: https://github.com/apache/spark/pull/48686#discussion_r1819916257
##
sql/core/src/test/scala/org/apache/spark/sql/streaming/TransformWithStateInitialStateSuite.scala:
##
@@ -497,4 +537,85 @@ class TransformWithStateInitialStateSu
dongjoon-hyun closed pull request #48684: [SPARK-50150][BUILD][3.5] Upgrade
Jetty to 9.4.56.v20240826
URL: https://github.com/apache/spark/pull/48684
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
dongjoon-hyun closed pull request #48682: [SPARK-50149][INFRA] Update INFRA
docker image to use `jammy-20240911.1`
URL: https://github.com/apache/spark/pull/48682
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
dtenedor commented on PR #48649:
URL: https://github.com/apache/spark/pull/48649#issuecomment-2442897812
cc @cloud-fan @gengliangwang :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
dongjoon-hyun commented on PR #48682:
URL: https://github.com/apache/spark/pull/48682#issuecomment-2442897772
Thank you, @viirya !
Merged to master for Apache Spark 4.0.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
dongjoon-hyun commented on PR #48684:
URL: https://github.com/apache/spark/pull/48684#issuecomment-2442897315
Thank you, @viirya , too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
JoshRosen commented on code in PR #48661:
URL: https://github.com/apache/spark/pull/48661#discussion_r1819908756
##
sql/core/src/main/scala/org/apache/spark/sql/execution/InsertSortForLimitAndOffset.scala:
##
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (A
dongjoon-hyun commented on PR #48684:
URL: https://github.com/apache/spark/pull/48684#issuecomment-2442893861
Merged to branch-3.5.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
dongjoon-hyun commented on PR #48684:
URL: https://github.com/apache/spark/pull/48684#issuecomment-2442893713
Thank you, @attilapiros !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
JoshRosen commented on code in PR #48661:
URL: https://github.com/apache/spark/pull/48661#discussion_r1819902550
##
sql/core/src/main/scala/org/apache/spark/sql/execution/InsertSortForLimitAndOffset.scala:
##
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (A
jingz-db opened a new pull request, #48686:
URL: https://github.com/apache/spark/pull/48686
### What changes were proposed in this pull request?
+---+-+-+--++
|groupingKey|value|listValue|userMapKey|userMapValue|
+---+--
dongjoon-hyun commented on PR #48678:
URL: https://github.com/apache/spark/pull/48678#issuecomment-2442873708
Thank you, @zhengruifeng !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
zhengruifeng commented on PR #48678:
URL: https://github.com/apache/spark/pull/48678#issuecomment-2442872614
@dongjoon-hyun thanks for the review, let me add recent PRs to
[SPARK-44728](https://issues.apache.org/jira/browse/SPARK-44728)
--
This is an automated message from the Apache Git
dongjoon-hyun commented on PR #48682:
URL: https://github.com/apache/spark/pull/48682#issuecomment-2442871970
Could you review this PR, @viirya ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
dongjoon-hyun commented on PR #48684:
URL: https://github.com/apache/spark/pull/48684#issuecomment-2442872264
Could you review this PR, @viirya ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
dtenedor commented on PR #48529:
URL: https://github.com/apache/spark/pull/48529#issuecomment-2442816057
friendly ping @cloud-fan @gengliangwang :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
HeartSaVioR commented on PR #48654:
URL: https://github.com/apache/spark/pull/48654#issuecomment-2442803955
Would we want to also add StateMessage.java to gitignore so that we don't
try to add the file?
--
This is an automated message from the Apache Git Service.
To respond to the message
jingz-db commented on PR #47878:
URL: https://github.com/apache/spark/pull/47878#issuecomment-2442791970
> @jingz-db Looks like linter is still failing - have you ensured that the
master branch for your repo is up-to-date with the master branch for Apache
repo?
I do, I rebased on the
dongjoon-hyun commented on PR #48682:
URL: https://github.com/apache/spark/pull/48682#issuecomment-2442683316
Could you review this PR, @attilapiros ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
HeartSaVioR commented on PR #47878:
URL: https://github.com/apache/spark/pull/47878#issuecomment-2442699945
@jingz-db
Looks like linter is still failing - have you ensured that the master branch
for your repo is up-to-date with the master branch for Apache repo?
--
This is an automate
rebo16v commented on PR #48347:
URL: https://github.com/apache/spark/pull/48347#issuecomment-2442691411
@zhengruifeng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
rebo16v commented on code in PR #48347:
URL: https://github.com/apache/spark/pull/48347#discussion_r1819796924
##
mllib/src/test/scala/org/apache/spark/ml/feature/TargetEncoderSuite.scala:
##
@@ -0,0 +1,538 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
rebo16v commented on code in PR #48347:
URL: https://github.com/apache/spark/pull/48347#discussion_r1819795209
##
mllib/src/main/scala/org/apache/spark/ml/feature/TargetEncoder.scala:
##
@@ -0,0 +1,460 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
rebo16v commented on code in PR #48347:
URL: https://github.com/apache/spark/pull/48347#discussion_r1819796924
##
mllib/src/test/scala/org/apache/spark/ml/feature/TargetEncoderSuite.scala:
##
@@ -0,0 +1,538 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
dongjoon-hyun commented on PR #48684:
URL: https://github.com/apache/spark/pull/48684#issuecomment-2442683757
Could you review this PR, @attilapiros ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
bersprockets commented on code in PR #48661:
URL: https://github.com/apache/spark/pull/48661#discussion_r1819799634
##
sql/core/src/test/scala/org/apache/spark/sql/execution/InsertSortForLimitAndOffsetSuite.scala:
##
@@ -0,0 +1,120 @@
+/*
+ * Licensed to the Apache Software Foun
attilapiros commented on code in PR #48683:
URL: https://github.com/apache/spark/pull/48683#discussion_r1819712363
##
core/src/test/scala/org/apache/spark/storage/BlockManagerDecommissionIntegrationSuite.scala:
##
@@ -377,20 +379,22 @@ class BlockManagerDecommissionIntegrationSu
jingz-db commented on code in PR #48124:
URL: https://github.com/apache/spark/pull/48124#discussion_r1819740895
##
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/IncrementalExecution.scala:
##
@@ -425,6 +425,29 @@ class IncrementalExecution(
even
jingz-db commented on code in PR #48124:
URL: https://github.com/apache/spark/pull/48124#discussion_r1819737427
##
sql/core/src/main/scala/org/apache/spark/sql/execution/python/TransformWithStateInPandasExec.scala:
##
@@ -106,6 +107,37 @@ case class TransformWithStateInPandasExe
micheal-o opened a new pull request, #48685:
URL: https://github.com/apache/spark/pull/48685
### What changes were proposed in this pull request?
There are 2 bugs in the recently added new approach for RocksDB SST file
mapping in this PR: https://github.com/apache/spark/pull/47875
attilapiros opened a new pull request, #48683:
URL: https://github.com/apache/spark/pull/48683
### What changes were proposed in this pull request?
Fixing race condition in the test "SPARK-46957: Migrated shuffle files
should be able to cleanup from executor" of
`BlockManagerDeco
dongjoon-hyun commented on code in PR #48683:
URL: https://github.com/apache/spark/pull/48683#discussion_r1819597117
##
core/src/test/scala/org/apache/spark/storage/BlockManagerDecommissionIntegrationSuite.scala:
##
@@ -377,20 +379,22 @@ class BlockManagerDecommissionIntegration
dongjoon-hyun opened a new pull request, #48684:
URL: https://github.com/apache/spark/pull/48684
### What changes were proposed in this pull request?
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### H
dtenedor commented on code in PR #48529:
URL: https://github.com/apache/spark/pull/48529#discussion_r1819581672
##
sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4:
##
@@ -765,7 +765,7 @@ temporalClause
aggregationClause
: GROUP BY groupingExpr
dongjoon-hyun opened a new pull request, #48682:
URL: https://github.com/apache/spark/pull/48682
### What changes were proposed in this pull request?
This PR aims to update `infra` docker image to use `jammy-20240911.1`
instead of `jammy-20240227`.
### Why are the changes neede
jingz-db commented on code in PR #48373:
URL: https://github.com/apache/spark/pull/48373#discussion_r1819559837
##
sql/core/src/main/scala/org/apache/spark/sql/execution/python/TransformWithStateInPandasExec.scala:
##
@@ -106,6 +106,30 @@ case class TransformWithStateInPandasExe
jingz-db commented on code in PR #48373:
URL: https://github.com/apache/spark/pull/48373#discussion_r1819550379
##
python/pyspark/sql/pandas/group_ops.py:
##
@@ -503,7 +503,11 @@ def transformWithStateUDF(
statefulProcessorApiClient.set_implicit_key(key)
ezamyatin opened a new pull request, #48681:
URL: https://github.com/apache/spark/pull/48681
### What changes were proposed in this pull request?
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How w
dongjoon-hyun commented on PR #48671:
URL: https://github.com/apache/spark/pull/48671#issuecomment-2442249830
Let's wait for a few days until the announcement comes out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
dongjoon-hyun commented on PR #48678:
URL: https://github.com/apache/spark/pull/48678#issuecomment-2442247011
BTW, is this a subtask of SPARK-44728 , @zhengruifeng ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
dongjoon-hyun closed pull request #48678: [SPARK-50147][PYTHON][DOCS][TESTS]
Refine docstring for trigonometric functions
URL: https://github.com/apache/spark/pull/48678
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
dongjoon-hyun commented on PR #48155:
URL: https://github.com/apache/spark/pull/48155#issuecomment-2442143126
+1, LGTM.
Thank you again, @panbingkun and @LuciferYang .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
dependabot[bot] opened a new pull request, #48680:
URL: https://github.com/apache/spark/pull/48680
Bumps [rexml](https://github.com/ruby/rexml) from 3.2.6 to 3.3.9.
Release notes
Sourced from https://github.com/ruby/rexml/releases";>rexml's
releases.
REXML 3.3.9 - 2024-10-24
markonik-db commented on PR #48656:
URL: https://github.com/apache/spark/pull/48656#issuecomment-2442011609
If CI passes, hopefully it can be merged today
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
dongjoon-hyun commented on PR #48673:
URL: https://github.com/apache/spark/pull/48673#issuecomment-2442008904
For the record, Maven CI becomes healthy back after this PR.
- https://github.com/apache/spark/actions/workflows/build_maven.yml
- https://github.com/apache/spark/actions/runs
dependabot[bot] commented on PR #48680:
URL: https://github.com/apache/spark/pull/48680#issuecomment-2442001515
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version, let
dongjoon-hyun closed pull request #48680: Bump rexml from 3.2.6 to 3.3.9 in
/docs
URL: https://github.com/apache/spark/pull/48680
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
dongjoon-hyun closed pull request #48674: [SPARK-50145][BUILD] Upgrade Jetty to
11.0.24
URL: https://github.com/apache/spark/pull/48674
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
dongjoon-hyun commented on PR #48674:
URL: https://github.com/apache/spark/pull/48674#issuecomment-2441985708
All tests passed. Merged to master for Apache Spark 4.0.0 on February 2025.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
PetarVasiljevic-DB commented on code in PR #48625:
URL: https://github.com/apache/spark/pull/48625#discussion_r1819282320
##
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##
@@ -4421,6 +4421,16 @@ object SQLConf {
.booleanConf
.createWith
MaxGekk commented on PR #48499:
URL: https://github.com/apache/spark/pull/48499#issuecomment-2441867297
+1, LGTM. Merging to master.
Thank you, @mihailom-db and @srielau @HyukjinKwon for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
MaxGekk closed pull request #48499: [SPARK-49993][SQL] Improve error messages
for Sum and Average
URL: https://github.com/apache/spark/pull/48499
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
xupefei commented on PR #48622:
URL: https://github.com/apache/spark/pull/48622#issuecomment-2441785807
An inrelavent test is failing:
```
TypeError: Channel.unary_stream() got an unexpected keyword argument
'_registered_method'
[info] - python listener process: process terminat
dongjoon-hyun commented on PR #48673:
URL: https://github.com/apache/spark/pull/48673#issuecomment-2441830338
Thank you, @panbingkun and @viirya .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
dongjoon-hyun commented on PR #48674:
URL: https://github.com/apache/spark/pull/48674#issuecomment-2441828746
Thank you, @yaooqinn and @LuciferYang .
To @LuciferYang , sure. I re-triggered it.
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
rebo16v commented on code in PR #48347:
URL: https://github.com/apache/spark/pull/48347#discussion_r1819002703
##
mllib/src/test/scala/org/apache/spark/ml/feature/TargetEncoderSuite.scala:
##
@@ -0,0 +1,538 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
markonik-db commented on code in PR #48624:
URL: https://github.com/apache/spark/pull/48624#discussion_r1819177879
##
python/docs/source/reference/pyspark.sql/functions.rst:
##
@@ -279,6 +279,9 @@ Date and Timestamp Functions
make_timestamp
make_timestamp_ltz
make
1 - 100 of 124 matches
Mail list logo