(patched)
<https://reviews.apache.org/r/72413/#comment308812>
Is the location also sent to the executor via an environment variable? If
yes, we should specify the name of it. If not, I think that would make it hard
to write a domain socket communicating executor?
- Vinod Kone
On Ap
/job/Mesos-Websitebot-test/4/console
Thanks,
Vinod Kone
---
https://ci-builds.apache.org/job/Mesos/job/Mesos-Websitebot-test/4/console
Thanks,
Vinod Kone
-Websitebot-test/4/console
Thanks,
Vinod Kone
ps://reviews.apache.org/r/72858/#review221846
---
On Sept. 10, 2020, 12:14 p.m., Vinod Kone wrote:
>
> ---
> This is an automatically generated e-mail.
72fd72375e63f7e0dddb5472187edfdbe7a9d148
Diff: https://reviews.apache.org/r/72856/diff/3/
Changes: https://reviews.apache.org/r/72856/diff/2-3/
Testing
---
Tested via
https://ci-builds.apache.org/job/Mesos/job/Mesos-Websitebot-test/4/console
Thanks,
Vinod Kone
Description
---
This ensures extracted tarballs are owned by root when running the
build as root.
Diffs
-
3rdparty/stout/3rdparty/Makefile.am 5a90a11c67131f21dc4487222ea1dde228dd
Diff: https://reviews.apache.org/r/72859/diff/1/
Testing
---
Thanks,
Vinod Kone
Description
---
This ensures extracted tarballs are owned by root when running the
build as root.
Diffs
-
3rdparty/libprocess/3rdparty/Makefile.am
e148f2dd2470ba973cc3f6d4067be64039299a48
Diff: https://reviews.apache.org/r/72860/diff/1/
Testing
---
Thanks,
Vinod Kone
Description
---
This ensures extracted tarballs are owned by root when running the
build as root.
Diffs
-
3rdparty/Makefile.am 23f49ecffc5b44529ce69ccd841d942a30a98c2d
Diff: https://reviews.apache.org/r/72861/diff/1/
Testing
---
Thanks,
Vinod Kone
/console
Thanks,
Vinod Kone
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73004/#review222166
---
Ship it!
Ship It!
- Vinod Kone
On Nov. 4, 2020, 7:56 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43619/#review119390
---
Ship it!
Ship It!
- Vinod Kone
On Feb. 16, 2016, 10 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43618/#review119389
---
Ship it!
Ship It!
- Vinod Kone
On Feb. 16, 2016, 9:59 p.m
://reviews.apache.org/r/43552/diff/
Testing
---
Tested locally.
Thanks,
Vinod Kone
de": 104}})
git clean -fd
git reset --hard fb779576521abc35d99f2b8834684f3a8f020895
Thanks,
Vinod Kone
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43769/#review119953
---
Ship it!
Ship It!
- Vinod Kone
On Feb. 19, 2016, 6:54 p.m
ws as submitted.
Diffs (updated)
-
support/push-reviews.py PRE-CREATION
Diff: https://reviews.apache.org/r/43552/diff/
Testing
---
Tested locally.
Thanks,
Vinod Kone
;
> > https://www.reviewboard.org/docs/rbtools/dev/rbt/commands/close/
I'll make a TODO for now as committers don't currently/always set the commit
message on RB.
- Vinod
---
This is an
;https://reviews.apache.org/r/43639/#comment181644>
offer without reserved resources.
- Vinod Kone
On Feb. 22, 2016, 6:39 p.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43641/#review120213
---
Ship it!
Ship It!
- Vinod Kone
On Feb. 22, 2016, 6:43 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43642/#review120214
---
Ship it!
Ship It!
- Vinod Kone
On Feb. 22, 2016, 6:44 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43657/#review120217
---
Ship it!
Ship It!
- Vinod Kone
On Feb. 18, 2016, 4:54 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43658/#review120218
---
Ship it!
Ship It!
- Vinod Kone
On Feb. 17, 2016, 7:23 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43659/#review120394
---
Ship it!
Ship It!
- Vinod Kone
On Feb. 17, 2016, 7:22 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43660/#review120395
---
Ship it!
Ship It!
- Vinod Kone
On Feb. 17, 2016, 7:22 p.m
tps://reviews.apache.org/r/43661/#comment181836>
Subscribe contains FrameworkInfo. So this check means that a framework
cannot update its FrameworkInfo unless it gets a disconnected callback? Is
there a way for the scheduler force the disconnection?
- Vinod Kone
On Feb. 17, 2016, 7:22 p.m., Anand Ma
ecutor library, we did a close() here of the previous reader. Why was
it required there and not here?
- Vinod Kone
On Feb. 22, 2016, 8:19 p.m., Anand Mazumdar wrote:
>
> ---
> This is an automat
gt; with the commit message we actually pushed to master.
> >
> > You can use the --description flag:
> >
> > https://www.reviewboard.org/docs/rbtools/dev/rbt/commands/close/
>
> Vinod Kone wrote:
> I'll make a TODO for now as committers d
ry
run option.
- Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43552/#review120223
---
On Feb. 22, 2016, 4:52 a.m., Vinod Kone w
itted.
Diffs (updated)
-
support/push-reviews.py PRE-CREATION
Diff: https://reviews.apache.org/r/43552/diff/
Testing
---
Tested locally.
Thanks,
Vinod Kone
ort.
I've removed the "if reviews:" to avoid confusion.
- Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43552/#review120452
-------
On Feb. 22, 2016, 4:52 a.m., Vinod Ko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43462/#review120551
---
Ship it!
Ship It!
- Vinod Kone
On Feb. 24, 2016, 7:20 p.m
ators instead of foreach in the first
place. cc @mcypark
- Vinod Kone
On Feb. 24, 2016, 7:19 p.m., Cong Wang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.a
done" section.
support/docker_build.sh (line 125)
<https://reviews.apache.org/r/42100/#comment182038>
lets just call this function cleanup().
- Vinod Kone
On Jan. 17, 2016, 6:49 a.m., Shuai Lin wrote:
>
> ---
>
gt;
what about other states?
src/scheduler/scheduler.cpp (line 609)
<https://reviews.apache.org/r/43662/#comment182482>
s/connection/connections/
src/scheduler/scheduler.cpp (line 610)
<https://reviews.apache.org/r/43662/#comment182483>
s/connection/connections/
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44101/#review120969
---
Ship it!
Ship It!
- Vinod Kone
On Feb. 26, 2016, 9:35 p.m
)
<https://reviews.apache.org/r/42733/#comment182524>
no need for else if, just do an if.
src/v1/resources.cpp (line 70)
<https://reviews.apache.org/r/42733/#comment182525>
ditto.
- Vinod Kone
On Feb. 26, 2016, 6:31 p.m., Gre
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44108/#review121032
---
Ship it!
Ship It!
- Vinod Kone
On Feb. 26, 2016, 11:34 p.m
-
>
> (Updated Feb. 27, 2016, 1:22 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-3570
> https://issues.apache.org/jira/browse/MESOS-3570
>
>
> Repository: mesos
>
&
)
<https://reviews.apache.org/r/43664/#comment182638>
why will there be future invocations?
- Vinod Kone
On Feb. 17, 2016, 10:45 p.m., Anand Mazumdar wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43667/#review121049
---
Ship it!
Ship It!
- Vinod Kone
On Feb. 17, 2016, 10:46 p.m
> On Feb. 27, 2016, 2:08 a.m., Vinod Kone wrote:
> > src/tests/scheduler_tests.cpp, line 136
> > <https://reviews.apache.org/r/43664/diff/2/?file=1253297#file1253297line136>
> >
> > why will there be future invocations?
I see the reasoning in the next r
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39372/#review121053
---
Ship it!
Ship It!
- Vinod Kone
On Feb. 22, 2016, 8:19 p.m
org/r/43846/#comment182647>
why a new constructor instead of updating the above constructor. you can
make detector Option> with default None.
- Vinod Kone
On Feb. 22, 2016, 8:24 p.m., Anand Mazumdar wrote:
>
> ---
>
)
<https://reviews.apache.org/r/43847/#comment182649>
s/Fail over/Failover/
- Vinod Kone
On Feb. 22, 2016, 8:20 p.m., Anand Mazumdar wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43661/#review121154
---
Ship it!
Ship It!
- Vinod Kone
On Feb. 17, 2016, 7:22 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43846/#review121156
---
Ship it!
Ship It!
- Vinod Kone
On Feb. 27, 2016, 4:48 a.m
changes.
2) Update http_command_executor.cpp to use v1 API.
3) Make changes to flags.cpp and slave.cpp.
4) Update/parameterize tests (slave recovery tests?) to use http command
executor.
- Vinod Kone
On Feb. 20, 2016, 1:44 p.m., Qian Z
/scheduler_tests.cpp 70c5b218aa231b21277580567d92f31c16a95efb
Diff: https://reviews.apache.org/r/44218/diff/
Testing
---
make check
Thanks,
Vinod Kone
e6cc39b4f45317f94145f0a4a1b64215b9a0cbff
docs/scheduler-http-api.md 53b482a813fa3909e786791d5331ef11c8fcc662
Diff: https://reviews.apache.org/r/44220/diff/
Testing
---
Rendered the markdown locally.
Thanks,
Vinod Kone
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44222/#review121487
---
Ship it!
Ship It!
- Vinod Kone
On March 1, 2016, 8:04 p.m
tps://reviews.apache.org/r/44224/#comment183204>
s/MESOS_SHUTDOWN_GRACE_PERIOD/MESOS_EXECUTOR_SHUTDOWN_GRACE_PERIOD/
to match the flag name.
- Vinod Kone
On March 1, 2016, 8:04 p.m., Anand Mazumdar wrote:
>
> ---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44223/#review121488
---
tnis should come after the next review.
- Vinod Kone
On March
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44223/#review121489
---
Ship it!
Ship It!
- Vinod Kone
On March 1, 2016, 8:04 p.m
.
- Vinod Kone
On March 1, 2016, 8:04 p.m., Anand Mazumdar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44226/#review121491
---
Ship it!
Ship It!
- Vinod Kone
On March 1, 2016, 8:04 p.m
> On March 1, 2016, 8:21 p.m., Vinod Kone wrote:
> > Ship It!
Can you update the env variable name in the description?
- Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.or
> On March 1, 2016, 8:25 p.m., Vinod Kone wrote:
> > Rename the env variable per my previous comment.
Can update the summary?
- Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.or
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44185/#review121501
---
Ship it!
Ship It!
- Vinod Kone
On Feb. 29, 2016, 11:34 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44110/#review121502
---
Ship it!
Ship It!
- Vinod Kone
On Feb. 29, 2016, 7:43 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44111/#review121503
---
Ship it!
Ship It!
- Vinod Kone
On Feb. 27, 2016, 2:19 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44112/#review121504
---
Ship it!
Ship It!
- Vinod Kone
On Feb. 27, 2016, 2:18 a.m
?
- Vinod Kone
On March 1, 2016, 9:15 p.m., Anand Mazumdar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
omatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44218/#review121516
---
On March 1, 2016, 7:47 p.m., Vinod Kone wrote:
>
> ---
> This is
428e12646d80b45daec30cfe607b97f36170fdf5
src/tests/scheduler_tests.cpp 2b1693eaf1a6106f5e7d269e4e3f6c353dd6f017
Diff: https://reviews.apache.org/r/44218/diff/
Testing
---
make check
Thanks,
Vinod Kone
/44243/diff/
Testing
---
make check
Thanks,
Vinod Kone
hanks,
Vinod Kone
his. set the expectation for offers2 after #1124.
src/tests/scheduler_tests.cpp (lines 1202 - 1206)
<https://reviews.apache.org/r/44273/#comment183553>
ditto. split please.
- Vinod Kone
On March 2, 2016, 8:28 p.m., An
event/
src/scheduler/scheduler.cpp (line 463)
<https://reviews.apache.org/r/44274/#comment183557>
don't you need to guard this with !running.load() check?
- Vinod Kone
On March 2, 2016, 6:21 p.m., Anand Mazumdar wrote:
>
> ---
test_http_framework.cpp?
s/EventCallScheduler/HTTPScheduler/
- Vinod Kone
On March 2, 2016, 3:11 p.m., Yong Tang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
settle().
- Vinod Kone
On March 2, 2016, 9:08 p.m., Anand Mazumdar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
cheduler.cpp (line 678)
<https://reviews.apache.org/r/44278/#comment183579>
s/stream/streamId/
- Vinod Kone
On March 2, 2016, 10:36 p.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e-mail. To reply
(line 899)
<https://reviews.apache.org/r/44290/#comment183582>
// Send a TEARDOWN call without stream ID.
src/tests/scheduler_http_api_tests.cpp (line 1039)
<https://reviews.apache.org/r/44290/#comment183583>
nice test!
- Vinod Kone
On March 2, 2016, 10:20 p.m., Gre
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44279/#review121766
---
Ship it!
Ship It!
- Vinod Kone
On March 2, 2016, 8:59 p.m
)
<https://reviews.apache.org/r/44266/#comment183626>
s/EventCall/TestHTTP/
- Vinod Kone
On March 3, 2016, 4:27 a.m., Yong Tang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
tps://reviews.apache.org/r/44266/#comment183627>
s/C++ low level scheduler/C++ HTTP scheduler/
- Vinod Kone
On March 3, 2016, 4:27 a.m., Yong Tang wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44278/#review121902
---
Ship it!
Ship It!
- Vinod Kone
On March 3, 2016, 5:13 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44348/#review121925
---
Ship it!
- Vinod Kone
On March 3, 2016, 7:08 p.m., Neil
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44353/#review121926
---
Ship it!
Ship It!
- Vinod Kone
On March 3, 2016, 8 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44349/#review121928
---
Ship it!
Ship It!
- Vinod Kone
On March 3, 2016, 7:24 p.m
://issues.apache.org/jira/browse/MESOS-4852)
- Vinod Kone
On March 3, 2016, 6:49 a.m., Yong Tang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
ews.apache.org/r/44362/#comment183820>
split this expecation and move the killed to just before killing the task.
src/tests/containerizer/memory_pressure_tests.cpp (line 254)
<https://reviews.apache.org/r/44362/#comment183821>
s/checkpointed/_statusUpdateAcknowledgement/
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44273/#review121964
---
Ship it!
Ship It!
- Vinod Kone
On March 3, 2016, 1:29 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44274/#review121966
---
Ship it!
Ship It!
- Vinod Kone
On March 4, 2016, 12:03 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44275/#review121967
---
Ship it!
Ship It!
- Vinod Kone
On March 4, 2016, 12:03 a.m
tps://reviews.apache.org/r/44371/#comment183833>
s/capability/field/ to avoid confusion between this and
FrameworkInfo.Capability
CHANGELOG (line 41)
<https://reviews.apache.org/r/44371/#comment183831>
kill this.
- Vinod Kone
On March 4, 2016, 12:43 a.m., Neil
> On Feb. 29, 2016, 2:24 a.m., Vinod Kone wrote:
> > Thanks for working on this Qian!
> >
> > It's really hard to tell what changes were made to the http command
> > executor that are different from the command executor. I would suggest you
> > to sp
the content in
http_command_executor.cpp is identical to executor.cpp and that it will updated
in the subsequent review?
- Vinod Kone
On March 5, 2016, 3:02 p.m., Qian Zhang wrote:
>
> ---
> This is an automatically generated e
)
<https://reviews.apache.org/r/44476/#comment184384>
How about
"For remote linked processes, this indicates that the TCP socket between
the linker and linkee has failed (e.g., linkee process died, network error).
"
?
- Vinod Kone
On March 7, 2016,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44477/#review122408
---
Ship it!
Ship It!
- Vinod Kone
On March 7, 2016, 10:54 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44478/#review122409
---
Ship it!
Thanks for the cleanup!
- Vinod Kone
On March 7
-guide.md (lines 260 - 261)
<https://reviews.apache.org/r/44479/#comment184395>
s/more promptly/promptly/ ?
- Vinod Kone
On March 7, 2016, 10:54 p.m., Neil Conway wrote:
>
> ---
> This is an automatically generated e-mail.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44476/#review122427
---
Ship it!
- Vinod Kone
On March 8, 2016, 12:13 a.m., Neil
to *parameter = parameters.add_parameter();
parameter->set_key("acls");
parameter->set_value(string(jsonify(JSON::Protobuf(acls;
return parameters;
}
};
```
- Vinod Kone
On March 8, 2016, 4:43 p.m., Alexander Rojas wrote:
>
> On March 8, 2016, 1:08 a.m., Vinod Kone wrote:
> > include/mesos/authorizer/authorizer.hpp, line 58
> > <https://reviews.apache.org/r/44319/diff/3/?file=1282986#file1282986line58>
> >
> > seems weird that this interface takes ACLs as a param. can we make i
old releases that didn't have "--authorizers"
flag? We should atleast mention this behavior in the flags help.
src/tests/cluster.cpp (line 175)
<https://reviews.apache.org/r/44319/#comment185069>
s/create/author
320/#comment185091>
any reason why this should be exposed in the include directory?
- Vinod Kone
On March 10, 2016, 2:09 p.m., Alexander Rojas wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
er/master.cpp (line 2892)
<https://reviews.apache.org/r/44322/#comment185227>
s/however/However/
src/master/master.cpp (line 2939)
<https://reviews.apache.org/r/44322/#comment185232>
new line.
src/master/master.cpp (line 304
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44319/#review123210
---
Ship it!
Ship It!
- Vinod Kone
On March 11, 2016, 1:45 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44320/#review123211
---
Ship it!
Ship It!
- Vinod Kone
On March 11, 2016, 1:47 p.m
1 - 100 of 3244 matches
Mail list logo
