Re: Review Request 45166: Fixed flaky `MasterTest.SlavesEndpointTwoSlaves`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45166/#review124974 --- While I'm not afraid of your changes, I can't understand why this

Re: Review Request 45186: Implemented user specified system config files support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45186/#review124976 --- src/slave/containerizer/mesos/isolators/docker/runtime.cpp (lines

Re: Review Request 45186: Implemented user specified system config files support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45186/#review124964 --- src/slave/containerizer/mesos/isolators/docker/runtime.cpp (lines

Re: Review Request 45014: Add /containers endpoint to return ResourceUsage.

> On March 22, 2016, 5:39 a.m., Jie Yu wrote: > > Instead of handling /containers endpoint in Slave, I would suggest we > > dispatch the request to ResourceMonitor. I will rename ResourceMonitor to > > ContainerMonitor, and we will be deprecating the /monitor/statistics > > endpoints in the fu

Re: Review Request 45014: Add /containers endpoint to return ResourceUsage.

> On March 22, 2016, 5:39 a.m., Jie Yu wrote: > > Instead of handling /containers endpoint in Slave, I would suggest we > > dispatch the request to ResourceMonitor. I will rename ResourceMonitor to > > ContainerMonitor, and we will be deprecating the /monitor/statistics > > endpoints in the fu

Re: Review Request 45183: Implemented mounting host system config files to container.

> On March 22, 2016, 11:02 p.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/isolators/docker/runtime.cpp, lines 216-222 > > > > > > This was already checked in L194-L197, why check again here? Hey Guangya,

Re: Review Request 45184: Added test for mounting host system config files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45184/#review124963 --- src/tests/containerizer/runtime_isolator_tests.cpp (line 354)

Re: Review Request 44136: Libprocess: [1/2] Conditioned out Windows-incompatible includes.

> On March 22, 2016, 2:16 p.m., Michael Park wrote: > > 3rdparty/libprocess/src/pid.cpp, lines 13-23 > > > > > > Can we maybe organize it like this? > > > > ``` > > #ifndef __WINDOWS__ > > #include >

Re: Review Request 45183: Implemented mounting host system config files to container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45183/#review124961 --- src/slave/containerizer/mesos/isolators/docker/runtime.cpp (lines

Re: Review Request 45123: Updated docs for deletion of persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45123/#review124959 --- Patch looks great! Reviews applied: [42470, 42471, 42472, 42473,

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44514/ --- (Updated March 23, 2016, 1:10 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

> On March 16, 2016, 11:08 p.m., Jie Yu wrote: > > This patch breaks all the ROOT DOCKER tests in our internal CI. I've > > reverted it for now. Can you do a sudo make check with docker? > > Steve Niemitz wrote: > ok, I see what the problem is here. The issue is with the > mesos-docker-ex

Re: Review Request 45022: Windows: Add Windows-friendly implementation of `rm.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45022/#review124950 --- Bad patch! Reviews applied: [45022, 45015, 45009, 44084, 44978, 4

Review Request 45194: STOUT: [2/2] Conditioned out Windows-incompatible includes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45194/ --- Review request for mesos. Repository: mesos Description --- STOUT: [2/2]

Re: Review Request 44136: Libprocess: [1/2] Conditioned out Windows-incompatible includes.

> On March 22, 2016, 9:16 p.m., Michael Park wrote: > > 3rdparty/libprocess/src/pid.cpp, lines 13-23 > > > > > > Can we maybe organize it like this? > > > > ``` > > #ifndef __WINDOWS__ > > #include >

Re: Review Request 44136: Libprocess: [1/2] Conditioned out Windows-incompatible includes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44136/ --- (Updated March 23, 2016, 2:46 a.m.) Review request for mesos, Alex Naparu, Dani

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

> On March 16, 2016, 11:08 p.m., Jie Yu wrote: > > This patch breaks all the ROOT DOCKER tests in our internal CI. I've > > reverted it for now. Can you do a sudo make check with docker? ok, I see what the problem is here. The issue is with the mesos-docker-executor code path (when launching

Re: Review Request 45168: Removed old comment from 'mesos.proto'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45168/#review124945 --- Patch looks great! Reviews applied: [45168] Passed command: expo

Re: Review Request 44450: Rescind all outstanding offers to satisfy weights update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44450/ --- (Updated March 23, 2016, 1:59 a.m.) Review request for mesos, Adam B and Alexan

Re: Review Request 43879: Added allocator metrics for number of allocations made.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43879/#review124937 --- Fix it, then Ship it! Thanks! Just some minor adjustments I'll

Re: Review Request 43561: Improve Ranges parsing to handle single values.

> On March 21, 2016, 10:02 p.m., Joris Van Remoortere wrote: > > src/common/values.cpp, line 612 > > > > > > Not yours: We shouldn't capture temporaries by reference. > > Either: > > 1) capture by value: `con

Re: Review Request 43880: Added allocated metrics for total and allocated scalar resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43880/#review124864 --- Fix it, then Ship it! Thanks for the patience Benjamin! I'll ma

Review Request 45185: Introduced an agent flag 'system_config_files'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45185/ --- Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy Ch

Review Request 45183: Implemented mounting host system config files to container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45183/ --- Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy Ch

Review Request 45186: Implemented user specified system config files support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45186/ --- Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy Ch

Review Request 45184: Added test for mounting host system config files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45184/ --- Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy Ch

Re: Review Request 45092: Fixed containerizer potential race destroy while provisioning.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45092/#review124900 --- src/slave/containerizer/mesos/containerizer.cpp (lines 714 - 722)

Re: Review Request 44674: Supported image name specified with private registry prefix.

> On 三月 22, 2016, 2:23 p.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp, line > > 395 > > > > > > Just a question: Where did set the schema was set to `https` for thi

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/ --- (Updated March 22, 2016, 11:24 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44948: Add XFS disk resource isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44948/ --- (Updated March 22, 2016, 11:24 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44949: Add XFS disk isolator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44949/ --- (Updated March 22, 2016, 11:24 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44950: Add XFS disk isolator documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44950/ --- (Updated March 22, 2016, 11:24 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

> On March 22, 2016, 4:46 p.m., Gilbert Song wrote: > > BTW, should we also add `utils.cpp` to `CMakeList.txt`? Cmake support is going to need a lot more than that :-/ - James --- This is an automatically generated e-mail. To reply, vis

Re: Review Request 44947: Add tests for XFS project quota utilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44947/ --- (Updated March 22, 2016, 11:21 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44945: Add autoconf tests for XFS project quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44945/ --- (Updated March 22, 2016, 11:21 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 45166: Fixed flaky `MasterTest.SlavesEndpointTwoSlaves`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45166/#review124908 --- Patch looks great! Reviews applied: [45166] Passed command: expo

Re: Review Request 44135: Libprocess: Use Windows-compatible memory fence in logging.

> On March 22, 2016, 9:52 p.m., Neil Conway wrote: > > 3rdparty/libprocess/include/process/logging.hpp, line 57 > > > > > > I wonder whether we can use something from C++11 to avoid the need for > > non-portable code

Re: Review Request 45123: Updated docs for deletion of persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45123/ --- (Updated March 22, 2016, 11:02 p.m.) Review request for mesos, Jie Yu and Joris

Re: Review Request 45123: Updated docs for deletion of persistent volumes.

> On March 22, 2016, 7:58 a.m., Guangya Liu wrote: > > What about > > https://github.com/apache/mesos/blob/master/docs/multiple-disk.md#storage-management > > ? I think that we should also update here as well. Good catch! Thanks, fixed. - Neil --

Re: Review Request 44135: Libprocess: Use Windows-compatible memory fence in logging.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44135/#review124898 --- 3rdparty/libprocess/include/process/logging.hpp (line 57)

Re: Review Request 44135: Libprocess: Use Windows-compatible memory fence in logging.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44135/#review124895 --- Ship it! Ship It! - Michael Park On March 18, 2016, 6:49 p.m

Re: Review Request 44674: Supported image name specified with private registry prefix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44674/#review124893 --- Patch looks great! Reviews applied: [44672, 44673, 44674] Passed

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44514/#review124881 --- src/slave/containerizer/mesos/isolators/network/cni/cni.hpp (line

Re: Review Request 45022: Windows: Add Windows-friendly implementation of `rm.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45022/#review124879 --- 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rm.hp

Re: Review Request 45022: Windows: Add Windows-friendly implementation of `rm.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45022/#review124867 --- 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rm.hp

Re: Review Request 45163: Reflecting rename of Tachyon to Alluxio.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45163/#review124863 --- Ship it! Ship It! - Neil Conway On March 22, 2016, 6:03 p.m.

Re: Review Request 44622: Introduced a protobuf message "NetworkInfo".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44622/#review124858 --- Fix it, then Ship it! src/slave/containerizer/mesos/isolators/

Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44255/#review124860 --- Patch looks great! Reviews applied: [44255] Passed command: expo

Re: Review Request 43884: Added allocator metrics for used quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43884/#review124836 --- Fix it, then Ship it! Looks good! I'll make some minor adjustme

Re: Review Request 44934: Updated mesos-execute to add support for Appc.

> On March 22, 2016, 5:10 p.m., Tom Runyon wrote: > > It would be helpful to update docs/container-image.md to include example > > appc deployments using mesos-execute. Created MESOS-5006. - Jojy --- This is an automatically generated

Re: Review Request 44549: Introduced a protobuf message "NetworkConfig".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44549/#review124849 --- src/Makefile.am (line 788)

Re: Review Request 44549: Introduced a protobuf message "NetworkConfig".

> On March 17, 2016, 3:37 a.m., Jie Yu wrote: > > src/CMakeLists.txt, line 279 > > > > > > I don't think we put headers here. > > Qian Zhang wrote: > I had the same concern before, because it seems most source f

Re: Review Request 44851: Renamed an allocator metric.

> On March 22, 2016, 5:50 p.m., Ben Mahler wrote: > > The changelog update would be great as well here, I'll take care of that > > before committing. Thanks! I'll also update the existing test: ``` $ grep -R allocator/event_queue_dispatches src/tests src/tests/master_tests.cpp: EXPECT_EQ(1u,

Re: Review Request 44852: Documented existing allocator metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44852/#review124843 --- Ship it! Ship It! - Ben Mahler On March 18, 2016, 4:08 p.m.,

Re: Review Request 44851: Renamed an allocator metric.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44851/#review124840 --- Fix it, then Ship it! The changelog update would be great as we

Review Request 45168: Removed old comment from 'mesos.proto'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45168/ --- Review request for mesos, Adam B, Joris Van Remoortere, and Vinod Kone. Reposit

Re: Review Request 44851: Renamed an allocator metric.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44851/ --- (Updated March 22, 2016, 6:32 p.m.) Review request for mesos, Alexander Ruklets

Review Request 45166: Fixed flaky `MasterTest.SlavesEndpointTwoSlaves`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45166/ --- Review request for mesos, Alexander Rojas and Neil Conway. Bugs: MESOS-4984

Re: Review Request 44748: Stout: Added implementation of `read` that works on Windows.

> On March 21, 2016, 9:02 a.m., Joris Van Remoortere wrote: > > Can you consider the feedback frmo the `write` review and rebase this? Alright, for posterity the `write` review is #44747, and I've adopted those suggestions here, too. - Alex --

Re: Review Request 44748: Stout: Added implementation of `read` that works on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44748/ --- (Updated March 22, 2016, 5:21 p.m.) Review request for mesos, Alex Naparu, Dani

Re: Review Request 44747: Stout: Added implementation of `write` that works on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44747/ --- (Updated March 22, 2016, 5:20 p.m.) Review request for mesos, Alex Naparu, Dani

Re: Review Request 44661: Deprecated the `docker_stop_timeout` flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44661/ --- (Updated March 22, 2016, 5:15 p.m.) Review request for mesos, Ben Mahler and Ti

Re: Review Request 44660: Used `KillPolicy` and shutdown grace period in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44660/ --- (Updated March 22, 2016, 5:13 p.m.) Review request for mesos, Ben Mahler, Gilbe

Re: Review Request 44657: Used `KillPolicy` and shutdown grace period in command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44657/ --- (Updated March 22, 2016, 5:12 p.m.) Review request for mesos, Ben Mahler and Gi

Re: Review Request 44657: Used `KillPolicy` and shutdown grace period in command executor.

> On March 19, 2016, 1:52 a.m., Ben Mahler wrote: > > src/launcher/executor.cpp, line 929 > > > > > > It doesn't crash, it just exits :) Oh, right : ) - Alexander

Re: Review Request 44934: Updated mesos-execute to add support for Appc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44934/#review124834 --- It would be helpful to update docs/container-image.md to include e

Re: Review Request 44707: Added validation for task's kill policy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44707/ --- (Updated March 22, 2016, 5:10 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44656: Introduced `KillPolicy` protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44656/ --- (Updated March 22, 2016, 5:09 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44994: Added a test for executor shutdown grace period.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44994/ --- (Updated March 22, 2016, 5:07 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 45039: Updated the comment for launching tasks and accepting offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45039/ --- (Updated March 22, 2016, 5:07 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44655: Made `shutdown_grace_period` configurable in `ExecutorInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44655/ --- (Updated March 22, 2016, 5:05 p.m.) Review request for mesos, Ben Mahler and Gi

Re: Review Request 44854: Added validation for executor's shutdown grace period.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44854/ --- (Updated March 22, 2016, 5:05 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/#review124827 --- BTW, should we also add `utils.cpp` to `CMakeList.txt`? src/slav

Re: Review Request 44511: Add registry tests for /weights endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44511/#review124826 --- Patch looks great! Reviews applied: [44511] Passed command: expo

Re: Review Request 44674: Supported image name specified with private registry prefix.

> On March 22, 2016, 7:23 a.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp, line > > 395 > > > > > > Just a question: Where did set the schema was set to `https` for

Re: Review Request 44672: Added normalize method to registry puller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44672/#review124818 --- Ship it! Ship It! - Jie Yu On March 21, 2016, 7:06 p.m., Gil

Re: Review Request 44673: Added test for registry puller normalize.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44673/#review124819 --- Ship it! Ship It! - Jie Yu On March 21, 2016, 7:06 p.m., Gil

Re: Review Request 45134: Skip FetcherTest zip tests when `unzip` is uninstalled.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45134/#review124816 --- Ship it! Ship It! - Jie Yu On March 22, 2016, 1:10 p.m., Tom

Review Request 45163: Reflecting rename of Tachyon to Alluxio.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45163/ --- Review request for mesos. Bugs: MESOS-5002 https://issues.apache.org/jira/b

Re: Review Request 45082: Implemented cleanup() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45082/#review124806 --- src/slave/containerizer/mesos/isolators/network/cni/cni.hpp (line

Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44255/#review124811 --- Fix it, then Ship it! src/master/master.cpp (line 3028)

Re: Review Request 45123: Updated docs for deletion of persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45123/#review124810 --- Patch looks great! Reviews applied: [42470, 42471, 42472, 42473,

Re: Review Request 44706: Implemented isolate() method of "network/cni" isolator.

> On March 20, 2016, 7:08 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, lines 206-212 > > > > > > I suggest we save a rootDir in the isolator process. We can easily > > switch

Re: Review Request 44706: Implemented isolate() method of "network/cni" isolator.

> On March 21, 2016, 3:57 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 339 > > > > > > This is just a thought. Maybe its better to use `await` over here, and >

Re: Review Request 44139: Windows:[2/2] Lifted socket API into Stout.

> On March 21, 2016, 9:02 a.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/include/process/network.hpp, line 49 > > > > > > does this still work considering your refactoring of the parent patches? The functi

Re: Review Request 44706: Implemented isolate() method of "network/cni" isolator.

> On March 21, 2016, 11:57 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, lines 328-336 > > > > > > why do we need this dispatch ? The dispatch is to itself, so seems

Re: Review Request 44674: Supported image name specified with private registry prefix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44674/#review124793 --- src/slave/containerizer/mesos/provisioner/docker/registry_puller.

Re: Review Request 44706: Implemented isolate() method of "network/cni" isolator.

> On March 21, 2016, 3:08 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp, lines 32-56 > > > > > > Can we introduce paths.hpp|cpp under cni/ directory for the canonical > > locati

Re: Review Request 44450: Rescind all outstanding offers to satisfy weights update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44450/#review124791 --- Patch looks great! Reviews applied: [41681, 43863, 44450] Passed

Re: Review Request 44851: Renamed an allocator metric.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44851/ --- (Updated March 22, 2016, 2:42 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 43561: Improve Ranges parsing to handle single values.

> On March 21, 2016, 10:02 p.m., Joris Van Remoortere wrote: > > src/common/values.cpp, line 613 > > > > > > @benm I wish we had support for iterating over these splicers eg: > > `foreachtoken(temp, ",\n", [](con

Re: Review Request 43561: Improve Ranges parsing to handle single values.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43561/ --- (Updated March 22, 2016, 9:22 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 45134: Skip FetcherTest zip tests when `unzip` is uninstalled.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45134/ --- (Updated March 22, 2016, 1:10 p.m.) Review request for mesos, Jie Yu and Neil C

Re: Review Request 45134: Skip FetcherTest zip tests when `unzip` is uninstalled.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45134/#review124785 --- Fix it, then Ship it! Ship It! src/tests/environment.cpp (lin

Re: Review Request 43561: Improve Ranges parsing to handle single values.

> On March 21, 2016, 2:02 p.m., Joris Van Remoortere wrote: > > src/common/values.cpp, line 612 > > > > > > Not yours: We shouldn't capture temporaries by reference. > > Either: > > 1) capture by value: `cons

Re: Review Request 45014: Add /containers endpoint to return ResourceUsage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45014/#review124783 --- Patch looks great! Reviews applied: [45014] Passed command: expo

Re: Review Request 43561: Improve Ranges parsing to handle single values.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43561/ --- (Updated March 22, 2016, 8:25 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 45134: Skip FetcherTest zip tests when `unzip` is uninstalled.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45134/ --- (Updated March 22, 2016, 12:20 p.m.) Review request for mesos and Jie Yu. Bug

Review Request 45158: Cleaned up formatting in CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45158/ --- Review request for mesos and Joris Van Remoortere. Repository: mesos Descript

Re: Review Request 44376: Upgrade zookeeper to 3.4.8 to support Power LE platform.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44376/#review124772 --- Bad patch! Reviews applied: [44376] Failed command: ./support/ap

  1   2   >