Re: Review Request 45097: Update metrics for SUBSCRIBE call for both PID/HTTP frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45097/ --- (Updated 三月 22, 2016, 6:42 a.m.) Review request for mesos, Anand Mazumdar and V

Re: Review Request 45096: Introduce 'minus' operator for class Counter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45096/ --- (Updated 三月 22, 2016, 6:42 a.m.) Review request for mesos, Anand Mazumdar and V

Re: Review Request 44622: Introduced a protobuf message "NetworkResult".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44622/ --- (Updated March 22, 2016, 2:40 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 45123: Updated docs for deletion of persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45123/ --- (Updated March 22, 2016, 6:24 a.m.) Review request for mesos, Jie Yu and Joris

Re: Review Request 45011: Fix numify() to handle negative numbers consistently (MESOS-4070).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45011/#review124740 --- Patch looks great! Reviews applied: [45011] Passed command: expo

Re: Review Request 44450: Rescind all outstanding offers to satisfy weights update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44450/ --- (Updated March 22, 2016, 5:50 a.m.) Review request for mesos, Adam B and Alexan

Re: Review Request 45014: Add /containers endpoint to return ResourceUsage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45014/#review124735 --- Instead of handling /containers endpoint in Slave, I would suggest

Re: Review Request 44376: Upgrade zookeeper to 3.4.8 to support Power LE platform.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44376/ --- (Updated March 22, 2016, 1:07 p.m.) Review request for mesos, Ben Mahler, Alex

Re: Review Request 44950: Add XFS disk isolator documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44950/#review124730 --- Patch looks great! Reviews applied: [44945, 44946, 44947, 44948,

Re: Review Request 44257: Upgrade protobuf to 2.6.1 to support PowerPC LE platform.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44257/ --- (Updated March 22, 2016, 12:13 p.m.) Review request for mesos, Ben Mahler, Alex

Re: Review Request 37168: Add an example framework using dynamic reservation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/ --- (Updated March 22, 2016, 11:44 a.m.) Review request for mesos, Greg Mann, Joerg

Re: Review Request 45018: MESOS-3481 Add const accessor to Master flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45018/ --- (Updated March 22, 2016, 3:34 a.m.) Review request for mesos, Joris Van Remoort

Re: Review Request 44378: Upgrade libev to 4.22 to support PowerPC LE platform.

> On March 16, 2016, 12:46 a.m., Vinod Kone wrote: > > Can you explain what testing you have done in the "Testing done" section? > > > > According to MESOS-4312, we agreed to do the following tests: > > > > -- Verify SSL, perf and docker related test cases work as expected on all > > platform

Re: Review Request 44252: Update glog-0.3.3.patch to support PowerPC LE platform.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44252/ --- (Updated March 22, 2016, 10:59 a.m.) Review request for mesos, Ben Mahler, Alex

Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support PowerPC LE platform.

> On March 22, 2016, 10:35 a.m., haosdent huang wrote: > > Hi, zhiwei. Thank you for your patch. But seems it still doesn't contain > > the binary file correctly after I apply this patch. > > > > ``` > > diff --git a/3rdparty/libprocess/3rdparty/http-parser-2.6.1.tar.gz > > b/3rdparty/libproce

Re: Review Request 43935: Allow setting role in mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43935/ --- (Updated 三月 22, 2016, 2:57 a.m.) Review request for mesos, Greg Mann, Shuai Lin

Re: Review Request 45018: MESOS-3481 Add const accessor to Master flags.

> On March 21, 2016, 7:04 p.m., Benjamin Bannier wrote: > > src/master/master.hpp, line 546 > > > > > > Two things: > > > > (1) I think a more fitting name here might be `flags()` (cf `info()` > > just abov

Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support PowerPC LE platform.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44372/#review124717 --- Hi, zhiwei. Thank you for your patch. But seems it still doesn't c

Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support PowerPC LE platform.

> On March 4, 2016, 7:37 a.m., haosdent huang wrote: > > 3rdparty/libprocess/3rdparty/Makefile.am, line 68 > > > > > > ditto. > > Zhiwei Chen wrote: > In the real file, there is a table bracket and backslash. I

Re: Review Request 44622: Introduced a protobuf message "NetworkResult".

> On March 21, 2016, 10:21 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/spec.proto, line 17 > > > > > > Can we put this under cni::spec namespace instead? > > Qian Zhang wrote: > Ji

Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support PowerPC LE platform.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44372/ --- (Updated March 22, 2016, 10:22 a.m.) Review request for mesos, Ben Mahler, Alex

Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support Power LE platform.

> On March 22, 2016, 7:21 a.m., Vinod Kone wrote: > > 3rdparty/libprocess/src/decoder.hpp, lines 175-177 > > > > > > Why do we need this now? In http-parse >= 2.x, the url.fragement is None, the previous code did no

Re: Review Request 45134: Skip FetcherTest zip tests when `unzip` is uninstalled.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45134/#review124710 --- src/tests/fetcher_tests.cpp (lines 647 - 651)

Re: Review Request 45011: Fix numify() to handle negative numbers consistently (MESOS-4070).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45011/#review124707 --- Ship it! Ship It! - haosdent huang On March 18, 2016, 10:49

Re: Review Request 44378: Upgrade libev to 4.22 to support PowerPC LE platform.

> On March 16, 2016, 8:46 a.m., Vinod Kone wrote: > > Can you explain what testing you have done in the "Testing done" section? > > > > According to MESOS-4312, we agreed to do the following tests: > > > > -- Verify SSL, perf and docker related test cases work as expected on all > > platforms

Re: Review Request 44378: Upgrade libev to 4.22 to support PowerPC LE platform.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44378/ --- (Updated March 22, 2016, 9:38 a.m.) Review request for mesos, Ben Mahler, Alex

Re: Review Request 44949: Add XFS disk isolator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44949/ --- (Updated March 22, 2016, 1:20 a.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44948: Add XFS disk resource isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44948/ --- (Updated March 22, 2016, 1:21 a.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44947: Add tests for XFS project quota utilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44947/ --- (Updated March 22, 2016, 1:20 a.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/ --- (Updated March 22, 2016, 1:20 a.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44950: Add XFS disk isolator documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44950/ --- (Updated March 22, 2016, 1:20 a.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44945: Add autoconf tests for XFS project quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44945/ --- (Updated March 22, 2016, 1:20 a.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44950: Add XFS disk isolator documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44950/#review124701 --- Patch looks great! Reviews applied: [44945, 44946, 44947, 44948,

Review Request 45134: Skip FetcherTest zip tests when `unzip` is uninstalled.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45134/ --- Review request for mesos and Jie Yu. Bugs: MESOS-4993 https://issues.apache

Re: Review Request 45126: Cleaned up nested health checker launch code in command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45126/#review124683 --- Patch looks great! Reviews applied: [45126] Passed command: expo

Re: Review Request 45126: Cleaned up nested health checker launch code in command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45126/#review124681 --- Ship it! Ship It! - Timothy Chen On March 21, 2016, 8:31 p.m

Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support Power LE platform.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44372/#review124679 --- Can you also explain the testing you have done? 3rdparty/libproc

Re: Review Request 44378: Upgrade libev to 4.22 to support PowerPC LE platform.

> On March 16, 2016, 12:46 a.m., Vinod Kone wrote: > > Can you explain what testing you have done in the "Testing done" section? > > > > According to MESOS-4312, we agreed to do the following tests: > > > > -- Verify SSL, perf and docker related test cases work as expected on all > > platform

Re: Review Request 44229: Added upgrade testing script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44229/#review124677 --- Fix it, then Ship it! support/test-upgrade.py (line 188)

Re: Review Request 44090: Windows: Changed the calling parameters for Windows API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44090/ --- (Updated March 21, 2016, 10:54 p.m.) Review request for mesos, Alex Naparu, Dan

Re: Review Request 44760: Windows: Fixed non-blocking connect.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44760/ --- (Updated March 21, 2016, 10:54 p.m.) Review request for mesos, Alex Naparu, Dan

Re: Review Request 44089: Windows: Used os::read/write from Stout for proper OS isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44089/ --- (Updated March 21, 2016, 10:54 p.m.) Review request for mesos, Alex Naparu, Dan

Re: Review Request 44139: Windows:[2/2] Lifted socket API into Stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44139/ --- (Updated March 21, 2016, 10:54 p.m.) Review request for mesos, Alex Naparu, Dan

Re: Review Request 44138: Windows:[1/2] Lifted socket API into Stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44138/ --- (Updated March 21, 2016, 10:53 p.m.) Review request for mesos, Alex Naparu, Dan

Re: Review Request 45123: Updated docs for deletion of persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45123/#review124672 --- Patch looks great! Reviews applied: [42470, 42471, 42472, 42473,

Re: Review Request 44948: Add XFS disk resource isolator.

> On March 21, 2016, 3:51 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/disk/xfs.cpp, line 320 > > > > > > I am wondering if it's possible to distinguish the Error case from the > > case where ther

Re: Review Request 44948: Add XFS disk resource isolator.

> On March 21, 2016, 3:51 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/disk/xfs.cpp, lines 172-173 > > > > > > Any reason this is not in xfs.hpp|cpp? I thought about that. If I make that change, t

Re: Review Request 44948: Add XFS disk resource isolator.

> On March 21, 2016, 3:51 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/disk/xfs.cpp, lines 302-303 > > > > > > We typically store the 'flags' directory in case yo u need other > > parameters in th

Re: Review Request 44948: Add XFS disk resource isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44948/ --- (Updated March 21, 2016, 9:47 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44950: Add XFS disk isolator documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44950/ --- (Updated March 21, 2016, 9:46 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/ --- (Updated March 21, 2016, 9:46 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44945: Add autoconf tests for XFS project quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44945/ --- (Updated March 21, 2016, 9:46 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44949: Add XFS disk isolator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44949/ --- (Updated March 21, 2016, 9:46 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44947: Add tests for XFS project quota utilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44947/ --- (Updated March 21, 2016, 9:46 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44994: Added a test for executor shutdown grace period.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44994/ --- (Updated March 21, 2016, 9:29 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 45039: Updated the scheduler `launchTasks()` comment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45039/ --- (Updated March 21, 2016, 9:24 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44993: Updated `TestContainerizer` to support default actions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44993/ --- (Updated March 21, 2016, 9:23 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44992: Reordered function declarations in `TestContainerizer`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44992/ --- (Updated March 21, 2016, 9:22 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44229: Added upgrade testing script.

> On March 16, 2016, 12:43 a.m., Vinod Kone wrote: > > support/test-upgrade.py, line 42 > > > > > > credfile is unused? In switching to the `test-framework`, I also enabled authentication, so the credential file is

Re: Review Request 44229: Added upgrade testing script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44229/ --- (Updated March 21, 2016, 9:20 p.m.) Review request for mesos, Niklas Nielsen an

Re: Review Request 44991: Enabled mocking on `TestContainerizer::destroy`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44991/ --- (Updated March 21, 2016, 9:16 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 45015: Windows: Fixed bug causing `os::exists` to report invalid paths exist.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45015/#review124661 --- 3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp

Re: Review Request 44084: Windows: Forked os::rename().

> On March 21, 2016, 7:24 p.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp, line 222 > > > > > > ``` > > ASSERT_EQ(message, file3Contents.get()); > > ``` Actuall

Re: Review Request 45009: Transition `filesystem_tests.cpp` to use `path::join`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45009/#review124655 --- Ship it! Ship It! - Michael Park On March 18, 2016, 12:51 a.

Re: Review Request 44084: Windows: Forked os::rename().

> On March 21, 2016, 7:24 p.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp, line 234 > > > > > > ``` > > ASSERT_TRUE(0u, file2Contents.get()); > > ``` oops. `s/A

Re: Review Request 44950: Add XFS disk isolator documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44950/#review124652 --- Patch looks great! Reviews applied: [44945, 44946, 44947, 44948,

Review Request 45126: Cleaned up nested health checker launch code in command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45126/ --- Review request for mesos, Jie Yu and Timothy Chen. Repository: mesos Descript

Re: Review Request 37168: Add an example framework using dynamic reservation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/#review124635 --- Patch looks great! Reviews applied: [37168] Passed command: expo

Re: Review Request 42684: Multiple Disk: Added persistent volumes tests for `MOUNT` type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42684/#review124631 --- src/tests/persistent_volume_tests.cpp (line 153)

Re: Review Request 44084: Windows: Forked os::rename().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44084/#review124623 --- 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/renam

Re: Review Request 44672: Added normalize method to registry puller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44672/ --- (Updated March 21, 2016, 12:06 p.m.) Review request for mesos, Guangya Liu, Art

Re: Review Request 44673: Added test for registry puller normalize.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44673/ --- (Updated March 21, 2016, 12:06 p.m.) Review request for mesos, Guangya Liu, Art

Re: Review Request 45018: MESOS-3481 Add const accessor to Master flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45018/#review124620 --- src/master/master.hpp (line 546)

Re: Review Request 45122: Updated tests for deletion of persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45122/ --- (Updated March 21, 2016, 6:44 p.m.) Review request for mesos, Jie Yu and Joris

Review Request 45122: Updated tests for deletion of persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45122/ --- Review request for mesos, Jie Yu and Joris Van Remoortere. Repository: mesos

Review Request 45123: Updated docs for deletion of persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45123/ --- Review request for mesos, Jie Yu and Joris Van Remoortere. Bugs: MESOS-2408

Re: Review Request 45121: Implemented deletion for persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45121/ --- (Updated March 21, 2016, 6:44 p.m.) Review request for mesos, Jie Yu and Joris

Review Request 45121: Implemented deletion for persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45121/ --- Review request for mesos, Jie Yu and Joris Van Remoortere. Repository: mesos

Review Request 45120: Extended `os::rmdir` in stout to support preserving the root directory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45120/ --- Review request for mesos, Jie Yu and Joris Van Remoortere. Bugs: MESOS-2408

Review Request 45118: Fixed various style issues.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45118/ --- Review request for mesos, Jie Yu and Joris Van Remoortere. Bugs: MESOS-2408

Review Request 45119: Added TODO.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45119/ --- Review request for mesos, Jie Yu and Joris Van Remoortere. Bugs: MESOS-2408

Review Request 45117: Cleaned up header includes in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45117/ --- Review request for mesos, Jie Yu and Joris Van Remoortere. Bugs: MESOS-2408

Re: Review Request 44854: Added validation for executor's shutdown grace period.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44854/ --- (Updated March 21, 2016, 6:38 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44655: Made `shutdown_grace_period` configurable in `ExecutorInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44655/ --- (Updated March 21, 2016, 6:37 p.m.) Review request for mesos, Ben Mahler and Gi

Re: Review Request 44994: Added a test for executor shutdown grace period.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44994/ --- (Updated March 21, 2016, 6:33 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 45000: MESOS-3902: Fix in location header during redirect from non-leader.

> On March 18, 2016, 6:24 p.m., Ben Whitehead wrote: > > src/master/http.cpp, line 959 > > > > > > According to the rules defined in > > https://tools.ietf.org/html/rfc3986#section-5 we should be fine to use a > >

Re: Review Request 43935: Allow setting role in mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43935/#review124613 --- Looks great! A couple small comments below. src/cli/execute.cpp

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/ --- (Updated March 21, 2016, 6:30 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

> On March 19, 2016, 10:10 p.m., Jie Yu wrote: > > src/linux/xfs.cpp, line 53 > > > > > > Instead of relying on parameter, can we use os::stat::isdir here? > > James Peach wrote: > ``isdir`` always follows symlin

Re: Review Request 45046: Created URI.filename to name fetched files in sandbox where appropriate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45046/#review124618 --- Ship it! Ship It! - Vinod Kone On March 21, 2016, 3:14 a.m.,

Re: Review Request 44994: Added a test for executor shutdown grace period.

> On March 18, 2016, 11:24 p.m., Ben Mahler wrote: > > src/tests/slave_tests.cpp, lines 3317-3323 > > > > > > It seems fine to expect this but arguably if what we care about in this > > test is **how** the agent ch

Re: Review Request 44948: Add XFS disk resource isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44948/ --- (Updated March 21, 2016, 6:21 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44949: Add XFS disk isolator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44949/ --- (Updated March 21, 2016, 6:20 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44950: Add XFS disk isolator documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44950/ --- (Updated March 21, 2016, 6:20 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/ --- (Updated March 21, 2016, 6:18 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44947: Add tests for XFS project quota utilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44947/ --- (Updated March 21, 2016, 6:18 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44945: Add autoconf tests for XFS project quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44945/ --- (Updated March 21, 2016, 6:17 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 37168: Add an example framework using dynamic reservation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/#review124611 --- Fix it, then Ship it! src/examples/dynamic_reservation_framewo

Re: Review Request 44832: Validate string when convert `Flags` to `hashmap`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44832/#review124608 --- Ship it! Ship It! - Kevin Klues On March 16, 2016, 1:50 a.m.

Re: Review Request 45018: MESOS-3481 Add const accessor to Master flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45018/#review124601 --- Patch looks great! Reviews applied: [45018] Passed command: expo

  1   2   >