Processed: Re: Bug#901548: diffoscope: Add lz4 comparator

2018-06-14 Thread Debian Bug Tracking System
Processing control commands: > forwarded -1 > https://salsa.debian.org/reproducible-builds/diffoscope/merge_requests/4 Bug #901548 [src:diffoscope] diffoscope: Add lz4 comparator Set Bug forwarded-to-address to 'https://salsa.debian.org/reproducible-builds/diffoscope/merge_requests/4'. -- 9015

Bug#901548: diffoscope: Add lz4 comparator

2018-06-14 Thread Mattia Rizzolo
Control: forwarded -1 https://salsa.debian.org/reproducible-builds/diffoscope/merge_requests/4 On Thu, Jun 14, 2018 at 02:45:33PM -0400, Xavier Briand wrote: > I opened a merge request on Gitlab ( > https://salsa.debian.org/reproducible-builds/diffoscope/merge_requests/4) Thank you! I reported

Bug#901548: diffoscope: Add lz4 comparator

2018-06-14 Thread Xavier Briand
I opened a merge request on Gitlab ( https://salsa.debian.org/reproducible-builds/diffoscope/merge_requests/4) forwarded 901548 https://salsa.debian.org/reproducible-builds/diffoscope/merge_requests/4 On Thu, 14 Jun 2018 at 14:30 Mattia Rizzolo wrote: > On Thu, Jun 14, 2018 at 02:25:09PM -0400,

Bug#901548: diffoscope: Add lz4 comparator

2018-06-14 Thread Mattia Rizzolo
On Thu, Jun 14, 2018 at 02:25:09PM -0400, Xavier Briand wrote: > I followed the instructions provided in the CONTRIBUTING.rst > > file. > That being said, I'd feel more comfortable using gitlab's merge request. >

Bug#901548: diffoscope: Add lz4 comparator

2018-06-14 Thread Xavier Briand
Hi Mattia, Comments bellow On Thu, 14 Jun 2018 at 14:14 Mattia Rizzolo wrote: > Control: tag -1 moreinfo > > Hi Xavier, > > On Thu, Jun 14, 2018 at 12:27:47PM -0400, Xavier Briand wrote: > > Add lz4 comparator. > > Thanks for your patch! > > However, I'd like to ask for some changes and improve

Bug#901548: diffoscope: Add lz4 comparator

2018-06-14 Thread Chris Lamb
Hi Xavier, > How would I go about it? Close this one and submit an other one? I would probably create the new MR, and then set the "forwarded field for this bug. Simply link it here and we can show you how to do that, or you can have a go yourself: https://www.debian.org/Bugs/server-control#fo

Bug#901548: diffoscope: Add lz4 comparator

2018-06-14 Thread Xavier Briand
Hi Chris, I followed the instructions provided in the CONTRIBUTING.rst file. That being said, I'd feel more comfortable using gitlab's merge request. How would I go about it? Close this one and submit an other

Bug#901548: diffoscope: Add lz4 comparator

2018-06-14 Thread Mattia Rizzolo
Control: tag -1 moreinfo Hi Xavier, On Thu, Jun 14, 2018 at 12:27:47PM -0400, Xavier Briand wrote: > Add lz4 comparator. Thanks for your patch! However, I'd like to ask for some changes and improvements, and I also have some questions about it. See the comments inlined in the diff: --- /dev/n

Processed: Re: Bug#901548: diffoscope: Add lz4 comparator

2018-06-14 Thread Debian Bug Tracking System
Processing control commands: > tag -1 moreinfo Bug #901548 [src:diffoscope] diffoscope: Add lz4 comparator Added tag(s) moreinfo. -- 901548: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=901548 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems __

Processed: Re: Bug#901548: diffoscope: Add lz4 comparator

2018-06-14 Thread Debian Bug Tracking System
Processing commands for cont...@bugs.debian.org: > tags 901548 + patch Bug #901548 [src:diffoscope] diffoscope: Add lz4 comparator Added tag(s) patch. > thanks Stopping processing here. Please contact me if you need assistance. -- 901548: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=901548

Bug#901548: diffoscope: Add lz4 comparator

2018-06-14 Thread Chris Lamb
tags 901548 + patch thanks Dear Xavier, Thanks! I was just wondering if you considered submitting this as a "merge request" on our Gitlab instance? https://salsa.debian.org/reproducible-builds/diffoscope :) Best wishes, -- ,''`. : :' : Chris Lamb `. `'` la...@deb

Bug#901548: diffoscope: Add lz4 comparator

2018-06-14 Thread Xavier Briand
Source: diffoscope Version: 95 Severity: wishlist Add lz4 comparator. -- Xavier Briand Senior Web Application Developer| ExperiencePoint 20 Duncan Street, Suite 200, Toronto, ON, M5H 3G8 (416) 369-9888 x259 Connect with me: LinkedIn