Re: Updating dpkg-buildflags to enable reproducible=+fixfilepath by default

2020-11-14 Thread Sune Vuorela
On 2020-11-13, Vagrant Cascadian wrote: > If it could be fixed at the core for QFINDTESTDATA, that would be nicer > than fixing 20-30 packages individually, though we're not there right > now. Unfortunately, only like 10% of the relevant packages have test suites enabled and run, because gettings

Re: Updating dpkg-buildflags to enable reproducible=+fixfilepath by default

2020-11-13 Thread Sune Vuorela
On 2020-10-27, Vagrant Cascadian wrote: > Though, of course, identifying the exact reproducibility problem would > be preferable. One of the common issues is test suites relying on the > behavior of __FILE__ returning a full path to find fixtures or other > test data. has QFIND_TESTDATA been adap

Re: Buildd-setup faffing around with __FILE__ breaks my unit tests.

2019-02-10 Thread Sune Vuorela
On Sunday, February 10, 2019 10:05:00 PM CET you wrote: > To fix this in other projects, we would have to patch all uses of __FILE__ > to something like strip_prefix(PREFIX, __FILE__), pass in PREFIX from the But why not just record the build directory as part of the environment that aren't allo

Re: Buildd-setup faffing around with __FILE__ breaks my unit tests.

2019-02-10 Thread Sune Vuorela
On Sunday, February 10, 2019 8:38:00 PM CET Ximin Luo wrote: > Yes, pass the source dir in through the build system "somehow", there are > lots of possible ways you can do this, and this is what every other test > runner does. A command-line argument or environment variable would be > simplest. So

Re: Buildd-setup faffing around with __FILE__ breaks my unit tests.

2019-02-10 Thread Sune Vuorela
On Sunday, February 10, 2019 8:17:00 PM CET Ximin Luo wrote: > Acceptable usecases are those that make fewest assumptions about the > behaviour of __FILE__, which has never been guaranteed to do what the QT > test macro assumes it does. Let's read the docs: https://gcc.gnu.org/onlinedocs/cpp/Stand

Re: Buildd-setup faffing around with __FILE__ breaks my unit tests.

2019-02-10 Thread Sune Vuorela
On Sunday, February 10, 2019 8:00:00 PM CET Ximin Luo wrote: > i.e. QT tests shouldn't use __FILE__, they should use something else. What should they use? A custom macro that the build system passes into instead? That's just silly. So what are your actual suggestion to find the source tree fro

Re: Buildd-setup faffing around with __FILE__ breaks my unit tests.

2019-02-10 Thread Sune Vuorela
(Please keep me CC'ed. Not subscribed) On Sunday, February 10, 2019 4:05:05 PM CET Holger Levsen wrote: > for now I've just added knotifications to ftbfs_due_to_f-file-prefix-map. > > Not sure what else to do about this right now. If you have magic regexes to auto tag issues, lines matching /WARN

Re: Buildd-setup faffing around with __FILE__ breaks my unit tests.

2019-02-10 Thread Sune Vuorela
On Sunday, February 10, 2019 3:34:27 PM CET Holger Levsen wrote: > On Sat, Feb 09, 2019 at 07:54:16PM +0100, Sune Vuorela wrote: > > (Please keep me CC'ed. Not subscribed) > > done. thanks. > this is unfortunate to say the least. > > we are track

Re: Buildd-setup faffing around with __FILE__ breaks my unit tests.

2019-02-10 Thread Sune Vuorela
On Sunday, February 10, 2019 3:08:00 AM CET Ximin Luo wrote: > Sune Vuorela: > > [..] > > > > My suggestion is to not change the meaning of __FILE__ and instead fix the > > programs that uses __FILE__ for something they shouldn't. > > You should pass this re

Buildd-setup faffing around with __FILE__ breaks my unit tests.

2019-02-09 Thread Sune Vuorela
(Please keep me CC'ed. Not subscribed) The latest incarnations of the reproducible build autobuilder setup passes some options to gcc to not let __FILE__ actualy be the full file path, but some relative path. This breaks at least some of my unit tests. In this case, it is src:kookbook, but th

Re: Bug#894476: #894476: Solved from the Qt side. (rcc: please honour SOURCE_DATE_EPOCH)

2018-07-12 Thread Sune Vuorela
On Wednesday, July 11, 2018 10:08:23 PM CEST Vagrant Cascadian wrote: > Ideally QT_RCC_SOURCE_DATE_OVERRIDE would get set based on > SOURCE_DATE_EPOCH, otherwise build tools have an arbitrary growing No. As explained, we need to look at each individual package to check if the timestamp is actual