Bug#904685: diffoscope: RuntimeError when trying to extract an encrypted file (.bmp)

2018-08-05 Thread Ricardo Gaviria
s a bit too "wide" an exception class to catch? How narrow can > we safely make it? > > +raise ContainerExtractionError(member_name, exc) > > I think I would also like to see: > > * A comment in the except block explaining why we might be seei

Bug#904685: diffoscope: RuntimeError when trying to extract an encrypted file (.bmp)

2018-08-04 Thread Ricardo Gaviria
Jul 27, 2018 at 5:28 PM Ricardo Gaviria wrote: > Perfect! thanks for the clarification. Will look into it so ;) > > P.S. I love diffoscope! > > On Fri, Jul 27, 2018 at 5:26 PM Chris Lamb wrote: > >> Hi Ricardo, >> >> > By the way, if this is a lower priority

Bug#904685: diffoscope: RuntimeError when trying to extract an encrypted file (.bmp)

2018-07-27 Thread Ricardo Gaviria
> c) Be compared in a fallback (ie. binary) fashion > > Hope that helps. :) > > > Regards, > > -- > ,''`. > : :' : Chris Lamb > `. `'` la...@debian.org / chris-lamb.co.uk >`- > -- Regards, Ricardo Gaviria Soft

Bug#904685: diffoscope: RuntimeError when trying to extract an encrypted file (.bmp)

2018-07-27 Thread Ricardo Gaviria
By the way, if this is a lower priority bug than others. I will gladly have a look into the issue and try and resolve it, provided that we agree on the expected behaviour of the tool under such a scenario. Ricardo On Fri, Jul 27, 2018 at 5:14 PM Ricardo Gaviria wrote: > Hi Chris, > &g

Bug#904685: diffoscope: RuntimeError when trying to extract an encrypted file (.bmp)

2018-07-26 Thread Ricardo Gaviria
unzip 6.0-20ubuntu1 ii vim-common 2:7.4.1689-3ubuntu1.2 ii xz-utils 5.1.1alpha+20120614-2ubuntu2 Versions of packages diffoscope suggests: ii libjs-jquery 1.11.3+dfsg-4 -- no debconf information -- Regards, R