Re: Bug#909076: ghostscript: ps2ascii crashes: Error: /typecheck in --.bind--

2018-09-18 Thread Salvatore Bonaccorso
hi, On Tue, Sep 18, 2018 at 09:58:10AM +0200, Mattia Rizzolo wrote: > Package: ghostscript > Version: 9.20~dfsg-3.2+deb9u5 > Severity: serious > X-Debbugs-CC: t...@security.debian.org, Moritz Mühlenhoff , > reproducible-bui...@lists.alioth.debian.org > Control: affects -1 diffoscope > > Dear mai

Bug#909122: diffoscope: MemoryError when comparing big ISO images

2018-09-18 Thread Chris Lamb
Hi Marek, > magic text in commit message to link it with this bug? Sure: "Blah blah blah. (Closes: #909122)" Thanks! Best wishes, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `- ___ Repr

Bug#909122: diffoscope: MemoryError when comparing big ISO images

2018-09-18 Thread Daniel Shahaf
Marek Marczykowski-Górecki wrote on Tue, 18 Sep 2018 21:09 +0200: > On Tue, Sep 18, 2018 at 09:00:11PM +0200, Marek Marczykowski-Górecki wrote: > > On Tue, Sep 18, 2018 at 06:39:28PM +, Daniel Shahaf wrote: > > > Slurping the file to a string object is an antipattern. Instead of > > > using f.

Bug#909122: diffoscope: MemoryError when comparing big ISO images

2018-09-18 Thread Marek Marczykowski-Górecki
On Tue, Sep 18, 2018 at 09:00:11PM +0200, Marek Marczykowski-Górecki wrote: > On Tue, Sep 18, 2018 at 06:39:28PM +, Daniel Shahaf wrote: > > Slurping the file to a string object is an antipattern. Instead of > > using f.read() to create a 4.5GB string, it would be better to use > > json.load(f

Bug#909122: diffoscope: MemoryError when comparing big ISO images

2018-09-18 Thread Marek Marczykowski-Górecki
On Tue, Sep 18, 2018 at 06:39:28PM +, Daniel Shahaf wrote: > Slurping the file to a string object is an antipattern. Instead of > using f.read() to create a 4.5GB string, it would be better to use > json.load(f) to read the file incrementally. That should raise an > exception rather quickly.

Bug#909122: diffoscope: MemoryError when comparing big ISO images

2018-09-18 Thread Daniel Shahaf
Marek Marczykowski-Górecki wrote on Tue, Sep 18, 2018 at 20:17:03 +0200: > File "/usr/lib/python3/dist-packages/diffoscope/comparators/json.py", > line 52, in recognizes > f.read().decode('utf-8', errors='ignore'), > MemoryError > > The JSONFile.recognizes function, for context: >

Bug#909122: diffoscope: MemoryError when comparing big ISO images

2018-09-18 Thread Chris Lamb
Hi Marek, > The whole thing could be avoided if earlier check (if initial 10 chars > contains '[' or '{') would be executed not only on "text" files. Indeed. The origins of this appear to be: https://salsa.debian.org/reproducible-builds/diffoscope/commit/2a758d3d0205e934ed6dffebb5d6462b00fe59

Bug#909122: diffoscope: MemoryError when comparing big ISO images

2018-09-18 Thread Marek Marczykowski-Górecki
Package: diffoscope Version: 101 Severity: normal Dear Maintainer, When comparing two 4.5GB ISO images, diffoscope tries to load them into memory, which fails with MemoryError in json comparator: Traceback (most recent call last): File "/usr/lib/python3/dist-packages/diffoscope/main.py

Re: [rb-general] Please review the draft for week 177's blog post

2018-09-18 Thread Chris Lamb
Chris Lamb wrote: > Please review the draft for week 177's blog post [..] This has now been published; many thanks to all who contributed. Please share the following URL: https://reproducible-builds.org/blog/posts/177/ Alternatively, if you are into that kind of thing, please consider retwee

diffoscope_101~bpo9+1_amd64.changes ACCEPTED into stretch-backports

2018-09-18 Thread Debian FTP Masters
Accepted: -BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Format: 1.8 Date: Tue, 18 Sep 2018 09:25:03 +0200 Source: diffoscope Binary: diffoscope Architecture: source all Version: 101~bpo9+1 Distribution: stretch-backports Urgency: medium Maintainer: Reproducible builds folks Changed-By: Matt

Processing of diffoscope_101~bpo9+1_amd64.changes

2018-09-18 Thread Debian FTP Masters
diffoscope_101~bpo9+1_amd64.changes uploaded successfully to localhost along with the files: diffoscope_101~bpo9+1.dsc diffoscope_101~bpo9+1.tar.xz diffoscope_101~bpo9+1_all.deb diffoscope_101~bpo9+1_amd64.buildinfo Greetings, Your Debian queue daemon (running on host usper.debian

Bug#909076: ghostscript: ps2ascii crashes: Error: /typecheck in --.bind--

2018-09-18 Thread Mattia Rizzolo
Package: ghostscript Version: 9.20~dfsg-3.2+deb9u5 Severity: serious X-Debbugs-CC: t...@security.debian.org, Moritz Mühlenhoff , reproducible-bui...@lists.alioth.debian.org Control: affects -1 diffoscope Dear maintainer, after the latest ghostscript security update, ps2ascii started to crash: |